Linux clock framework development
 help / color / mirror / Atom feed
From: Varadarajan Narayanan <quic_varada@quicinc.com>
To: <andersson@kernel.org>, <konrad.dybcio@linaro.org>,
	<mturquette@baylibre.com>, <sboyd@kernel.org>, <robh@kernel.org>,
	<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
	<djakov@kernel.org>, <quic_varada@quicinc.com>,
	<dmitry.baryshkov@linaro.org>, <quic_anusha@quicinc.com>,
	<linux-arm-msm@vger.kernel.org>, <linux-clk@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-pm@vger.kernel.org>
Cc: kernel test robot <lkp@intel.com>
Subject: [PATCH v6 2/6] interconnect: icc-clk: Remove tristate from INTERCONNECT_CLK
Date: Tue, 2 Apr 2024 16:04:02 +0530	[thread overview]
Message-ID: <20240402103406.3638821-3-quic_varada@quicinc.com> (raw)
In-Reply-To: <20240402103406.3638821-1-quic_varada@quicinc.com>

drivers/clk/qcom/common.c uses devm_icc_clk_register under
IS_ENABLED(CONFIG_INTERCONNECT_CLK). However, in kernel bot
random config build test, with the following combination

	CONFIG_COMMON_CLK_QCOM=y
		and
	CONFIG_INTERCONNECT_CLK=m

the following error is seen as devm_icc_clk_register is in a
module and being referenced from vmlinux.

	powerpc64-linux-ld: drivers/clk/qcom/common.o: in function `qcom_cc_really_probe':
	>> common.c:(.text+0x980): undefined reference to `devm_icc_clk_register'

Hence, ensure INTERCONNECT_CLK is not selected as a module.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202404012258.MFriF5BV-lkp@intel.com/
Fixes: 0ac2a08f42ce ("interconnect: add clk-based icc provider support")
Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com>
---
 drivers/interconnect/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/interconnect/Kconfig b/drivers/interconnect/Kconfig
index 5faa8d2aecff..f44be5469382 100644
--- a/drivers/interconnect/Kconfig
+++ b/drivers/interconnect/Kconfig
@@ -16,7 +16,6 @@ source "drivers/interconnect/qcom/Kconfig"
 source "drivers/interconnect/samsung/Kconfig"
 
 config INTERCONNECT_CLK
-	tristate
 	depends on COMMON_CLK
 	help
 	  Support for wrapping clocks into the interconnect nodes.
-- 
2.34.1


  parent reply	other threads:[~2024-04-02 10:34 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-02 10:34 [PATCH v6 0/6] Add interconnect driver for IPQ9574 SoC Varadarajan Narayanan
2024-04-02 10:34 ` [PATCH v6 1/6] dt-bindings: interconnect: Add Qualcomm IPQ9574 support Varadarajan Narayanan
2024-04-03  7:09   ` Krzysztof Kozlowski
2024-04-03 10:44     ` Varadarajan Narayanan
2024-04-02 10:34 ` Varadarajan Narayanan [this message]
2024-04-02 10:39   ` [PATCH v6 2/6] interconnect: icc-clk: Remove tristate from INTERCONNECT_CLK Dmitry Baryshkov
2024-04-02 14:49     ` Konrad Dybcio
2024-04-03 15:42   ` kernel test robot
2024-04-02 10:34 ` [PATCH v6 3/6] interconnect: icc-clk: Add devm_icc_clk_register Varadarajan Narayanan
2024-04-02 10:40   ` Dmitry Baryshkov
2024-04-02 10:48     ` Dmitry Baryshkov
2024-04-02 11:02       ` Varadarajan Narayanan
2024-04-02 11:16         ` Dmitry Baryshkov
2024-04-02 11:22           ` Varadarajan Narayanan
2024-04-02 12:12             ` Dmitry Baryshkov
2024-04-03 10:45               ` Varadarajan Narayanan
2024-04-02 10:34 ` [PATCH v6 4/6] clk: qcom: common: Add interconnect clocks support Varadarajan Narayanan
2024-04-02 10:48   ` Dmitry Baryshkov
2024-04-02 11:05     ` Varadarajan Narayanan
2024-04-02 10:34 ` [PATCH v6 5/6] clk: qcom: ipq9574: Use icc-clk for enabling NoC related clocks Varadarajan Narayanan
2024-04-02 10:34 ` [PATCH v6 6/6] arm64: dts: qcom: ipq9574: Add icc provider ability to gcc Varadarajan Narayanan
2024-04-02 10:48   ` Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240402103406.3638821-3-quic_varada@quicinc.com \
    --to=quic_varada@quicinc.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=djakov@kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=mturquette@baylibre.com \
    --cc=quic_anusha@quicinc.com \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox