From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
To: abelvesa@kernel.org, mturquette@baylibre.com, sboyd@kernel.org,
shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com
Cc: imx@lists.linux.dev, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Jacky Bai <ping.bai@nxp.com>,
Peng Fan <peng.fan@nxp.com>, Chancel Liu <chancel.liu@nxp.com>
Subject: [PATCH V3 02/15] clk: imx: composite-93: keep root clock on when mcore enabled
Date: Fri, 7 Jun 2024 21:33:34 +0800 [thread overview]
Message-ID: <20240607133347.3291040-3-peng.fan@oss.nxp.com> (raw)
In-Reply-To: <20240607133347.3291040-1-peng.fan@oss.nxp.com>
From: Jacky Bai <ping.bai@nxp.com>
Previously we assumed that the root clock slice is enabled
by default when kernel boot up. But the bootloader may disable
the clocks before jump into kernel. The gate ops should be registered
rather than NULL to make sure the disabled clock can be enabled
when kernel boot up. Refine the code to skip disable the clock
if mcore booted.
Fixes: a740d7350ff7 ("clk: imx: imx93: add mcore_booted module paratemter")
Signed-off-by: Jacky Bai <ping.bai@nxp.com>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
Tested-by: Chancel Liu <chancel.liu@nxp.com>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
drivers/clk/imx/clk-composite-93.c | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/drivers/clk/imx/clk-composite-93.c b/drivers/clk/imx/clk-composite-93.c
index 81164bdcd6cc..6c6c5a30f328 100644
--- a/drivers/clk/imx/clk-composite-93.c
+++ b/drivers/clk/imx/clk-composite-93.c
@@ -76,6 +76,13 @@ static int imx93_clk_composite_gate_enable(struct clk_hw *hw)
static void imx93_clk_composite_gate_disable(struct clk_hw *hw)
{
+ /*
+ * Skip disable the root clock gate if mcore enabled.
+ * The root clock may be used by the mcore.
+ */
+ if (mcore_booted)
+ return;
+
imx93_clk_composite_gate_endisable(hw, 0);
}
@@ -222,7 +229,7 @@ struct clk_hw *imx93_clk_composite_flags(const char *name, const char * const *p
hw = clk_hw_register_composite(NULL, name, parent_names, num_parents,
mux_hw, &clk_mux_ro_ops, div_hw,
&clk_divider_ro_ops, NULL, NULL, flags);
- } else if (!mcore_booted) {
+ } else {
gate = kzalloc(sizeof(*gate), GFP_KERNEL);
if (!gate)
goto fail;
@@ -238,12 +245,6 @@ struct clk_hw *imx93_clk_composite_flags(const char *name, const char * const *p
&imx93_clk_composite_divider_ops, gate_hw,
&imx93_clk_composite_gate_ops,
flags | CLK_SET_RATE_NO_REPARENT);
- } else {
- hw = clk_hw_register_composite(NULL, name, parent_names, num_parents,
- mux_hw, &imx93_clk_composite_mux_ops, div_hw,
- &imx93_clk_composite_divider_ops, NULL,
- &imx93_clk_composite_gate_ops,
- flags | CLK_SET_RATE_NO_REPARENT);
}
if (IS_ERR(hw))
--
2.37.1
next prev parent reply other threads:[~2024-06-07 13:25 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-07 13:33 [PATCH V3 00/15] clk: imx: misc update/fix Peng Fan (OSS)
2024-06-07 13:33 ` [PATCH V3 01/15] clk: imx: composite-8m: Enable gate clk with mcore_booted Peng Fan (OSS)
2024-06-07 13:33 ` Peng Fan (OSS) [this message]
2024-06-07 13:33 ` [PATCH V3 03/15] clk: imx: composite-7ulp: Check the PCC present bit Peng Fan (OSS)
2024-06-07 13:33 ` [PATCH V3 04/15] clk: imx: fracn-gppll: fix fractional part of PLL getting lost Peng Fan (OSS)
2024-06-07 13:33 ` [PATCH V3 05/15] clk: imx: imx8mp-audiomix: remove sdma root clock Peng Fan (OSS)
2024-07-14 17:02 ` Adam Ford
2024-07-15 1:11 ` Peng Fan
2024-07-16 0:02 ` Adam Ford
2024-07-16 1:24 ` Peng Fan
2024-07-16 1:50 ` Adam Ford
2024-07-17 12:21 ` Peng Fan
2024-06-07 13:33 ` [PATCH V3 06/15] clk: imx: imx8mp: fix clock tree update of TF-A managed clocks Peng Fan (OSS)
2024-06-07 13:33 ` [PATCH V3 07/15] clk: imx: Remove CLK_SET_PARENT_GATE for DRAM mux for i.MX7D Peng Fan (OSS)
2024-06-07 13:33 ` [PATCH V3 08/15] clk: imx: add CLK_SET_RATE_PARENT for lcdif_pixel_src " Peng Fan (OSS)
2024-06-07 13:33 ` [PATCH V3 09/15] clk: imx: imx8mn: add sai7_ipg_clk clock settings Peng Fan (OSS)
2024-06-07 13:33 ` [PATCH V3 10/15] clk: imx: imx8mm: Change the 'nand_usdhc_bus' clock to non-critical one Peng Fan (OSS)
2024-06-07 13:33 ` [PATCH V3 11/15] clk: imx: imx8qxp: Add LVDS bypass clocks Peng Fan (OSS)
2024-06-07 13:33 ` [PATCH V3 12/15] clk: imx: imx8qxp: Add clock muxes for MIPI and PHY ref clocks Peng Fan (OSS)
2024-06-07 13:33 ` [PATCH V3 13/15] clk: imx: imx8qxp: Register dc0_bypass0_clk before disp clk Peng Fan (OSS)
2024-06-07 13:33 ` [PATCH V3 14/15] clk: imx: imx8qxp: Parent should be initialized earlier than the clock Peng Fan (OSS)
2024-06-07 13:33 ` [PATCH V3 15/15] clk: imx: fracn-gppll: update rate table Peng Fan (OSS)
2024-06-18 12:16 ` [PATCH V3 00/15] clk: imx: misc update/fix Peng Fan
2024-06-21 4:35 ` Abel Vesa
2024-06-21 6:24 ` Abel Vesa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240607133347.3291040-3-peng.fan@oss.nxp.com \
--to=peng.fan@oss.nxp.com \
--cc=abelvesa@kernel.org \
--cc=chancel.liu@nxp.com \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=peng.fan@nxp.com \
--cc=ping.bai@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox