From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
To: abelvesa@kernel.org, mturquette@baylibre.com, sboyd@kernel.org,
shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com
Cc: imx@lists.linux.dev, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Ye Li <ye.li@nxp.com>,
Peng Fan <peng.fan@nxp.com>
Subject: [PATCH V3 03/15] clk: imx: composite-7ulp: Check the PCC present bit
Date: Fri, 7 Jun 2024 21:33:35 +0800 [thread overview]
Message-ID: <20240607133347.3291040-4-peng.fan@oss.nxp.com> (raw)
In-Reply-To: <20240607133347.3291040-1-peng.fan@oss.nxp.com>
From: Ye Li <ye.li@nxp.com>
When some module is disabled by fuse, its PCC PR bit is default 0 and
PCC is not operational. Any write to this PCC will cause SError.
Fixes: b40ba8065347 ("clk: imx: Update the compsite driver to support imx8ulp")
Reviewed-by: Peng Fan <peng.fan@nxp.com>
Signed-off-by: Ye Li <ye.li@nxp.com>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
drivers/clk/imx/clk-composite-7ulp.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/clk/imx/clk-composite-7ulp.c b/drivers/clk/imx/clk-composite-7ulp.c
index e208ddc51133..db7f40b07d1a 100644
--- a/drivers/clk/imx/clk-composite-7ulp.c
+++ b/drivers/clk/imx/clk-composite-7ulp.c
@@ -14,6 +14,7 @@
#include "../clk-fractional-divider.h"
#include "clk.h"
+#define PCG_PR_MASK BIT(31)
#define PCG_PCS_SHIFT 24
#define PCG_PCS_MASK 0x7
#define PCG_CGC_SHIFT 30
@@ -78,6 +79,12 @@ static struct clk_hw *imx_ulp_clk_hw_composite(const char *name,
struct clk_hw *hw;
u32 val;
+ val = readl(reg);
+ if (!(val & PCG_PR_MASK)) {
+ pr_info("PCC PR is 0 for clk:%s, bypass\n", name);
+ return 0;
+ }
+
if (mux_present) {
mux = kzalloc(sizeof(*mux), GFP_KERNEL);
if (!mux)
--
2.37.1
next prev parent reply other threads:[~2024-06-07 13:25 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-07 13:33 [PATCH V3 00/15] clk: imx: misc update/fix Peng Fan (OSS)
2024-06-07 13:33 ` [PATCH V3 01/15] clk: imx: composite-8m: Enable gate clk with mcore_booted Peng Fan (OSS)
2024-06-07 13:33 ` [PATCH V3 02/15] clk: imx: composite-93: keep root clock on when mcore enabled Peng Fan (OSS)
2024-06-07 13:33 ` Peng Fan (OSS) [this message]
2024-06-07 13:33 ` [PATCH V3 04/15] clk: imx: fracn-gppll: fix fractional part of PLL getting lost Peng Fan (OSS)
2024-06-07 13:33 ` [PATCH V3 05/15] clk: imx: imx8mp-audiomix: remove sdma root clock Peng Fan (OSS)
2024-07-14 17:02 ` Adam Ford
2024-07-15 1:11 ` Peng Fan
2024-07-16 0:02 ` Adam Ford
2024-07-16 1:24 ` Peng Fan
2024-07-16 1:50 ` Adam Ford
2024-07-17 12:21 ` Peng Fan
2024-06-07 13:33 ` [PATCH V3 06/15] clk: imx: imx8mp: fix clock tree update of TF-A managed clocks Peng Fan (OSS)
2024-06-07 13:33 ` [PATCH V3 07/15] clk: imx: Remove CLK_SET_PARENT_GATE for DRAM mux for i.MX7D Peng Fan (OSS)
2024-06-07 13:33 ` [PATCH V3 08/15] clk: imx: add CLK_SET_RATE_PARENT for lcdif_pixel_src " Peng Fan (OSS)
2024-06-07 13:33 ` [PATCH V3 09/15] clk: imx: imx8mn: add sai7_ipg_clk clock settings Peng Fan (OSS)
2024-06-07 13:33 ` [PATCH V3 10/15] clk: imx: imx8mm: Change the 'nand_usdhc_bus' clock to non-critical one Peng Fan (OSS)
2024-06-07 13:33 ` [PATCH V3 11/15] clk: imx: imx8qxp: Add LVDS bypass clocks Peng Fan (OSS)
2024-06-07 13:33 ` [PATCH V3 12/15] clk: imx: imx8qxp: Add clock muxes for MIPI and PHY ref clocks Peng Fan (OSS)
2024-06-07 13:33 ` [PATCH V3 13/15] clk: imx: imx8qxp: Register dc0_bypass0_clk before disp clk Peng Fan (OSS)
2024-06-07 13:33 ` [PATCH V3 14/15] clk: imx: imx8qxp: Parent should be initialized earlier than the clock Peng Fan (OSS)
2024-06-07 13:33 ` [PATCH V3 15/15] clk: imx: fracn-gppll: update rate table Peng Fan (OSS)
2024-06-18 12:16 ` [PATCH V3 00/15] clk: imx: misc update/fix Peng Fan
2024-06-21 4:35 ` Abel Vesa
2024-06-21 6:24 ` Abel Vesa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240607133347.3291040-4-peng.fan@oss.nxp.com \
--to=peng.fan@oss.nxp.com \
--cc=abelvesa@kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=peng.fan@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=ye.li@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox