* [PATCH] clk: qcom: gcc-sc8280xp: drop obsolete PCIe GDSC comment
@ 2025-09-10 13:47 Johan Hovold
2025-09-10 13:57 ` Konrad Dybcio
2025-09-12 2:38 ` Bjorn Andersson
0 siblings, 2 replies; 3+ messages in thread
From: Johan Hovold @ 2025-09-10 13:47 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Michael Turquette, Stephen Boyd, linux-arm-msm, linux-clk,
linux-kernel, Johan Hovold
Drop an obsolete comment about keeping the PCIe GDSCs always-on,
something which is no longer the case since commit db382dd55bcb ("clk:
qcom: gcc-sc8280xp: Allow PCIe GDSCs to enter retention state").
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
drivers/clk/qcom/gcc-sc8280xp.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/clk/qcom/gcc-sc8280xp.c b/drivers/clk/qcom/gcc-sc8280xp.c
index f27d0003f427..b683795475e3 100644
--- a/drivers/clk/qcom/gcc-sc8280xp.c
+++ b/drivers/clk/qcom/gcc-sc8280xp.c
@@ -6775,10 +6775,6 @@ static struct gdsc pcie_1_tunnel_gdsc = {
.flags = VOTABLE | RETAIN_FF_ENABLE,
};
-/*
- * The Qualcomm PCIe driver does not yet implement suspend so to keep the
- * PCIe power domains always-on for now.
- */
static struct gdsc pcie_2a_gdsc = {
.gdscr = 0x9d004,
.collapse_ctrl = 0x52128,
--
2.49.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] clk: qcom: gcc-sc8280xp: drop obsolete PCIe GDSC comment
2025-09-10 13:47 [PATCH] clk: qcom: gcc-sc8280xp: drop obsolete PCIe GDSC comment Johan Hovold
@ 2025-09-10 13:57 ` Konrad Dybcio
2025-09-12 2:38 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Konrad Dybcio @ 2025-09-10 13:57 UTC (permalink / raw)
To: Johan Hovold, Bjorn Andersson
Cc: Michael Turquette, Stephen Boyd, linux-arm-msm, linux-clk,
linux-kernel
On 9/10/25 3:47 PM, Johan Hovold wrote:
> Drop an obsolete comment about keeping the PCIe GDSCs always-on,
> something which is no longer the case since commit db382dd55bcb ("clk:
> qcom: gcc-sc8280xp: Allow PCIe GDSCs to enter retention state").
>
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
They're not quite off yet, but they're not perma-on either, so I
suppose it makes sense:
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] clk: qcom: gcc-sc8280xp: drop obsolete PCIe GDSC comment
2025-09-10 13:47 [PATCH] clk: qcom: gcc-sc8280xp: drop obsolete PCIe GDSC comment Johan Hovold
2025-09-10 13:57 ` Konrad Dybcio
@ 2025-09-12 2:38 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2025-09-12 2:38 UTC (permalink / raw)
To: Johan Hovold
Cc: Michael Turquette, Stephen Boyd, linux-arm-msm, linux-clk,
linux-kernel
On Wed, 10 Sep 2025 15:47:37 +0200, Johan Hovold wrote:
> Drop an obsolete comment about keeping the PCIe GDSCs always-on,
> something which is no longer the case since commit db382dd55bcb ("clk:
> qcom: gcc-sc8280xp: Allow PCIe GDSCs to enter retention state").
>
>
Applied, thanks!
[1/1] clk: qcom: gcc-sc8280xp: drop obsolete PCIe GDSC comment
commit: 4ca6a89f38718d6cd84304e6a26e7ddc90e03356
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-09-12 2:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-10 13:47 [PATCH] clk: qcom: gcc-sc8280xp: drop obsolete PCIe GDSC comment Johan Hovold
2025-09-10 13:57 ` Konrad Dybcio
2025-09-12 2:38 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox