Re: [PATCH v2 3/5] dt-bindings: clock: sun55i-a523-ccu: Add A523 CPU CCU clock controller

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: clock: sun55i-a523-ccu: CPU CCU incorrectly requires #reset-cells
--

commit 6b88ed1238e42f9cf204f24c2d92453688b20a13
Author: Andre Przywara <andre.przywara@arm.com>

dt-bindings: clock: sun55i-a523-ccu: Add A523 CPU CCU clock controller
    
There are four clock controllers in the A523 SoC, but only three are
described in the DT binding so far.
    
Add a description for the CPU CCU, which provides separate clocks for
the two CPU clusters and the DSU interconnect.

> diff --git a/Documentation/devicetree/bindings/clock/allwinner,sun55i-a523-ccu.yaml b/Documentation/devicetree/bindings/clock/allwinner,sun55i-a523-ccu.yaml
> index 58be701a720ea..98d47d2aabc48 100644
> --- a/Documentation/devicetree/bindings/clock/allwinner,sun55i-a523-ccu.yaml
> +++ b/Documentation/devicetree/bindings/clock/allwinner,sun55i-a523-ccu.yaml
> @@ -19,6 +19,7 @@ properties:
>    compatible:
>      enum:
>        - allwinner,sun55i-a523-ccu
> +      - allwinner,sun55i-a523-cpu-ccu

[Severity: Low]
Does the new sun55i-a523-cpu-ccu compatible string incorrectly inherit the
global #reset-cells requirement?

Looking at the binding, #reset-cells is globally required:

required:
  - "#clock-cells"
  - "#reset-cells"
  - compatible

Since the CPU CCU does not seem to provide resets, will this force device tree
nodes to include an unnecessary #reset-cells property to pass schema
validation?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260917223913.1855301-1-andre.przywara@arm.com?part=3