Re: [PATCH v2 09/11] media: vsp1: Add device info entries for VSPD on X5H

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] media: vsp1: missing FCP soft reset for VSPDB_GEN4 in vsp1_reset_wpf()
--

commit e44fed2186edca41909b450ebb5d732a1d4b0faa
Author: Paul Elder <paul.elder+renesas@ideasonboard.com>

media: vsp1: Add device info entries for VSPD on X5H

Add device info entries for the VSPD so that the driver can match on the
VSPD on the X5H and handle it slightly different hardware configuration.
On the X5H there are two variants, the VSPD (a) and VSPD (b).

> diff --git a/drivers/media/platform/renesas/vsp1/vsp1_drv.c b/drivers/media/platform/renesas/vsp1/vsp1_drv.c
> index 5597595414fe7..627771e305661 100644
> --- a/drivers/media/platform/renesas/vsp1/vsp1_drv.c
> +++ b/drivers/media/platform/renesas/vsp1/vsp1_drv.c

[ ... ]

> @@ -870,6 +881,17 @@ static const struct vsp1_device_info vsp1_device_infos[] = {
>  		.uif_count = 2,
>  		.wpf_count = 1,
>  		.num_bru_inputs = 5,
> +	}, {
> +		.version = VI6_IP_VERSION_MODEL_VSPDB_GEN4,
> +		.model = "VSP2-D (b)",
> +		.soc = VI6_IP_VERSION_SOC_X5H,
> +		.gen = 4,
> +		.features = VSP1_HAS_BRU | VSP1_HAS_EXT_DL,
> +		.lif_count = 1,
> +		.rpf_count = 5,
> +		.uif_count = 1,
> +		.wpf_count = 1,
> +		.num_bru_inputs = 5,
>  	}, {

[Severity: High]
Does vsp1_reset_wpf() also need to be updated to handle this new hardware
variant?

Looking at vsp1_reset_wpf() earlier in this file, the explicit version check
bypasses the reset for VI6_IP_VERSION_MODEL_VSPDB_GEN4:

	if (version == VI6_IP_VERSION_MODEL_VSPD_GEN3 ||
	    version == VI6_IP_VERSION_MODEL_VSPD_GEN4)
		ret = rcar_fcp_soft_reset(vsp1->fcp);

This could leave the attached Frame Compression Processor (FCP) unreset during
WPF resets. 

Since vsp1_reset_wpf() is executed on driver probe and V4L2 stream start/stop,
could this cause state desynchronization between the VSP and FCP, leading to
pipeline stalls or failures during streaming operations?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260919-epaul-v7-3-rc1-x5h-vsp-fcp-v2-0-dbe9236bfd22@ideasonboard.com?part=9