From: sashiko-bot@kernel.org
To: "Sebastian Reichel" <sebastian.reichel@collabora.com>
Cc: robh@kernel.org, devicetree@vger.kernel.org,
linux-clk@vger.kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v2 4/8] PM / devfreq: rockchip-dfi: add NO_INTERRUPT perf capability
Date: Mon, 21 Sep 2026 20:39:48 +0000 [thread overview]
Message-ID: <20260921203948.C68D71F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260921-rockchip-dfi-cleanup-v2-4-43ff34ac8599@collabora.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] perf: logic inversion in commit message regarding sampling support
--
commit 568c8dc55a298020ff3044a68b97809f490ba7e0
Author: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
PM / devfreq: rockchip-dfi: add NO_INTERRUPT perf capability
This commit adds the PERF_PMU_CAP_NO_INTERRUPT capability flag to the
rockchip-dfi PMU. This informs the perf core that the PMU does not support
sampling.
Link: https://lore.kernel.org/all/20250619140442.GH1613376@noisy.programming.kicks-ass.net/ [1]
> The perf subsystem's PERF_PMU_CAP_NO_INTERRUPT is a bit of a
> misnomer.[1] Instead of meaning that the PMU has no interrupt, it
> actually means that the PMU does support sampling. On CPU PMUs, this is
[Severity: Low]
Is there a missing "not" in this sentence?
In kernel/events/core.c, if a sampling event is requested for a PMU with this
flag, the allocation fails with -EOPNOTSUPP. Thus, the flag means the PMU does
not support sampling.
The code in drivers/devfreq/event/rockchip-dfi.c:rockchip_ddr_perf_init()
correctly applies the flag, so there is no functional issue, but the commit
message contains a logic inversion.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260921-rockchip-dfi-cleanup-v2-0-43ff34ac8599@collabora.com?part=4
next prev parent reply other threads:[~2026-09-21 20:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 20:32 [PATCH v2 0/8] PM / devfreq: rockchip-dfi: cleanups Sebastian Reichel
2026-09-21 20:32 ` [PATCH v2 1/8] dt-bindings: clock: rk3588: add PCLK_DDR_MON_CH clocks Sebastian Reichel
2026-10-05 17:10 ` Rob Herring (Arm)
2026-09-21 20:32 ` [PATCH v2 2/8] dt-bindings: devfreq: event: rockchip,dfi: add clocks to rk3588 Sebastian Reichel
2026-09-21 20:41 ` sashiko-bot
2026-10-05 17:10 ` Rob Herring (Arm)
2026-09-21 20:32 ` [PATCH v2 3/8] PM / devfreq: rockchip-dfi: move to per-variant const structs Sebastian Reichel
2026-09-21 20:32 ` [PATCH v2 4/8] PM / devfreq: rockchip-dfi: add NO_INTERRUPT perf capability Sebastian Reichel
2026-09-21 20:39 ` sashiko-bot [this message]
2026-09-21 20:32 ` [PATCH v2 5/8] PM / devfreq: rockchip-dfi: use bulk clock APIs Sebastian Reichel
2026-09-21 20:32 ` [PATCH v2 6/8] clk: rockchip: rk3588: add PCLK_DDR_MON_CH gate branches Sebastian Reichel
2026-09-21 20:32 ` [PATCH v2 7/8] PM / devfreq: rockchip-dfi: make RK3588 use its clocks Sebastian Reichel
2026-09-21 20:46 ` sashiko-bot
2026-09-21 20:32 ` [PATCH v2 8/8] arm64: dts: rockchip: add dfi clocks on RK3588 Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260921203948.C68D71F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox