Re: [PATCH v2 7/8] PM / devfreq: rockchip-dfi: make RK3588 use its clocks

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] kerneldoc: mismatch for num_clks in struct rockchip_dfi_variant
--

commit 27e02ec68846e2b57e63f7073dbf4cd24e5115ea
Author: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>

PM / devfreq: rockchip-dfi: make RK3588 use its clocks

This commit updates the RK3588 devfreq driver to utilize its recently modelled
DDRMON clocks. It adds a clocks_optional field to the dfi variant structure
so older device trees remain compatible without introducing a breaking change.

> diff --git a/drivers/devfreq/event/rockchip-dfi.c b/drivers/devfreq/event/rockchip-dfi.c
> index b61ec500eaed9..380361a231a20 100644
> --- a/drivers/devfreq/event/rockchip-dfi.c
> +++ b/drivers/devfreq/event/rockchip-dfi.c
> @@ -117,6 +117,18 @@ struct rockchip_dfi {
>  	const struct rockchip_dfi_variant *variant;
>  };
>  
> +/**
> + * struct rockchip_dfi_variant
> + * @init: pointer to the variant-specific initialisation function
> + * @stride: address offset between the DDRMON per-channel instances
> + * @ctrl_single: whether only one DDRMON instance monitors multiple channels
> + * @max_channels: maximum number of memory channels for this SoC
> + * @clk_names: pointer to a constant array of constant clock name strings
> + * @num_clk: the number of elements in the @clk_names array

[Severity: Low]
This isn't a bug, but does this kerneldoc parameter mismatch the struct
definition? The struct member is defined as num_clks, while this block
documents num_clk, which will trigger a kernel-doc script warning.

> + * @clocks_optional: whether not finding the clocks is non-fatal. Set if the
> + *                   DT binding for this variant didn't require clocks in the
> + *                   past, so that the driver remains compatible with old DTs.
> + */
>  struct rockchip_dfi_variant {
>  	int (*init)(struct rockchip_dfi *dfi);
>  	int stride;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260921-rockchip-dfi-cleanup-v2-0-43ff34ac8599@collabora.com?part=7