From: Heiko Stuebner <heiko@sntech.de>
To: Caesar Wang <caesar.upstream@gmail.com>
Cc: Caesar Wang <wxt@rock-chips.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
leecam@google.com, linux-arm-kernel@lists.infradead.org,
keescook@google.com, linux-clk@vger.kernel.org,
leozwang@google.com
Subject: Re: [PATCH v2 04/12] clk: rockchip: rk3036: enable the CLK_IGNORE_UNUSED flag for sclk_i2s_out
Date: Fri, 08 Jan 2016 10:46:26 +0100 [thread overview]
Message-ID: <20757797.djuaztrzGE@phil> (raw)
In-Reply-To: <568F80BA.6060209@gmail.com>
Hi Caesar,
Am Freitag, 8. Januar 2016, 17:26:18 schrieb Caesar Wang:
> =E5=9C=A8 2016=E5=B9=B401=E6=9C=8807=E6=97=A5 18:05, Heiko Stuebner =E5=
=86=99=E9=81=93:
> > Am Donnerstag, 7. Januar 2016, 16:25:47 schrieb Caesar Wang:
> >> SCLk_I2S_OUT is the noc bus clock for i2s module, this clock is us=
ed by
> >> extra codecs.
> >>=20
> >> Due to it shouldn't belong to any driver, but we need it enabled,
> >> so just mark it as the CLK_IGNORE_UNUSED flag.
> >=20
> > What makes you think it shouldn't belong to any driver?
> >=20
> > In most schematics I have, i2s_clkout is going to some clock-input =
of
> > the
> > audio codec - probably the MCLK input on your rt5616. And while the=
new
> > rt5616 driver does not seem to do clock handling, it should just ha=
ndle
> > the clock using the normal APIs.
>=20
> You are right, that's seem has to find the root cause.
> I'm wonder that the codec/i2s is working in kernel v4.1 patch without=
it.
>=20
> In general, the MLCK will be handled in i2s driver if the cpu side i=
s
> master.
looking at the rt5616 datasheet, that would be BCLK1 instead I think. T=
his=20
one does differentiate between being master/slave.
The master/sysclk (mclk) is also handled in other drivers in all cases.=
=20
(da7213.c, da7219.c, max98090.c, max98095.c, probably more)
Heiko
next prev parent reply other threads:[~2016-01-08 9:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 8:25 [PATCH v2 00/12] Add the family patches to support for kylin board Caesar Wang
2016-01-07 8:25 ` [PATCH v2 04/12] clk: rockchip: rk3036: enable the CLK_IGNORE_UNUSED flag for sclk_i2s_out Caesar Wang
2016-01-07 10:05 ` Heiko Stuebner
2016-01-08 9:26 ` Caesar Wang
2016-01-08 9:46 ` Heiko Stuebner [this message]
2016-01-13 8:10 ` Caesar Wang
2016-01-07 10:44 ` [PATCH v2 00/12] Add the family patches to support for kylin board Heiko Stuebner
2016-01-08 9:02 ` Caesar Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20757797.djuaztrzGE@phil \
--to=heiko@sntech.de \
--cc=caesar.upstream@gmail.com \
--cc=keescook@google.com \
--cc=leecam@google.com \
--cc=leozwang@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
--cc=ulf.hansson@linaro.org \
--cc=wxt@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox