From: Heiko Stuebner <heiko@sntech.de>
To: Caesar Wang <wxt@rock-chips.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
linux-rockchip@lists.infradead.org, leecam@google.com,
leozwang@google.com, keescook@google.com,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 04/12] clk: rockchip: rk3036: enable the CLK_IGNORE_UNUSED flag for sclk_i2s_out
Date: Thu, 07 Jan 2016 11:05:06 +0100 [thread overview]
Message-ID: <290434099.8XFZ9qmNRz@phil> (raw)
In-Reply-To: <1452155155-16232-5-git-send-email-wxt@rock-chips.com>
Hi Caesar,
Am Donnerstag, 7. Januar 2016, 16:25:47 schrieb Caesar Wang:
> SCLk_I2S_OUT is the noc bus clock for i2s module, this clock is used by
> extra codecs.
>
> Due to it shouldn't belong to any driver, but we need it enabled,
> so just mark it as the CLK_IGNORE_UNUSED flag.
What makes you think it shouldn't belong to any driver?
In most schematics I have, i2s_clkout is going to some clock-input of the
audio codec - probably the MCLK input on your rt5616. And while the new
rt5616 driver does not seem to do clock handling, it should just handle the
clock using the normal APIs.
Heiko
next prev parent reply other threads:[~2016-01-07 10:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 8:25 [PATCH v2 00/12] Add the family patches to support for kylin board Caesar Wang
2016-01-07 8:25 ` [PATCH v2 04/12] clk: rockchip: rk3036: enable the CLK_IGNORE_UNUSED flag for sclk_i2s_out Caesar Wang
2016-01-07 10:05 ` Heiko Stuebner [this message]
2016-01-08 9:26 ` Caesar Wang
2016-01-08 9:46 ` Heiko Stuebner
2016-01-13 8:10 ` Caesar Wang
2016-01-07 10:44 ` [PATCH v2 00/12] Add the family patches to support for kylin board Heiko Stuebner
2016-01-08 9:02 ` Caesar Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=290434099.8XFZ9qmNRz@phil \
--to=heiko@sntech.de \
--cc=keescook@google.com \
--cc=leecam@google.com \
--cc=leozwang@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
--cc=ulf.hansson@linaro.org \
--cc=wxt@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox