From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Renjiang Han <quic_renjiang@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Stanimir Varbanov <stanimir.k.varbanov@gmail.com>,
Vikash Garodia <quic_vgarodia@quicinc.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH 2/2] venus: pm_helpers: Use dev_pm_genpd_set_hwmode to switch GDSC mode on V4
Date: Fri, 22 Nov 2024 12:50:56 +0000 [thread overview]
Message-ID: <2299ec8f-4b80-48ea-96ed-d1eb40998e55@linaro.org> (raw)
In-Reply-To: <20241122-switch_gdsc_mode-v1-2-365f097ecbb0@quicinc.com>
On 22/11/2024 10:31, Renjiang Han wrote:
> - if (IS_V6(core))
> + if (IS_V6(core) || IS_V4(core))
sdm845 IS_V4()
The GDSCs for the clock OTOH are
static struct gdsc vcodec0_gdsc = {
.gdscr = 0x874,
.pd = {
.name = "vcodec0_gdsc",
},
.cxcs = (unsigned int []){ 0x890, 0x930 },
.cxc_count = 2,
.flags = HW_CTRL | POLL_CFG_GDSCR,
.pwrsts = PWRSTS_OFF_ON,
};
static struct gdsc vcodec1_gdsc = {
.gdscr = 0x8b4,
.pd = {
.name = "vcodec1_gdsc",
},
.cxcs = (unsigned int []){ 0x8d0, 0x950 },
.cxc_count = 2,
.flags = HW_CTRL | POLL_CFG_GDSCR,
.pwrsts = PWRSTS_OFF_ON,
};
I can't see how this series will work on 845.
---
bod
next prev parent reply other threads:[~2024-11-22 12:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-22 10:31 [PATCH 0/2] Use APIs in gdsc genpd to switch gdsc mode for venus v4 core Renjiang Han
2024-11-22 10:31 ` [PATCH 1/2] clk: qcom: videocc: Use HW_CTRL_TRIGGER flag for video GDSC's Renjiang Han
2024-11-22 10:59 ` Dmitry Baryshkov
2024-11-22 16:55 ` Taniya Das
2024-11-23 0:05 ` Dmitry Baryshkov
2024-11-23 0:16 ` Bryan O'Donoghue
2024-11-25 5:31 ` Renjiang Han (QUIC)
2024-11-25 13:55 ` Dmitry Baryshkov
2024-11-25 15:14 ` Renjiang Han (QUIC)
2024-11-25 16:27 ` Dmitry Baryshkov
2024-12-18 11:26 ` Renjiang Han
2024-11-26 4:04 ` Taniya Das
2024-11-26 7:37 ` Dmitry Baryshkov
2024-11-22 10:31 ` [PATCH 2/2] venus: pm_helpers: Use dev_pm_genpd_set_hwmode to switch GDSC mode on V4 Renjiang Han
2024-11-22 12:50 ` Bryan O'Donoghue [this message]
2024-11-25 3:34 ` Renjiang Han (QUIC)
2024-11-23 0:18 ` [PATCH 0/2] Use APIs in gdsc genpd to switch gdsc mode for venus v4 core Bryan O'Donoghue
2024-11-25 3:49 ` Renjiang Han (QUIC)
2024-11-25 9:35 ` Bryan O'Donoghue
2024-11-25 10:13 ` Renjiang Han (QUIC)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2299ec8f-4b80-48ea-96ed-d1eb40998e55@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=andersson@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_renjiang@quicinc.com \
--cc=quic_vgarodia@quicinc.com \
--cc=sboyd@kernel.org \
--cc=stanimir.k.varbanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox