public inbox for linux-clk@vger.kernel.org
 help / color / mirror / Atom feed
From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Taniya Das <quic_tdas@quicinc.com>
Cc: Renjiang Han <quic_renjiang@quicinc.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Stanimir Varbanov <stanimir.k.varbanov@gmail.com>,
	Vikash Garodia <quic_vgarodia@quicinc.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH 1/2] clk: qcom: videocc: Use HW_CTRL_TRIGGER flag for video GDSC's
Date: Sat, 23 Nov 2024 00:16:42 +0000	[thread overview]
Message-ID: <eec92088-edfb-4d0c-b81d-9d4f1d968b20@linaro.org> (raw)
In-Reply-To: <23ho25gl3iwyi2jspb6a2x5bv76fco5pkg2x5ct4gu3c44dbiq@yec6evx5sihm>

On 23/11/2024 00:05, Dmitry Baryshkov wrote:
> This leaves sm7150, sm8150 and sm8450 untouched. Don't they also need to
> use HW_CTRL_TRIGGER?

I believe the correct list here is anything that is HFI_VERSION_4XX in

You can't apply the second patch in this series without ensuring the 
clock controllers for sdm845 and sm7180

grep HFI_VERSION_4XX drivers/media/platform/qcom/venus/core.c

drivers/clk/qcom/videocc-sdm845.c
drivers/clk/qcom/videocc-sc7180.c

Hmm.. that's what this patch does, to be fair my other email was flippant.

This is fine in general, once we can get some Tested-by: for it.

That's my question - what platforms has this change been tested on ?

I can do sdm845 but, we'll need to find someone with 7180 to verify IMO.

---
bod

  reply	other threads:[~2024-11-23  0:16 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-22 10:31 [PATCH 0/2] Use APIs in gdsc genpd to switch gdsc mode for venus v4 core Renjiang Han
2024-11-22 10:31 ` [PATCH 1/2] clk: qcom: videocc: Use HW_CTRL_TRIGGER flag for video GDSC's Renjiang Han
2024-11-22 10:59   ` Dmitry Baryshkov
2024-11-22 16:55     ` Taniya Das
2024-11-23  0:05       ` Dmitry Baryshkov
2024-11-23  0:16         ` Bryan O'Donoghue [this message]
2024-11-25  5:31           ` Renjiang Han (QUIC)
2024-11-25 13:55             ` Dmitry Baryshkov
2024-11-25 15:14               ` Renjiang Han (QUIC)
2024-11-25 16:27                 ` Dmitry Baryshkov
2024-12-18 11:26                   ` Renjiang Han
2024-11-26  4:04         ` Taniya Das
2024-11-26  7:37           ` Dmitry Baryshkov
2024-11-22 10:31 ` [PATCH 2/2] venus: pm_helpers: Use dev_pm_genpd_set_hwmode to switch GDSC mode on V4 Renjiang Han
2024-11-22 12:50   ` Bryan O'Donoghue
2024-11-25  3:34     ` Renjiang Han (QUIC)
2024-11-23  0:18 ` [PATCH 0/2] Use APIs in gdsc genpd to switch gdsc mode for venus v4 core Bryan O'Donoghue
2024-11-25  3:49   ` Renjiang Han (QUIC)
2024-11-25  9:35     ` Bryan O'Donoghue
2024-11-25 10:13       ` Renjiang Han (QUIC)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eec92088-edfb-4d0c-b81d-9d4f1d968b20@linaro.org \
    --to=bryan.odonoghue@linaro.org \
    --cc=andersson@kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=quic_renjiang@quicinc.com \
    --cc=quic_tdas@quicinc.com \
    --cc=quic_vgarodia@quicinc.com \
    --cc=sboyd@kernel.org \
    --cc=stanimir.k.varbanov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox