[PATCH 1/1] clk: imgtec: use %pe for better readability of errors while printing

[PATCH 1/1] clk: imgtec: use %pe for better readability of errors while printing

[Onkarnarth]

From: Onkarnath <onkarnath.1@samsung.com>

instead of printing errros as a number(%ld), it's better to print in string
format for better readability of logs

Signed-off-by: Maninder singh <maninder1.s@samsung.com>
Signed-off-by: Onkarnath <onkarnath.1@samsung.com>
---
 drivers/clk/imgtec/clk-boston.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/clk/imgtec/clk-boston.c b/drivers/clk/imgtec/clk-boston.c
index b00cbd045af5..db96f8bea630 100644
--- a/drivers/clk/imgtec/clk-boston.c
+++ b/drivers/clk/imgtec/clk-boston.c
@@ -67,21 +67,21 @@ static void __init clk_boston_setup(struct device_node *np)
 
 	hw = clk_hw_register_fixed_rate(NULL, "input", NULL, 0, in_freq);
 	if (IS_ERR(hw)) {
-		pr_err("failed to register input clock: %ld\n", PTR_ERR(hw));
+		pr_err("failed to register input clock: %pe\n", hw);
 		goto fail_input;
 	}
 	onecell->hws[BOSTON_CLK_INPUT] = hw;
 
 	hw = clk_hw_register_fixed_rate(NULL, "sys", "input", 0, sys_freq);
 	if (IS_ERR(hw)) {
-		pr_err("failed to register sys clock: %ld\n", PTR_ERR(hw));
+		pr_err("failed to register sys clock: %pe\n", hw);
 		goto fail_sys;
 	}
 	onecell->hws[BOSTON_CLK_SYS] = hw;
 
 	hw = clk_hw_register_fixed_rate(NULL, "cpu", "input", 0, cpu_freq);
 	if (IS_ERR(hw)) {
-		pr_err("failed to register cpu clock: %ld\n", PTR_ERR(hw));
+		pr_err("failed to register cpu clock: %pe\n", hw);
 		goto fail_cpu;
 	}
 	onecell->hws[BOSTON_CLK_CPU] = hw;
-- 
2.25.1

Re: [PATCH 1/1] clk: imgtec: use %pe for better readability of errors while printing

[Stephen Boyd]

Quoting Onkarnarth (2024-02-05 03:11:55)
> From: Onkarnath <onkarnath.1@samsung.com>
> 
> instead of printing errros as a number(%ld), it's better to print in string
> format for better readability of logs
> 
> Signed-off-by: Maninder singh <maninder1.s@samsung.com>

This SoB chain is wrong. Either the above email is that author, and thus
the From should match, or it's a Co-Developed-by tag. I don't know which
one it is, but for a 6 line patch I hope it's not co developed...


> Signed-off-by: Onkarnath <onkarnath.1@samsung.com>

Re: [PATCH 1/1] clk: imgtec: use %pe for better readability of errors while printing

[Stephen Boyd]

Quoting Onkarnath (2024-04-11 23:10:40)
> 
> for the next set of patches we will be keeping one SOB.
> 
> 
> If required i can mail version 2 for the same.

Yes, resend the patch.