From: Krzysztof Kozlowski <krzk@kernel.org>
To: Anand Moon <linux.amoon@gmail.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
"open list:MAXIM PMIC AND MUIC DRIVERS FOR EXYNOS BASED BO..."
<linux-kernel@vger.kernel.org>,
"open list:COMMON CLK FRAMEWORK" <linux-clk@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"moderated list:ARM/SAMSUNG S3C,
S5P AND EXYNOS ARM ARCHITECTURES"
<linux-arm-kernel@lists.infradead.org>,
"open list:ARM/SAMSUNG S3C,
S5P AND EXYNOS ARM ARCHITECTURES"
<linux-samsung-soc@vger.kernel.org>
Subject: Re: [PATCH v1 01/10] dt-bindings: clock: Add RTC clock binding for Maxim MAX77686
Date: Fri, 25 Apr 2025 16:44:42 +0200 [thread overview]
Message-ID: <34087c68-442f-41ec-a6c0-dd063f6d44d1@kernel.org> (raw)
In-Reply-To: <20250425132727.5160-2-linux.amoon@gmail.com>
On 25/04/2025 15:26, Anand Moon wrote:
> +
> + The MAX77686 contains three 32.768khz crystal clock outputs that can
> + be controlled (gated/ungated) over I2C. Clocks are defined as
> + preprocessor macros in dt-bindings/clock/maxim,max77686.h.
> +
> +properties:
> + compatible:
> + enum:
> + - max77686-rtc
So you claim RTC is a clock, right? Did not even think that RTC has a
bit different meaning?
But regardless, this code make no sense and was never tested. It cannot
work.
It reminds me previous approaches with whatever patches you found in the
downstream...
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-04-25 14:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-25 13:26 [PATCH v1 00/10] Add rtc and suspend to ram for Maxim MAX77686 PMIC Anand Moon
2025-04-25 13:26 ` [PATCH v1 01/10] dt-bindings: clock: Add RTC clock binding for Maxim MAX77686 Anand Moon
2025-04-25 14:44 ` Krzysztof Kozlowski [this message]
2025-04-26 6:11 ` Anand Moon
2025-04-25 13:26 ` [PATCH v1 02/10] ARM: dts: exynos: Add rtc clock definitions for MAX77686 PMIC for Exynos4412 Odroid Anand Moon
2025-04-25 14:46 ` Krzysztof Kozlowski
2025-04-25 13:26 ` [PATCH v1 03/10] ARM: dts: exynos: Add proper regulator states for suspend-to-mem " Anand Moon
2025-04-25 13:26 ` [PATCH v1 04/10] ARM: dts: exynos: Add rtc clock definitions for MAX77686 PMIC for Exynos4412 Midas Anand Moon
2025-04-25 13:26 ` [PATCH v1 05/10] ARM: dts: exynos: Add rtc clock definitions for MAX77686 PMIC for Exynos4412 p4note Anand Moon
2025-04-25 13:26 ` [PATCH v1 06/10] ARM: dts: exynos: Update proper regulator states for suspend-to-mem for Exynos4412 p4node Anand Moon
2025-04-25 13:26 ` [PATCH v1 07/10] ARM: dts: exynos: Add rtc clock definitions for MAX77686 PMIC for Exynos5250 smdk5250 Anand Moon
2025-04-25 13:26 ` [PATCH v1 08/10] ARM: dts: exynos: Add proper regulator states for suspend-to-mem for Exyno5250 smdk5250 Anand Moon
2025-04-25 14:48 ` Krzysztof Kozlowski
2025-04-26 6:12 ` Anand Moon
2025-04-25 13:26 ` [PATCH v1 09/10] ARM: dts: exynos: Add rtc clock definitions for MAX77686 PMIC for Exynos5250 snow Anand Moon
2025-04-25 13:26 ` [PATCH v1 10/10] ARM: dts: exynos: Add proper regulator states for suspend-to-mem " Anand Moon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34087c68-442f-41ec-a6c0-dd063f6d44d1@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=conor+dt@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux.amoon@gmail.com \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox