From: Stephen Boyd <sboyd@kernel.org>
To: Jay Buddhabhatti <jay.buddhabhatti@amd.com>,
michal.simek@amd.com, mturquette@baylibre.com,
shubhrajyoti.datta@xilinx.com
Cc: linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Jay Buddhabhatti <jay.buddhabhatti@amd.com>
Subject: Re: [PATCH RESEND v2 1/2] drivers: clk: zynqmp: calculate closest mux rate
Date: Sat, 16 Dec 2023 17:21:19 -0800 [thread overview]
Message-ID: <3ddba76f5f44a7b32c5852094667d189.sboyd@kernel.org> (raw)
In-Reply-To: <20231129112916.23125-2-jay.buddhabhatti@amd.com>
Quoting Jay Buddhabhatti (2023-11-29 03:29:15)
> Currently zynqmp clock driver is not calculating closest mux rate and
> because of that Linux is not setting proper frequency for CPU and
> not able to set given frequency for dynamic frequency scaling.
>
> E.g., In current logic initial acpu clock parent and frequency as below
> apll1 0 0 0 2199999978 0 0 50000 Y
> acpu0_mux 0 0 0 2199999978 0 0 50000 Y
> acpu0_idiv1 0 0 0 2199999978 0 0 50000 Y
> acpu0 0 0 0 2199999978 0 0 50000 Y
>
> After changing acpu frequency to 549999994 Hz using CPU freq scaling its
> selecting incorrect parent which is not closest frequency.
> rpll_to_xpd 0 0 0 1599999984 0 0 50000 Y
> acpu0_mux 0 0 0 1599999984 0 0 50000 Y
> acpu0_div1 0 0 0 533333328 0 0 50000 Y
> acpu0 0 0 0 533333328 0 0 50000 Y
>
> Parent should remain same since 549999994 = 2199999978 / 4.
>
> So use __clk_mux_determine_rate_closest() generic function to calculate
> closest rate for mux clock. After this change its selecting correct
> parent and correct clock rate.
> apll1 0 0 0 2199999978 0 0 50000 Y
> acpu0_mux 0 0 0 2199999978 0 0 50000 Y
> acpu0_div1 0 0 0 549999995 0 0 50000 Y
> acpu0 0 0 0 549999995 0 0 50000 Y
>
> Fixes: 3fde0e16d016 ("drivers: clk: Add ZynqMP clock driver")
> Signed-off-by: Jay Buddhabhatti <jay.buddhabhatti@amd.com>
> ---
Applied to clk-next
next prev parent reply other threads:[~2023-12-17 1:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-29 11:29 [PATCH RESEND v2 0/2] update for versal net platform Jay Buddhabhatti
2023-11-29 11:29 ` [PATCH RESEND v2 1/2] drivers: clk: zynqmp: calculate closest mux rate Jay Buddhabhatti
2023-12-17 1:21 ` Stephen Boyd [this message]
2023-11-29 11:29 ` [PATCH RESEND v2 2/2] drivers: clk: zynqmp: update divider round rate logic Jay Buddhabhatti
2023-12-17 1:21 ` Stephen Boyd
-- strict thread matches above, loose matches on Subject: below --
2023-11-09 12:05 [PATCH RESEND v2 0/2] update for versal net platform Jay Buddhabhatti
2023-11-09 12:05 ` [PATCH RESEND v2 1/2] drivers: clk: zynqmp: calculate closest mux rate Jay Buddhabhatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ddba76f5f44a7b32c5852094667d189.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=jay.buddhabhatti@amd.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=mturquette@baylibre.com \
--cc=shubhrajyoti.datta@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox