* [PATCH] clk: at91: clk-sam9x60-pll: fix return value check
@ 2023-02-27 10:59 Claudiu Beznea
2023-03-06 20:30 ` Stephen Boyd
0 siblings, 1 reply; 2+ messages in thread
From: Claudiu Beznea @ 2023-02-27 10:59 UTC (permalink / raw)
To: mturquette, sboyd, nicolas.ferre, alexandre.belloni
Cc: linux-clk, linux-arm-kernel, linux-kernel, Claudiu Beznea,
Dan Carpenter
sam9x60_frac_pll_compute_mul_frac() can't return zero. Remove the check
against zero to reflect this.
Fixes: 43b1bb4a9b3e ("clk: at91: clk-sam9x60-pll: re-factor to support plls with multiple outputs")
Reported-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
---
drivers/clk/at91/clk-sam9x60-pll.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/at91/clk-sam9x60-pll.c b/drivers/clk/at91/clk-sam9x60-pll.c
index d757003004cb..0882ed01d5c2 100644
--- a/drivers/clk/at91/clk-sam9x60-pll.c
+++ b/drivers/clk/at91/clk-sam9x60-pll.c
@@ -668,7 +668,7 @@ sam9x60_clk_register_frac_pll(struct regmap *regmap, spinlock_t *lock,
ret = sam9x60_frac_pll_compute_mul_frac(&frac->core, FCORE_MIN,
parent_rate, true);
- if (ret <= 0) {
+ if (ret < 0) {
hw = ERR_PTR(ret);
goto free;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] clk: at91: clk-sam9x60-pll: fix return value check
2023-02-27 10:59 [PATCH] clk: at91: clk-sam9x60-pll: fix return value check Claudiu Beznea
@ 2023-03-06 20:30 ` Stephen Boyd
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Boyd @ 2023-03-06 20:30 UTC (permalink / raw)
To: Claudiu Beznea, alexandre.belloni, mturquette, nicolas.ferre
Cc: linux-clk, linux-arm-kernel, linux-kernel, Claudiu Beznea,
Dan Carpenter
Quoting Claudiu Beznea (2023-02-27 02:59:31)
> sam9x60_frac_pll_compute_mul_frac() can't return zero. Remove the check
> against zero to reflect this.
>
> Fixes: 43b1bb4a9b3e ("clk: at91: clk-sam9x60-pll: re-factor to support plls with multiple outputs")
> Reported-by: Dan Carpenter <error27@gmail.com>
> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-06 20:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-27 10:59 [PATCH] clk: at91: clk-sam9x60-pll: fix return value check Claudiu Beznea
2023-03-06 20:30 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox