From: Krzysztof Kozlowski <krzk@kernel.org>
To: Rohit Visavalia <rohit.visavalia@amd.com>,
mturquette@baylibre.com, sboyd@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org
Cc: linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: clock: xilinx: Convert VCU bindings to dtschema
Date: Thu, 2 Jan 2025 19:26:02 +0100 [thread overview]
Message-ID: <49d2fd63-cd27-4a49-b581-62722e012451@kernel.org> (raw)
In-Reply-To: <20250102163700.759712-3-rohit.visavalia@amd.com>
On 02/01/2025 17:36, Rohit Visavalia wrote:
> Convert AMD (Xilinx) VCU bindings to yaml format.
>
...
> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + - xlnx,vcu
> + - xlnx,vcu-logicoreip-1.0
> +
> + reg:
> + description:
> + The base offset and size of the VCU_PL_SLCR register space.
Drop description, redundant.
> + minItems: 1
There is no code like this. maxItems instead. Please use example-schema
or other recently reviewed bindings as starting point.
> +
> + clocks:
> + description: List of clock specifiers
Drop description.
> + items:
> + - description: pll ref clocksource
> + - description: aclk
Original binding said different order. Mention change in commit msg with
explanation why.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-01-02 18:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-02 16:36 [PATCH 0/3] dt-bindings: clock: xilinx: Update VCU bindings Rohit Visavalia
2025-01-02 16:36 ` [PATCH 1/3] dt-bindings: clock: xilinx: move xlnx_vcu dt-binding to clock from soc Rohit Visavalia
2025-01-02 18:30 ` Krzysztof Kozlowski
2025-01-03 11:35 ` Visavalia, Rohit
2025-01-02 16:36 ` [PATCH 2/3] dt-bindings: clock: xilinx: Convert VCU bindings to dtschema Rohit Visavalia
2025-01-02 18:26 ` Krzysztof Kozlowski [this message]
2025-01-03 11:35 ` Visavalia, Rohit
2025-01-02 16:37 ` [PATCH 3/3] dt-bindings: clock: xilinx: Update VCU bindings for reset GPIO Rohit Visavalia
2025-01-02 18:29 ` Krzysztof Kozlowski
2025-01-03 11:35 ` Visavalia, Rohit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49d2fd63-cd27-4a49-b581-62722e012451@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=rohit.visavalia@amd.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox