From: "Ryan Walklin" <ryan@testtoast.com>
To: "Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>
Cc: "Maxime Ripard" <mripard@kernel.org>,
"Chen-Yu Tsai" <wens@csie.org>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Samuel Holland" <samuel@sholland.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Michael Turquette" <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"Andre Przywara" <andre.przywara@arm.com>,
"Chris Morgan" <macroalpha82@gmail.com>,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org,
linux-clk@vger.kernel.org
Subject: Re: [PATCH v5 08/26] drm: sun4i: de3: add YUV support to the DE3 mixer
Date: Sat, 15 Feb 2025 14:18:59 +1300 [thread overview]
Message-ID: <4c31826f-0ffa-4ada-bcf9-199fcbe6db07@app.fastmail.com> (raw)
In-Reply-To: <4cumvwkhmbi7fecjeq6r7elon63u3ytootqcvavjg5vfnargy3@wrjpy6pnphmb>
On Sun, 20 Oct 2024, at 3:14 AM, Dmitry Baryshkov wrote:
> On Sun, Sep 29, 2024 at 10:04:40PM +1300, Ryan Walklin wrote:
>> diff --git a/drivers/gpu/drm/sun4i/sunxi_engine.h b/drivers/gpu/drm/sun4i/sunxi_engine.h
>> index c48cbc1aceb80..ffafc29b3a0c3 100644
>> --- a/drivers/gpu/drm/sun4i/sunxi_engine.h
>> +++ b/drivers/gpu/drm/sun4i/sunxi_engine.h
>> @@ -151,6 +153,9 @@ struct sunxi_engine {
>>
>> int id;
>>
>> + u32 format;
>> + enum drm_color_encoding encoding;
>
> Should these be a part of the state instead of being a part of the
> sunxi_engine?
Sure, would you suggest in sun8i_mixer_cfg?
Regards,
Ryan
next prev parent reply other threads:[~2025-02-15 1:19 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-29 9:04 [PATCH v5 00/26] drm: sun4i: add Display Engine 3.3 (DE33) support Ryan Walklin
2024-09-29 9:04 ` [PATCH v5 01/26] drm: sun4i: de2/de3: Change CSC argument Ryan Walklin
2024-10-19 14:11 ` Dmitry Baryshkov
2025-02-15 1:17 ` Ryan Walklin
2024-09-29 9:04 ` [PATCH v5 02/26] drm: sun4i: de2/de3: Merge CSC functions into one Ryan Walklin
2024-09-29 9:04 ` [PATCH v5 03/26] drm: sun4i: de2/de3: call csc setup also for UI layer Ryan Walklin
2024-09-29 9:04 ` [PATCH v5 04/26] drm: sun4i: de2: Initialize layer fields earlier Ryan Walklin
2024-09-29 9:04 ` [PATCH v5 05/26] drm: sun4i: de3: Add YUV formatter module Ryan Walklin
2024-09-29 9:04 ` [PATCH v5 06/26] drm: sun4i: de3: add format enumeration function to engine Ryan Walklin
2024-09-29 9:04 ` [PATCH v5 07/26] drm: sun4i: de3: add formatter flag to mixer config Ryan Walklin
2024-09-29 9:04 ` [PATCH v5 08/26] drm: sun4i: de3: add YUV support to the DE3 mixer Ryan Walklin
2024-10-19 14:14 ` Dmitry Baryshkov
2025-02-15 1:18 ` Ryan Walklin [this message]
2025-02-15 3:48 ` Ryan Walklin
2024-09-29 9:04 ` [PATCH v5 09/26] drm: sun4i: de3: pass engine reference to ccsc setup function Ryan Walklin
2024-09-29 9:04 ` [PATCH v5 10/26] drm: sun4i: de3: add YUV support to the color space correction module Ryan Walklin
2024-09-29 9:04 ` [PATCH v5 11/26] drm: sun4i: de3: add YUV support to the TCON Ryan Walklin
2024-09-29 9:04 ` [PATCH v5 12/26] drm: sun4i: support YUV formats in VI scaler Ryan Walklin
2024-09-29 9:04 ` [PATCH v5 13/26] drm: sun4i: de2/de3: add mixer version enum Ryan Walklin
2024-09-29 9:04 ` [PATCH v5 14/26] drm: sun4i: de2/de3: refactor mixer initialisation Ryan Walklin
2024-09-29 9:04 ` [PATCH v5 15/26] drm: sun4i: vi_scaler refactor vi_scaler enablement Ryan Walklin
2024-09-29 9:04 ` [PATCH v5 16/26] drm: sun4i: de2/de3: add generic blender register reference function Ryan Walklin
2024-09-29 9:04 ` [PATCH v5 17/26] drm: sun4i: de2/de3: use generic register reference function for layer configuration Ryan Walklin
2024-09-29 9:04 ` [PATCH v5 18/26] drm: sun4i: de3: Implement AFBC support Ryan Walklin
2024-09-29 9:04 ` [PATCH v5 19/26] dt-bindings: allwinner: add H616 DE33 bus binding Ryan Walklin
2025-02-12 17:27 ` Chris Morgan
2024-09-29 9:04 ` [PATCH v5 20/26] dt-bindings: allwinner: add H616 DE33 clock binding Ryan Walklin
2024-09-29 9:04 ` [PATCH v5 21/26] dt-bindings: allwinner: add H616 DE33 mixer binding Ryan Walklin
2025-02-12 17:31 ` Chris Morgan
2024-09-29 9:04 ` [PATCH v5 22/26] clk: sunxi-ng: ccu: add Display Engine 3.3 (DE33) support Ryan Walklin
2024-09-29 9:04 ` [PATCH v5 23/26] drm: sun4i: de33: mixer: " Ryan Walklin
2024-09-29 9:04 ` [PATCH v5 24/26] drm: sun4i: de33: vi_scaler: " Ryan Walklin
2024-09-29 9:04 ` [PATCH v5 25/26] drm: sun4i: de33: fmt: " Ryan Walklin
2024-09-29 9:04 ` [PATCH v5 26/26] drm: sun4i: de33: csc: " Ryan Walklin
2024-09-30 13:30 ` [PATCH v5 00/26] drm: sun4i: " Philippe Simons
2025-02-12 17:25 ` Chris Morgan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c31826f-0ffa-4ada-bcf9-199fcbe6db07@app.fastmail.com \
--to=ryan@testtoast.com \
--cc=airlied@gmail.com \
--cc=andre.przywara@arm.com \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=maarten.lankhorst@linux.intel.com \
--cc=macroalpha82@gmail.com \
--cc=mripard@kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=samuel@sholland.org \
--cc=sboyd@kernel.org \
--cc=tzimmermann@suse.de \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox