* [PATCH] PM / devfreq: event: Remove incorrect property in exynos-ppmu DT binding
@ 2015-07-13 6:58 Javier Martinez Canillas
2015-07-23 8:19 ` Chanwoo Choi
0 siblings, 1 reply; 5+ messages in thread
From: Javier Martinez Canillas @ 2015-07-13 6:58 UTC (permalink / raw)
To: Kukjin Kim
Cc: linux-samsung-soc, Chanwoo Choi, linux-kernel,
Krzysztof Kozlowski, linux-clk, linux-arm-kernel,
Javier Martinez Canillas
The exynos-ppmu driver is only a clock consumer and not a clock provider
but its Device Tree binding listed #clock-cells as an optional property.
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt | 1 -
1 file changed, 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt b/Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt
index b54bf3a2ff57..aed486692880 100644
--- a/Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt
+++ b/Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt
@@ -17,7 +17,6 @@ Required properties:
Optional properties:
- clock-names : the name of clock used by the PPMU, "ppmu"
- clocks : phandles for clock specified in "clock-names" property
-- #clock-cells: should be 1.
Example1 : PPMU nodes in exynos3250.dtsi are listed below.
--
2.4.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] PM / devfreq: event: Remove incorrect property in exynos-ppmu DT binding
2015-07-13 6:58 [PATCH] PM / devfreq: event: Remove incorrect property in exynos-ppmu DT binding Javier Martinez Canillas
@ 2015-07-23 8:19 ` Chanwoo Choi
2015-07-23 8:30 ` Javier Martinez Canillas
0 siblings, 1 reply; 5+ messages in thread
From: Chanwoo Choi @ 2015-07-23 8:19 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: Kukjin Kim, linux-samsung-soc, linux-kernel, Krzysztof Kozlowski,
linux-clk, linux-arm-kernel, myungjoo.ham@samsung.com
Hi Javier,
On 07/13/2015 03:58 PM, Javier Martinez Canillas wrote:
> The exynos-ppmu driver is only a clock consumer and not a clock provider
> but its Device Tree binding listed #clock-cells as an optional property.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
>
> Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt b/Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt
> index b54bf3a2ff57..aed486692880 100644
> --- a/Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt
> +++ b/Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt
> @@ -17,7 +17,6 @@ Required properties:
> Optional properties:
> - clock-names : the name of clock used by the PPMU, "ppmu"
> - clocks : phandles for clock specified in "clock-names" property
> -- #clock-cells: should be 1.
>
> Example1 : PPMU nodes in exynos3250.dtsi are listed below.
>
>
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
+ Devfreq maintainer (Myungjoo Ham)
I think that this patch will be more appropriate on devfreq git tree
than linux-samsung git tree.
Thanks,
Chanwoo Choi
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] PM / devfreq: event: Remove incorrect property in exynos-ppmu DT binding
2015-07-23 8:19 ` Chanwoo Choi
@ 2015-07-23 8:30 ` Javier Martinez Canillas
2015-07-31 9:37 ` Javier Martinez Canillas
0 siblings, 1 reply; 5+ messages in thread
From: Javier Martinez Canillas @ 2015-07-23 8:30 UTC (permalink / raw)
To: Chanwoo Choi
Cc: Kukjin Kim, linux-samsung-soc, linux-kernel, Krzysztof Kozlowski,
linux-clk, linux-arm-kernel, myungjoo.ham@samsung.com
Hello Chanwoo,
On 07/23/2015 10:19 AM, Chanwoo Choi wrote:
> Hi Javier,
>
> On 07/13/2015 03:58 PM, Javier Martinez Canillas wrote:
>> The exynos-ppmu driver is only a clock consumer and not a clock
>> provider but its Device Tree binding listed #clock-cells as an
>> optional property.
>>
>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>>
>> ---
>>
>> Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt | 1
>> - 1 file changed, 1 deletion(-)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt
>> b/Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt
>> index b54bf3a2ff57..aed486692880 100644 ---
>> a/Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt
>> +++
>> b/Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt
>> @@ -17,7 +17,6 @@ Required properties: Optional properties: -
>> clock-names : the name of clock used by the PPMU, "ppmu" - clocks :
>> phandles for clock specified in "clock-names" property --
>> #clock-cells: should be 1.
>>
>> Example1 : PPMU nodes in exynos3250.dtsi are listed below.
>>
>>
>
> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
>
> + Devfreq maintainer (Myungjoo Ham)
Thanks for the review and for cc'ing Myungjoo. The get_maintainer.pl script
didn't tell me that so I think Documentation/devicetree/bindings/devfreq/
sub-dir should be added to the DEVICE FREQUENCY (DEVFREQ) entry in the
MAINTAINERS file.
> I think that this patch will be more appropriate on devfreq git tree
> than linux-samsung git tree.
>
Agreed.
> Thanks, Chanwoo Choi --
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] PM / devfreq: event: Remove incorrect property in exynos-ppmu DT binding
2015-07-23 8:30 ` Javier Martinez Canillas
@ 2015-07-31 9:37 ` Javier Martinez Canillas
0 siblings, 0 replies; 5+ messages in thread
From: Javier Martinez Canillas @ 2015-07-31 9:37 UTC (permalink / raw)
To: myungjoo.ham@samsung.com
Cc: Chanwoo Choi, Kukjin Kim, linux-samsung-soc, linux-kernel,
Krzysztof Kozlowski, linux-clk, linux-arm-kernel
Hello Myungjoo,
On 07/23/2015 10:30 AM, Javier Martinez Canillas wrote:
> Hello Chanwoo,
>
> On 07/23/2015 10:19 AM, Chanwoo Choi wrote:
>> Hi Javier,
>>
>> On 07/13/2015 03:58 PM, Javier Martinez Canillas wrote:
>>> The exynos-ppmu driver is only a clock consumer and not a clock
>>> provider but its Device Tree binding listed #clock-cells as an
>>> optional property.
>>>
>>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>>>
>>> ---
>>>
>>> Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt | 1
>>> - 1 file changed, 1 deletion(-)
>>>
>>> diff --git
>>> a/Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt
>>> b/Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt
>>> index b54bf3a2ff57..aed486692880 100644 ---
>>> a/Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt
>>> +++
>>> b/Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt
>>> @@ -17,7 +17,6 @@ Required properties: Optional properties: -
>>> clock-names : the name of clock used by the PPMU, "ppmu" - clocks :
>>> phandles for clock specified in "clock-names" property --
>>> #clock-cells: should be 1.
>>>
>>> Example1 : PPMU nodes in exynos3250.dtsi are listed below.
>>>
>>>
>>
>> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
>>
>> + Devfreq maintainer (Myungjoo Ham)
>
> Thanks for the review and for cc'ing Myungjoo. The get_maintainer.pl script
> didn't tell me that so I think Documentation/devicetree/bindings/devfreq/
> sub-dir should be added to the DEVICE FREQUENCY (DEVFREQ) entry in the
> MAINTAINERS file.
>
>> I think that this patch will be more appropriate on devfreq git tree
>> than linux-samsung git tree.
>>
>
> Agreed.
>
Any comments about this patch?
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Re: [PATCH] PM / devfreq: event: Remove incorrect property in exynos-ppmu DT binding
@ 2015-08-03 4:58 MyungJoo Ham
2015-08-03 7:38 ` Javier Martinez Canillas
0 siblings, 1 reply; 5+ messages in thread
From: MyungJoo Ham @ 2015-08-03 4:58 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: 최찬우, Kukjin Kim,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
크쉬시토프,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org
PiBIZWxsbyBNeXVuZ2pvbywNCj4gDQo+IE9uIDA3LzIzLzIwMTUgMTA6MzAgQU0sIEphdmllciBN
YXJ0aW5leiBDYW5pbGxhcyB3cm90ZToNCj4gPiBIZWxsbyBDaGFud29vLA0KPiA+DQo+ID4gT24g
MDcvMjMvMjAxNSAxMDoxOSBBTSwgQ2hhbndvbyBDaG9pIHdyb3RlOg0KPiA+PiBIaSBKYXZpZXIs
DQo+ID4+DQo+ID4+IE9uIDA3LzEzLzIwMTUgMDM6NTggUE0sIEphdmllciBNYXJ0aW5leiBDYW5p
bGxhcyB3cm90ZToNCj4gPj4+IFRoZSBleHlub3MtcHBtdSBkcml2ZXIgaXMgb25seSBhIGNsb2Nr
IGNvbnN1bWVyIGFuZCBub3QgYSBjbG9jaw0KPiA+Pj4gcHJvdmlkZXIgYnV0IGl0cyBEZXZpY2Ug
VHJlZSBiaW5kaW5nIGxpc3RlZCAjY2xvY2stY2VsbHMgYXMgYW4NCj4gPj4+IG9wdGlvbmFsIHBy
b3BlcnR5Lg0KPiA+Pj4NCj4gPj4+IFNpZ25lZC1vZmYtYnk6IEphdmllciBNYXJ0aW5leiBDYW5p
bGxhcyA8amF2aWVyQG9zZy5zYW1zdW5nLmNvbT4NCj4gPj4+DQpbXQ0KPiA+Pj4NCj4gPj4+IEV4
YW1wbGUxIDogUFBNVSBub2RlcyBpbiBleHlub3MzMjUwLmR0c2kgYXJlIGxpc3RlZCBiZWxvdy4N
Cj4gPj4+DQo+ID4+Pg0KPiA+Pg0KPiA+PiBSZXZpZXdlZC1ieTogQ2hhbndvbyBDaG9pIDxjdzAw
LmNob2lAc2Ftc3VuZy5jb20+DQo+ID4+DQo+ID4+ICsgRGV2ZnJlcSBtYWludGFpbmVyIChNeXVu
Z2pvbyBIYW0pDQo+ID4NCj4gPiBUaGFua3MgZm9yIHRoZSByZXZpZXcgYW5kIGZvciBjYydpbmcg
TXl1bmdqb28uIFRoZSBnZXRfbWFpbnRhaW5lci5wbCBzY3JpcHQNCj4gPiBkaWRuJ3QgdGVsbCBt
ZSB0aGF0IHNvIEkgdGhpbmsgRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2RldmZy
ZXEvDQo+ID4gc3ViLWRpciBzaG91bGQgYmUgYWRkZWQgdG8gdGhlIERFVklDRSBGUkVRVUVOQ1kg
KERFVkZSRVEpIGVudHJ5IGluIHRoZQ0KPiA+IE1BSU5UQUlORVJTIGZpbGUuDQo+ID4NCj4gPj4g
SSB0aGluayB0aGF0IHRoaXMgcGF0Y2ggd2lsbCBiZSBtb3JlIGFwcHJvcHJpYXRlIG9uIGRldmZy
ZXEgZ2l0IHRyZWUNCj4gPj4gdGhhbiBsaW51eC1zYW1zdW5nIGdpdCB0cmVlLg0KPiA+Pg0KPiA+
DQo+ID4gQWdyZWVkLg0KPiA+DQo+IA0KPiBBbnkgY29tbWVudHMgYWJvdXQgdGhpcyBwYXRjaD8N
Cg0KTm9wZS4gSXQncyBhcHBsaWVkLg0KDQoNClRoYW5rcy4NCg0KDQoNCk15dW5nSm9vDQoNCj4g
DQo+IA0KPiANCj4gQmVzdCByZWdhcmRzLA0KPiAtLQ0K
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] PM / devfreq: event: Remove incorrect property in exynos-ppmu DT binding
2015-08-03 4:58 MyungJoo Ham
@ 2015-08-03 7:38 ` Javier Martinez Canillas
0 siblings, 0 replies; 5+ messages in thread
From: Javier Martinez Canillas @ 2015-08-03 7:38 UTC (permalink / raw)
To: myungjoo.ham
Cc: 최찬우, Kukjin Kim,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
크쉬시토프,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Hello MyungJoo,
On 08/03/2015 06:58 AM, MyungJoo Ham wrote:
>> Hello Myungjoo,
>>
>> On 07/23/2015 10:30 AM, Javier Martinez Canillas wrote:
>>> Hello Chanwoo,
>>>
>>> On 07/23/2015 10:19 AM, Chanwoo Choi wrote:
>>>> Hi Javier,
>>>>
>>>> On 07/13/2015 03:58 PM, Javier Martinez Canillas wrote:
>>>>> The exynos-ppmu driver is only a clock consumer and not a clock
>>>>> provider but its Device Tree binding listed #clock-cells as an
>>>>> optional property.
>>>>>
>>>>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>>>>>
> []
>>>>>
>>>>> Example1 : PPMU nodes in exynos3250.dtsi are listed below.
>>>>>
>>>>>
>>>>
>>>> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
>>>>
>>>> + Devfreq maintainer (Myungjoo Ham)
>>>
>>> Thanks for the review and for cc'ing Myungjoo. The get_maintainer.pl script
>>> didn't tell me that so I think Documentation/devicetree/bindings/devfreq/
>>> sub-dir should be added to the DEVICE FREQUENCY (DEVFREQ) entry in the
>>> MAINTAINERS file.
>>>
>>>> I think that this patch will be more appropriate on devfreq git tree
>>>> than linux-samsung git tree.
>>>>
>>>
>>> Agreed.
>>>
>>
>> Any comments about this patch?
>
> Nope. It's applied.
>
>
> Thanks.
>
>
Great, thanks a lot.
>
> MyungJoo
>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-08-03 7:38 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-13 6:58 [PATCH] PM / devfreq: event: Remove incorrect property in exynos-ppmu DT binding Javier Martinez Canillas
2015-07-23 8:19 ` Chanwoo Choi
2015-07-23 8:30 ` Javier Martinez Canillas
2015-07-31 9:37 ` Javier Martinez Canillas
-- strict thread matches above, loose matches on Subject: below --
2015-08-03 4:58 MyungJoo Ham
2015-08-03 7:38 ` Javier Martinez Canillas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox