From: Sudeep Holla <sudeep.holla@arm.com>
To: Jolly Shah <JOLLYS@xilinx.com>,
"ard.biesheuvel@linaro.org" <ard.biesheuvel@linaro.org>,
"mingo@kernel.org" <mingo@kernel.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"matt@codeblueprint.co.uk" <matt@codeblueprint.co.uk>,
"hkallweit1@gmail.com" <hkallweit1@gmail.com>,
"keescook@chromium.org" <keescook@chromium.org>,
"dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>,
"mturquette@baylibre.com" <mturquette@baylibre.com>,
"sboyd@codeaurora.org" <sboyd@codeaurora.org>,
"michal.simek@xilinx.com" <michal.simek@xilinx.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
Rajan Vaja <RAJANV@xilinx.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v6 09/11] firmware: xilinx: Add debugfs for clock control APIs
Date: Tue, 15 May 2018 09:57:49 +0100 [thread overview]
Message-ID: <6579fdce-6845-70d5-1dc1-64d52debef19@arm.com> (raw)
In-Reply-To: <SN1PR02MB3758191654612CFC261A38BEB89C0@SN1PR02MB3758.namprd02.prod.outlook.com>
On 14/05/18 20:18, Jolly Shah wrote:
> Hi Sudeep,
[..]
>>
>> As I mentioned in earlier patch, I don't see the need for this
>> debugfs interface. Clock lay has read-only interface in debugfs
>> already. Also if you want to debug clocks, you can do so using the
>> driver which uses these clocks. Do you really want to manage clocks
>> in user-space ? The whole idea of EEMI kind of interface is to
>> abstract and hide the fine details even from non-trusted rich OS
>> like Linux kernel, but by providing this you are doing exactly
>> opposite.
>
> No we don't want to manage clocks in user-space. This debugfs is
> meant for developer who wants to debug APIs behavior in case
> something doesn't work as expected. Debugfs should be off by default
> in production images.
>
Good that it's not used in production image. The clock layer has
*sufficient* debugfs support that will *help in debugging*. So please
drop this Xilinx specific clock debugfs.
--
Regards,
Sudeep
next prev parent reply other threads:[~2018-05-15 8:57 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 19:38 [PATCH v6 00/11] drivers: Introduce firmware dnd clock river for ZynqMP core Jolly Shah
2018-04-10 19:38 ` [PATCH v6 01/11] dt-bindings: firmware: Add bindings for ZynqMP firmware Jolly Shah
2018-04-13 15:15 ` Rob Herring
2018-04-23 11:56 ` Greg KH
2018-04-10 19:38 ` [PATCH v6 02/11] firmware: xilinx: Add Zynqmp firmware driver Jolly Shah
2018-05-10 14:04 ` Sudeep Holla
2018-05-14 19:06 ` Jolly Shah
2018-04-10 19:38 ` [PATCH v6 03/11] firmware: xilinx: Add zynqmp IOCTL API for device control Jolly Shah
2018-05-10 14:09 ` Sudeep Holla
2018-05-14 19:11 ` Jolly Shah
2018-04-10 19:38 ` [PATCH v6 04/11] firmware: xilinx: Add query data API Jolly Shah
2018-05-10 14:12 ` Sudeep Holla
2018-05-14 19:16 ` Jolly Shah
2018-05-15 9:34 ` Sudeep Holla
2018-05-15 20:29 ` Jolly Shah
2018-04-10 19:38 ` [PATCH v6 05/11] firmware: xilinx: Add clock APIs Jolly Shah
2018-04-10 19:38 ` [PATCH v6 06/11] firmware: xilinx: Add debugfs interface Jolly Shah
2018-05-10 14:26 ` Sudeep Holla
2018-04-10 19:38 ` [PATCH v6 07/11] firmware: xilinx: Add debugfs for IOCTL API Jolly Shah
2018-04-10 19:38 ` [PATCH v6 08/11] firmware: xilinx: Add debugfs for query data API Jolly Shah
2018-04-10 19:38 ` [PATCH v6 09/11] firmware: xilinx: Add debugfs for clock control APIs Jolly Shah
2018-05-10 14:31 ` Sudeep Holla
2018-05-14 19:18 ` Jolly Shah
2018-05-15 8:57 ` Sudeep Holla [this message]
2018-05-25 19:23 ` Jolly Shah
2018-04-10 19:38 ` [PATCH v6 10/11] dt-bindings: clock: Add bindings for ZynqMP clock driver Jolly Shah
2018-04-16 21:28 ` Rob Herring
2018-04-10 19:38 ` [PATCH v6 11/11] drivers: clk: Add " Jolly Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6579fdce-6845-70d5-1dc1-64d52debef19@arm.com \
--to=sudeep.holla@arm.com \
--cc=JOLLYS@xilinx.com \
--cc=RAJANV@xilinx.com \
--cc=ard.biesheuvel@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hkallweit1@gmail.com \
--cc=keescook@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matt@codeblueprint.co.uk \
--cc=michal.simek@xilinx.com \
--cc=mingo@kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox