From: Sudeep Holla <sudeep.holla@arm.com>
To: Jolly Shah <jolly.shah@xilinx.com>,
ard.biesheuvel@linaro.org, mingo@kernel.org,
gregkh@linuxfoundation.org, matt@codeblueprint.co.uk,
hkallweit1@gmail.com, keescook@chromium.org,
dmitry.torokhov@gmail.com, mturquette@baylibre.com,
sboyd@codeaurora.org, michal.simek@xilinx.com,
robh+dt@kernel.org, mark.rutland@arm.com,
linux-clk@vger.kernel.org
Cc: Sudeep Holla <sudeep.holla@arm.com>,
rajanv@xilinx.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Jolly Shah <jollys@xilinx.com>
Subject: Re: [PATCH v6 06/11] firmware: xilinx: Add debugfs interface
Date: Thu, 10 May 2018 15:26:26 +0100 [thread overview]
Message-ID: <b880a598-54cb-6428-e60d-232615e809c1@arm.com> (raw)
In-Reply-To: <1523389127-14243-7-git-send-email-jollys@xilinx.com>
On 10/04/18 20:38, Jolly Shah wrote:
> From: Rajan Vaja <rajanv@xilinx.com>
>
> Firmware-debug provides debugfs interface to all APIs.
> Debugfs can be used to call firmware APIs with required
> parameters.
>
> Usage:
> * Calling firmware API through debugfs:
> # echo "<api-name> <arg1> .. <argn>" > /sys/.../zynqmp-firmware/pm
>
> * Read output of last called firmware API:
> # cat /sys/.../zynqmp-firmware/pm
>
> Refer ug1200 for more information on these APIs:
> * https://www.xilinx.com/support/documentation/user_guides/ug1200-eemi-api.pdf
>
> Add basic debugfs file to get API version.
Who are the users of this apart from debugging ? I am bit over sensitive
as this remote processor manages/controls the power and other shared
resources in the system. Giving such fine grained access to user space
is not a good idea. I assume you want this DEBUGFS off by default on
production images ?
--
Regards,
Sudeep
next prev parent reply other threads:[~2018-05-10 14:26 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 19:38 [PATCH v6 00/11] drivers: Introduce firmware dnd clock river for ZynqMP core Jolly Shah
2018-04-10 19:38 ` [PATCH v6 01/11] dt-bindings: firmware: Add bindings for ZynqMP firmware Jolly Shah
2018-04-13 15:15 ` Rob Herring
2018-04-23 11:56 ` Greg KH
2018-04-10 19:38 ` [PATCH v6 02/11] firmware: xilinx: Add Zynqmp firmware driver Jolly Shah
2018-05-10 14:04 ` Sudeep Holla
2018-05-14 19:06 ` Jolly Shah
2018-04-10 19:38 ` [PATCH v6 03/11] firmware: xilinx: Add zynqmp IOCTL API for device control Jolly Shah
2018-05-10 14:09 ` Sudeep Holla
2018-05-14 19:11 ` Jolly Shah
2018-04-10 19:38 ` [PATCH v6 04/11] firmware: xilinx: Add query data API Jolly Shah
2018-05-10 14:12 ` Sudeep Holla
2018-05-14 19:16 ` Jolly Shah
2018-05-15 9:34 ` Sudeep Holla
2018-05-15 20:29 ` Jolly Shah
2018-04-10 19:38 ` [PATCH v6 05/11] firmware: xilinx: Add clock APIs Jolly Shah
2018-04-10 19:38 ` [PATCH v6 06/11] firmware: xilinx: Add debugfs interface Jolly Shah
2018-05-10 14:26 ` Sudeep Holla [this message]
2018-04-10 19:38 ` [PATCH v6 07/11] firmware: xilinx: Add debugfs for IOCTL API Jolly Shah
2018-04-10 19:38 ` [PATCH v6 08/11] firmware: xilinx: Add debugfs for query data API Jolly Shah
2018-04-10 19:38 ` [PATCH v6 09/11] firmware: xilinx: Add debugfs for clock control APIs Jolly Shah
2018-05-10 14:31 ` Sudeep Holla
2018-05-14 19:18 ` Jolly Shah
2018-05-15 8:57 ` Sudeep Holla
2018-05-25 19:23 ` Jolly Shah
2018-04-10 19:38 ` [PATCH v6 10/11] dt-bindings: clock: Add bindings for ZynqMP clock driver Jolly Shah
2018-04-16 21:28 ` Rob Herring
2018-04-10 19:38 ` [PATCH v6 11/11] drivers: clk: Add " Jolly Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b880a598-54cb-6428-e60d-232615e809c1@arm.com \
--to=sudeep.holla@arm.com \
--cc=ard.biesheuvel@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hkallweit1@gmail.com \
--cc=jolly.shah@xilinx.com \
--cc=jollys@xilinx.com \
--cc=keescook@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matt@codeblueprint.co.uk \
--cc=michal.simek@xilinx.com \
--cc=mingo@kernel.org \
--cc=mturquette@baylibre.com \
--cc=rajanv@xilinx.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox