From: Stephen Boyd <sboyd@kernel.org>
To: Andrew Davis <afd@ti.com>,
Michael Turquette <mturquette@baylibre.com>,
Nishanth Menon <nm@ti.com>,
Santosh Shilimkar <ssantosh@kernel.org>,
Vignesh Raghavendra <vigneshr@ti.com>
Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
Andrew Davis <afd@ti.com>
Subject: Re: [PATCH] clk: keystone: syscon-clk: Do not use syscon helper to build regmap
Date: Tue, 04 Mar 2025 11:49:51 -0800 [thread overview]
Message-ID: <65e5503016f79f6c89219b5841c75b8c.sboyd@kernel.org> (raw)
In-Reply-To: <20250123181913.597304-1-afd@ti.com>
Quoting Andrew Davis (2025-01-23 10:19:13)
> The syscon helper device_node_to_regmap() is used to fetch a regmap
> registered to a device node. It also currently creates this regmap
> if the node did not already have a regmap associated with it. This
> should only be used on "syscon" nodes. This driver is not such a
> device and instead uses device_node_to_regmap() on its own node as
> a hacky way to create a regmap for itself.
>
> This will not work going forward and so we should create our regmap
> the normal way by defining our regmap_config, fetching our memory
> resource, then using the normal regmap_init_mmio() function.
>
> Signed-off-by: Andrew Davis <afd@ti.com>
> ---
Applied to clk-next
prev parent reply other threads:[~2025-03-04 19:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-23 18:19 [PATCH] clk: keystone: syscon-clk: Do not use syscon helper to build regmap Andrew Davis
2025-01-23 20:02 ` Nishanth Menon
2025-01-24 19:01 ` Stephen Boyd
2025-01-24 22:12 ` Nishanth Menon
2025-03-04 19:49 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65e5503016f79f6c89219b5841c75b8c.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=afd@ti.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=nm@ti.com \
--cc=ssantosh@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox