From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Marijn Suijten <marijn.suijten@somainline.org>
Cc: Konrad Dybcio <konrad.dybcio@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Clark <robdclark@gmail.com>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Sean Paul <sean@poorly.run>, David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>,
Krishna Manikandan <quic_mkrishn@quicinc.com>,
~postmarketos/upstreaming@lists.sr.ht,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Martin Botka <martin.botka@somainline.org>,
Jami Kettunen <jami.kettunen@somainline.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzk@kernel.org>,
linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, Lux Aliaga <they@mint.lgbt>
Subject: Re: [PATCH 03/15] dt-bindings: clock: qcom,dispcc-sm6125: Require GCC PLL0 DIV clock
Date: Tue, 27 Jun 2023 09:29:53 +0200 [thread overview]
Message-ID: <683a6f7e-bf1a-aff2-070b-472fb14e0353@linaro.org> (raw)
In-Reply-To: <yofju7jp7vmv33x7dzvzoelpumfsz3fjqy2ozakfphsuysunon@pglt2wzlsjex>
On 27/06/2023 08:54, Marijn Suijten wrote:
> On 2023-06-27 08:24:41, Krzysztof Kozlowski wrote:
>> On 26/06/2023 20:53, Marijn Suijten wrote:
>>> On 2023-06-26 20:51:38, Marijn Suijten wrote:
>>> <snip>
>>>>> Not really, binding also defines the list of clocks - their order and
>>>>> specific entries. This changes.
>>>>
>>>> And so it does in "dt-bindings: clock: qcom,dispcc-sm6125: Remove unused
>>>> GCC_DISP_AHB_CLK"?
>>>
>>> Never mind: it is the last item so the order of the other items doesn't
>>> change. The total number of items decreases though, which sounds like
>>> an ABI-break too?
>>
>> How does it break? Old DTS works exactly the same, doesn't it?
>
> So deleting a new item at the end does not matter. But what if I respin
> this patch to add the new clock _at the end_, which will then be at the
> same index as the previous GCC_DISP_AHB_CLK?
I think you know the answer, right? What do you want to prove? That two
independent changes can have together negative effect? We know this.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-06-27 7:30 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-24 0:40 [PATCH 00/15] drm/msm: Add SM6125 MDSS/DPU hardware and enable Sony Xperia 10 II panel Marijn Suijten
2023-06-24 0:40 ` [PATCH 01/15] arm64: dts: qcom: sm6125: Sort spmi_bus node numerically by reg Marijn Suijten
2023-06-24 1:43 ` Konrad Dybcio
2023-06-25 19:10 ` Marijn Suijten
2023-06-24 0:41 ` [PATCH 02/15] dt-bindings: clock: qcom,dispcc-sm6125: Remove unused GCC_DISP_AHB_CLK Marijn Suijten
2023-06-24 9:08 ` Krzysztof Kozlowski
2023-06-25 19:44 ` Marijn Suijten
2023-06-24 0:41 ` [PATCH 03/15] dt-bindings: clock: qcom,dispcc-sm6125: Require GCC PLL0 DIV clock Marijn Suijten
2023-06-24 1:45 ` Konrad Dybcio
2023-06-24 9:08 ` Krzysztof Kozlowski
2023-06-25 19:48 ` Marijn Suijten
2023-06-26 16:10 ` Krzysztof Kozlowski
2023-06-26 17:49 ` Marijn Suijten
2023-06-26 18:29 ` Krzysztof Kozlowski
2023-06-26 18:51 ` Marijn Suijten
2023-06-26 18:53 ` Marijn Suijten
2023-06-27 6:24 ` Krzysztof Kozlowski
2023-06-27 6:54 ` Marijn Suijten
2023-06-27 7:29 ` Krzysztof Kozlowski [this message]
2023-06-27 7:49 ` Marijn Suijten
2023-06-27 8:21 ` Krzysztof Kozlowski
2023-06-27 9:02 ` Marijn Suijten
2023-06-27 9:07 ` Krzysztof Kozlowski
2023-06-27 9:11 ` Marijn Suijten
2023-06-25 19:48 ` Marijn Suijten
2023-06-26 9:43 ` Konrad Dybcio
2023-06-26 14:26 ` Marijn Suijten
2023-06-26 16:15 ` Krzysztof Kozlowski
2023-06-26 17:47 ` Marijn Suijten
2023-06-24 0:41 ` [PATCH 04/15] dt-bindings: clock: qcom,dispcc-sm6125: Allow power-domains property Marijn Suijten
2023-06-24 9:10 ` Krzysztof Kozlowski
2023-06-24 0:41 ` [PATCH 05/15] dt-bindings: display/msm: dsi-controller-main: Document SM6125 Marijn Suijten
2023-06-24 9:11 ` Krzysztof Kozlowski
2023-06-24 0:41 ` [PATCH 06/15] dt-bindings: display/msm: sc7180-dpu: Describe SM6125 Marijn Suijten
2023-06-24 9:12 ` Krzysztof Kozlowski
2023-06-25 19:52 ` Marijn Suijten
2023-06-26 16:16 ` Krzysztof Kozlowski
2023-06-26 17:54 ` Marijn Suijten
2023-06-26 18:57 ` Konrad Dybcio
2023-06-26 20:28 ` Marijn Suijten
2023-06-26 22:46 ` Konrad Dybcio
2023-06-26 14:04 ` Dmitry Baryshkov
2023-06-28 20:27 ` [Freedreno] " Abhinav Kumar
2023-06-24 0:41 ` [PATCH 07/15] dt-bindings: display/msm: Add SM6125 MDSS Marijn Suijten
2023-06-24 2:03 ` Rob Herring
2023-06-24 9:31 ` Krzysztof Kozlowski
2023-06-24 0:41 ` [PATCH 08/15] drm/msm/dpu: Add SM6125 support Marijn Suijten
2023-06-24 1:47 ` Konrad Dybcio
2023-06-25 20:19 ` Marijn Suijten
2023-06-26 9:37 ` Konrad Dybcio
2023-06-24 0:41 ` [PATCH 09/15] drm/msm/mdss: " Marijn Suijten
2023-06-27 8:49 ` Dmitry Baryshkov
2023-06-27 9:06 ` Marijn Suijten
2023-06-24 0:41 ` [PATCH 10/15] dt-bindings: msm: dsi-phy-14nm: Document SM6125 variant Marijn Suijten
2023-06-24 9:33 ` Krzysztof Kozlowski
2023-06-24 13:48 ` Dmitry Baryshkov
2023-06-25 7:16 ` Krzysztof Kozlowski
2023-06-24 0:41 ` [PATCH 11/15] drm/msm/dsi: Add 14nm phy configuration for SM6125 Marijn Suijten
2023-06-24 1:49 ` Konrad Dybcio
2023-06-24 13:51 ` Dmitry Baryshkov
2023-06-25 20:23 ` Marijn Suijten
2023-06-26 9:50 ` Konrad Dybcio
2023-06-24 0:41 ` [PATCH 12/15] arm64: dts: qcom: sm6125: Switch fixed xo_board clock to RPM XO clock Marijn Suijten
2023-06-24 1:50 ` Konrad Dybcio
2023-06-24 0:41 ` [PATCH 13/15] arm64: dts: qcom: sm6125: Add dispcc node Marijn Suijten
2023-06-24 1:53 ` Konrad Dybcio
2023-06-24 13:52 ` Dmitry Baryshkov
2023-06-24 0:41 ` [PATCH 14/15] arm64: dts: qcom: sm6125: Add display hardware nodes Marijn Suijten
2023-06-24 2:05 ` Konrad Dybcio
2023-06-25 19:36 ` Marijn Suijten
2023-06-24 0:41 ` [PATCH 15/15] arm64: dts: qcom: sm6125-seine: Configure MDSS, DSI and panel Marijn Suijten
2023-06-24 2:06 ` Konrad Dybcio
2023-06-25 19:41 ` Marijn Suijten
2023-06-24 1:42 ` [PATCH 00/15] drm/msm: Add SM6125 MDSS/DPU hardware and enable Sony Xperia 10 II panel Konrad Dybcio
2023-06-25 19:18 ` Marijn Suijten
2023-06-26 9:41 ` Konrad Dybcio
2023-06-26 14:17 ` Marijn Suijten
2023-06-26 14:20 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=683a6f7e-bf1a-aff2-070b-472fb14e0353@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jami.kettunen@somainline.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzk@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=martin.botka@somainline.org \
--cc=mturquette@baylibre.com \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_mkrishn@quicinc.com \
--cc=robdclark@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sean@poorly.run \
--cc=they@mint.lgbt \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox