Re: [PATCH V4 5/7] clk: qcom: Add NSS clock Controller driver for IPQ9574

[Devi Priya <quic_devipriy@quicinc.com>]

On 6/25/2024 10:33 PM, Konrad Dybcio wrote:
> On 25.06.2024 9:05 AM, Devi Priya wrote:
>> Add Networking Sub System Clock Controller(NSSCC) driver for ipq9574 based
>> devices.
>>
>> Signed-off-by: Devi Priya <quic_devipriy@quicinc.com>
>> Tested-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
>> ---
> 
> [...]
> 
>> +	struct regmap *regmap;
>> +	struct qcom_cc_desc nsscc_ipq9574_desc = nss_cc_ipq9574_desc;
> 
> Why?
Sure, Will drop this in V6.
> 
>> +	struct clk *nsscc_clk;
>> +	struct device_node *np = (&pdev->dev)->of_node;
>> +	int ret;
>> +
>> +	nsscc_clk = of_clk_get(np, 11);
>> +	if (IS_ERR(nsscc_clk))
>> +		return PTR_ERR(nsscc_clk);
>> +
>> +	ret = clk_prepare_enable(nsscc_clk);
> 
> pm_clk_add()? And definitely drop the 11 literal, nobody could ever guess
> or maintain magic numbers
Hi Konrad,

nsscc clk isn't related to power management clocks.
Also, I believe it might require the usage of clock-names.
Do you suggest adding a macro for the literal (11)?
Please correct me if I'm wrong.

Thanks,
Devi Priya
> 
> Konrad