From: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Andy Gross <agross@kernel.org>, Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH v9 5/7] clk: qcom: clk-alpha-pll: add Lucid EVO PLL configuration interfaces
Date: Thu, 30 Jun 2022 16:34:48 +0300 [thread overview]
Message-ID: <6c6dddb7-a2d1-e93c-7448-6edb8ae3e665@linaro.org> (raw)
In-Reply-To: <Yr2TitZR3Yv8z/V1@matsya>
Hi Vinod,
On 6/30/22 15:14, Vinod Koul wrote:
> On 30-06-22, 11:18, Vladimir Zapolskiy wrote:
>> Add controls for Lucid EVO PLL configuration and export control functions
>> to clock controller drivers.
>
> This sound fine but maybe add why we are adding this (to be used in
> dispcc driver)... motivation helps :)
>
sure, and please note, that it's used by camcc as well, basically it's a reason
why this change is found in the series :)
> Other than this nit, lgtm:
>
> Reviewed-by: Vinod Koul <vkoul@kernel.org>
>
Thanks you for review!
--
Best wishes,
Vladimir
next prev parent reply other threads:[~2022-06-30 13:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-30 8:17 [PATCH v9 0/7] clk: qcom: add camera clock controller driver for SM8450 SoC Vladimir Zapolskiy
2022-06-30 8:17 ` [PATCH v9 1/7] dt-bindings: clock: add QCOM SM8450 camera clock bindings Vladimir Zapolskiy
2022-06-30 17:13 ` Bjorn Andersson
2022-06-30 8:17 ` [PATCH v9 2/7] arm64: dts: qcom: sm8450: Add description of camera clock controller Vladimir Zapolskiy
2022-06-30 10:39 ` Vinod Koul
2022-06-30 8:18 ` [PATCH v9 3/7] clk: qcom: clk-alpha-pll: fix clk_trion_pll_configure description Vladimir Zapolskiy
2022-06-30 10:39 ` Vinod Koul
2022-06-30 8:18 ` [PATCH v9 4/7] clk: qcom: clk-alpha-pll: limit exported symbols to GPL licensed code Vladimir Zapolskiy
2022-06-30 10:40 ` Vinod Koul
2022-06-30 8:18 ` [PATCH v9 5/7] clk: qcom: clk-alpha-pll: add Lucid EVO PLL configuration interfaces Vladimir Zapolskiy
2022-06-30 12:14 ` Vinod Koul
2022-06-30 13:34 ` Vladimir Zapolskiy [this message]
2022-06-30 8:18 ` [PATCH v9 6/7] clk: qcom: clk-alpha-pll: add Rivian " Vladimir Zapolskiy
2022-06-30 12:46 ` Vinod Koul
2022-06-30 8:18 ` [PATCH v9 7/7] clk: qcom: add camera clock controller driver for SM8450 SoC Vladimir Zapolskiy
2022-06-30 17:12 ` Bjorn Andersson
2022-07-01 4:38 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c6dddb7-a2d1-e93c-7448-6edb8ae3e665@linaro.org \
--to=vladimir.zapolskiy@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox