From: "Ettore Chimenti" <ettore.chimenti@linaro.org>
To: "Brian Masney" <masneyb@kernel.org>,
"Ettore Chimenti" <ettore.chimenti@linaro.org>
Cc: "Tero Kristo" <kristo@kernel.org>,
"Stephen Boyd" <sboyd@kernel.org>,
"Brian Masney" <bmasney+clk@redhat.com>,
"Jerome Brunet" <jbrunet+clk@baylibre.com>,
"Tony Lindgren" <tony@atomide.com>,
"Michael Turquette" <mturquette@linaro.org>,
"Andrew Goodbody" <andrew.goodbody@linaro.org>,
"Rouven Czerwinski" <rouven.czerwinski@linaro.org>,
<linux-omap@vger.kernel.org>, <linux-clk@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 4/4] clk-816x: add sys_ck clock as sys_clkin_ck alias
Date: Thu, 12 Nov 2026 01:01:07 +0100 [thread overview]
Message-ID: <DMSSHDUVX4J2.1YGT58MPOQYD0@linaro.org> (raw)
In-Reply-To: <179442321741.1131744.1980930320808367339.b4-reply@b4>
Hi Brian,
On Wed Nov 11, 2026 at 7:53 PM CET, Brian Masney wrote:
> Hi Ettore,
>
> On 2026-10-30 11:48:58+01:00, Ettore Chimenti wrote:
>> On Wed Oct 28, 2026 at 4:53 PM CET, Ettore Chimenti wrote:
>>
>> > This patch adds a new clock alias for the DM816x system, mapping
>> > 'sys_ck' to 'sys_clkin_ck'. This change is necessary because the voltage
>> > management driver searches for 'sys_ck' in these systems and fails
>> > without this alias. By including 'sys_ck' as an alias for
>> > 'sys_clkin_ck', we ensure compatibility with existing drivers that may
>> > reference 'sys_ck'.
>> >
>> > Tested-by: Andrew Goodbody <andrew.goodbody@linaro.org>
>> > Signed-off-by: Ettore Chimenti <ettore.chimenti@linaro.org>
>> > ---
>> > drivers/clk/ti/clk-816x.c | 1 +
>> > 1 file changed, 1 insertion(+)
>> >
>> > diff --git a/drivers/clk/ti/clk-816x.c b/drivers/clk/ti/clk-816x.c
>> > index 3b8e483aec92..fe6f66fc5a05 100644
>> > --- a/drivers/clk/ti/clk-816x.c
>> > +++ b/drivers/clk/ti/clk-816x.c
>> > @@ -57,6 +57,7 @@ static struct ti_dt_clk dm816x_clks[] = {
>> > DT_CLK(NULL, "timer_sys_ck", "sys_clkin_ck"),
>> > DT_CLK(NULL, "timer_32k_ck", "sysclk18_ck"),
>> > DT_CLK(NULL, "timer_ext_ck", "tclkin_ck"),
>> > + DT_CLK(NULL, "sys_ck", "sys_clkin_ck"),
>> > { .node_name = NULL },
>> > };
>>
>> I'll drop this patch from the series. The proposed approach from Sashiko
>> seems sound and I just sent a separate patch that implements that.
>
> Will there be a follow up to this series for the clk subsystem? I don't
> see any. I haven't gone through the other patches in this series. Or are
> just the first 3 patches here what needs to be reviewed / possibly
> merged?
Actually, I was waiting for reviews on the other patches before sending
a v3 to collect R-b's.
However, this patch (4/4) can be skipped reviewing. It will be dropped
as I've already sent [1] (it belongs to another subsystem, so you might
have missed it).
[1]: https://lore.kernel.org/all/20261030-patch-ektor5-dm81xx-vd-v1-1-8ba90608c25b@linaro.org/
>
> Brian
Thanks,
Ettore
prev parent reply other threads:[~2026-11-12 0:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 15:53 [PATCH v2 0/4] clk: ti: fapll/dm816x: clock tree and calculation fixes Ettore Chimenti
2026-10-28 15:53 ` [PATCH v2 1/4] clk: ti: fapll: remove ti_dt_clk_name helper Ettore Chimenti
2026-11-12 1:12 ` Brian Masney
2026-11-12 18:12 ` Andrew Goodbody
2026-10-28 15:53 ` [PATCH v2 2/4] clk: ti: fapll: Fix clock speed calculation Ettore Chimenti
2026-11-12 1:12 ` Brian Masney
2026-11-12 17:24 ` Andrew Goodbody
2026-11-12 18:44 ` Brian Masney
2026-10-28 15:53 ` [PATCH v2 3/4] clk: ti: fapll: print clock name that fails to register Ettore Chimenti
2026-10-28 15:53 ` [PATCH v2 4/4] clk-816x: add sys_ck clock as sys_clkin_ck alias Ettore Chimenti
2026-10-28 16:06 ` sashiko-bot
2026-10-30 10:48 ` Ettore Chimenti
2026-11-11 18:53 ` Brian Masney
2026-11-12 0:01 ` Ettore Chimenti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DMSSHDUVX4J2.1YGT58MPOQYD0@linaro.org \
--to=ettore.chimenti@linaro.org \
--cc=andrew.goodbody@linaro.org \
--cc=bmasney+clk@redhat.com \
--cc=jbrunet+clk@baylibre.com \
--cc=kristo@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=masneyb@kernel.org \
--cc=mturquette@linaro.org \
--cc=rouven.czerwinski@linaro.org \
--cc=sboyd@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox