[PATCH] clk: move orphan_list back to DEBUG_FS section

[PATCH] clk: move orphan_list back to DEBUG_FS section

[Wiebe, Wladislav (Nokia - DE/Ulm)]

commit 903c6bd937ca ("clk: Evict unregistered clks from parent caches")
in v4.19.142 moves orphan_list to global section which is not used when
CONFIG_DEBUG_FS is disabled.

Fixes:
drivers/clk/clk.c:49:27: error: 'orphan_list' defined but not used
[-Werror=unused-variable]
 static struct hlist_head *orphan_list[] = {
                           ^~~~~~~~~~~

Fixes: 903c6bd937ca ("clk: Evict unregistered clks from parent caches")

Signed-off-by: Wladislav Wiebe <wladislav.wiebe@nokia.com>

---
 drivers/clk/clk.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index c5cf9e77fe86..925dd84293f4 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -46,11 +46,6 @@ static struct hlist_head *all_lists[] = {
 	NULL,
 };
 
-static struct hlist_head *orphan_list[] = {
-	&clk_orphan_list,
-	NULL,
-};
-
 /***    private data structures    ***/
 
 struct clk_core {
@@ -2629,6 +2624,11 @@ static int inited = 0;
 static DEFINE_MUTEX(clk_debug_lock);
 static HLIST_HEAD(clk_debug_list);
 
+static struct hlist_head *orphan_list[] = {
+	&clk_orphan_list,
+	NULL,
+};
+
 static void clk_summary_show_one(struct seq_file *s, struct clk_core *c,
 				 int level)
 {
-- 
2.29.2

Re: [PATCH] clk: move orphan_list back to DEBUG_FS section

[Greg KH]

On Wed, Nov 18, 2020 at 10:23:02AM +0000, Wiebe, Wladislav (Nokia - DE/Ulm) wrote:
> commit 903c6bd937ca ("clk: Evict unregistered clks from parent caches")
> in v4.19.142 moves orphan_list to global section which is not used when
> CONFIG_DEBUG_FS is disabled.
> 
> Fixes:
> drivers/clk/clk.c:49:27: error: 'orphan_list' defined but not used
> [-Werror=unused-variable]
>  static struct hlist_head *orphan_list[] = {
>                            ^~~~~~~~~~~
> 
> Fixes: 903c6bd937ca ("clk: Evict unregistered clks from parent caches")
> 
> Signed-off-by: Wladislav Wiebe <wladislav.wiebe@nokia.com>
> 
> ---
>  drivers/clk/clk.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)

<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>

RE: [PATCH] clk: move orphan_list back to DEBUG_FS section

[Wiebe, Wladislav (Nokia - DE/Ulm)]

> From: Greg KH <gregkh@linuxfoundation.org>
> Sent: Wednesday, November 18, 2020 11:47 AM
> 
> On Wed, Nov 18, 2020 at 10:23:02AM +0000, Wiebe, Wladislav (Nokia -
> DE/Ulm) wrote:
> > commit 903c6bd937ca ("clk: Evict unregistered clks from parent
> > caches") in v4.19.142 moves orphan_list to global section which is not
> > used when CONFIG_DEBUG_FS is disabled.
> >
> > Fixes:
> > drivers/clk/clk.c:49:27: error: 'orphan_list' defined but not used
> > [-Werror=unused-variable]  static struct hlist_head *orphan_list[] = {
> >                            ^~~~~~~~~~~
> >
> > Fixes: 903c6bd937ca ("clk: Evict unregistered clks from parent
> > caches")
> >
> > Signed-off-by: Wladislav Wiebe <wladislav.wiebe@nokia.com>
> >
> > ---
> >  drivers/clk/clk.c | 10 +++++-----
> >  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> <formletter>
> 
> This is not the correct way to submit patches for inclusion in the stable kernel
> tree.  Please read:
>     https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> for how to do this properly.
> 
> </formletter>

Thanks for the hint Greg, I will resend.

- Wladislav