Re: [PATCH v2 7/8] clk: imx: pll14xx: Add pr_fmt

[Abel Vesa <abel.vesa@nxp.com>]

On 22-02-25 09:29:36, Sascha Hauer wrote:
> Print all messages from within the pll14xx driver with a common
> prefix using pr_fmt. No need to print function names anymore, so
> drop them from the messages.
> 
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Reviewed-by: Abel Vesa <abel.vesa@nxp.com>

> ---
> 
> Notes:
>     Changes since v1:
>     - Drop __func__ argument for which the %s was removed
> 
>  drivers/clk/imx/clk-pll14xx.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/clk/imx/clk-pll14xx.c b/drivers/clk/imx/clk-pll14xx.c
> index af4c979e70a64..646e0ce7d6242 100644
> --- a/drivers/clk/imx/clk-pll14xx.c
> +++ b/drivers/clk/imx/clk-pll14xx.c
> @@ -3,6 +3,8 @@
>   * Copyright 2017-2018 NXP.
>   */
>  
> +#define pr_fmt(fmt) "pll14xx: " fmt
> +
>  #include <linux/bitfield.h>
>  #include <linux/bits.h>
>  #include <linux/clk-provider.h>
> @@ -177,8 +179,8 @@ static int clk_pll1416x_set_rate(struct clk_hw *hw, unsigned long drate,
>  
>  	rate = imx_get_pll_settings(pll, drate);
>  	if (!rate) {
> -		pr_err("%s: Invalid rate : %lu for pll clk %s\n", __func__,
> -		       drate, clk_hw_get_name(hw));
> +		pr_err("Invalid rate %lu for pll clk %s\n", drate,
> +		       clk_hw_get_name(hw));
>  		return -EINVAL;
>  	}
>  
> @@ -404,8 +406,7 @@ struct clk_hw *imx_dev_clk_hw_pll14xx(struct device *dev, const char *name,
>  		init.ops = &clk_pll1443x_ops;
>  		break;
>  	default:
> -		pr_err("%s: Unknown pll type for pll clk %s\n",
> -		       __func__, name);
> +		pr_err("Unknown pll type for pll clk %s\n", name);
>  		kfree(pll);
>  		return ERR_PTR(-EINVAL);
>  	}
> @@ -424,8 +425,7 @@ struct clk_hw *imx_dev_clk_hw_pll14xx(struct device *dev, const char *name,
>  
>  	ret = clk_hw_register(dev, hw);
>  	if (ret) {
> -		pr_err("%s: failed to register pll %s %d\n",
> -			__func__, name, ret);
> +		pr_err("failed to register pll %s %d\n", name, ret);
>  		kfree(pll);
>  		return ERR_PTR(ret);
>  	}
> -- 
> 2.30.2
>