* [PATCH] clk: imx: off by one in imx_lpcg_parse_clks_from_dt()
@ 2022-02-28 7:50 Dan Carpenter
2022-02-28 9:28 ` Abel Vesa
2022-02-28 12:06 ` Abel Vesa
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2022-02-28 7:50 UTC (permalink / raw)
To: Abel Vesa, Dong Aisheng
Cc: Michael Turquette, Stephen Boyd, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team, linux-clk,
kernel-janitors
The > needs to be >= to prevent an off by one access.
Fixes: d5f1e6a2bb61 ("clk: imx: imx8qxp-lpcg: add parsing clocks from device tree")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/clk/imx/clk-imx8qxp-lpcg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/imx/clk-imx8qxp-lpcg.c b/drivers/clk/imx/clk-imx8qxp-lpcg.c
index b23758083ce5..5e31a6a24b3a 100644
--- a/drivers/clk/imx/clk-imx8qxp-lpcg.c
+++ b/drivers/clk/imx/clk-imx8qxp-lpcg.c
@@ -248,7 +248,7 @@ static int imx_lpcg_parse_clks_from_dt(struct platform_device *pdev,
for (i = 0; i < count; i++) {
idx = bit_offset[i] / 4;
- if (idx > IMX_LPCG_MAX_CLKS) {
+ if (idx >= IMX_LPCG_MAX_CLKS) {
dev_warn(&pdev->dev, "invalid bit offset of clock %d\n",
i);
ret = -EINVAL;
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] clk: imx: off by one in imx_lpcg_parse_clks_from_dt()
2022-02-28 7:50 [PATCH] clk: imx: off by one in imx_lpcg_parse_clks_from_dt() Dan Carpenter
@ 2022-02-28 9:28 ` Abel Vesa
2022-02-28 12:06 ` Abel Vesa
1 sibling, 0 replies; 3+ messages in thread
From: Abel Vesa @ 2022-02-28 9:28 UTC (permalink / raw)
To: Dan Carpenter
Cc: Dong Aisheng, Michael Turquette, Stephen Boyd, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, linux-clk, kernel-janitors
On 22-02-28 10:50:14, Dan Carpenter wrote:
> The > needs to be >= to prevent an off by one access.
>
> Fixes: d5f1e6a2bb61 ("clk: imx: imx8qxp-lpcg: add parsing clocks from device tree")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Makes sense.
Reviewed-by: Abel Vesa <abel.vesa@nxp.com>
> ---
> drivers/clk/imx/clk-imx8qxp-lpcg.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/imx/clk-imx8qxp-lpcg.c b/drivers/clk/imx/clk-imx8qxp-lpcg.c
> index b23758083ce5..5e31a6a24b3a 100644
> --- a/drivers/clk/imx/clk-imx8qxp-lpcg.c
> +++ b/drivers/clk/imx/clk-imx8qxp-lpcg.c
> @@ -248,7 +248,7 @@ static int imx_lpcg_parse_clks_from_dt(struct platform_device *pdev,
>
> for (i = 0; i < count; i++) {
> idx = bit_offset[i] / 4;
> - if (idx > IMX_LPCG_MAX_CLKS) {
> + if (idx >= IMX_LPCG_MAX_CLKS) {
> dev_warn(&pdev->dev, "invalid bit offset of clock %d\n",
> i);
> ret = -EINVAL;
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] clk: imx: off by one in imx_lpcg_parse_clks_from_dt()
2022-02-28 7:50 [PATCH] clk: imx: off by one in imx_lpcg_parse_clks_from_dt() Dan Carpenter
2022-02-28 9:28 ` Abel Vesa
@ 2022-02-28 12:06 ` Abel Vesa
1 sibling, 0 replies; 3+ messages in thread
From: Abel Vesa @ 2022-02-28 12:06 UTC (permalink / raw)
To: Dan Carpenter
Cc: Dong Aisheng, Michael Turquette, Stephen Boyd, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, linux-clk, kernel-janitors
On 22-02-28 10:50:14, Dan Carpenter wrote:
> The > needs to be >= to prevent an off by one access.
>
> Fixes: d5f1e6a2bb61 ("clk: imx: imx8qxp-lpcg: add parsing clocks from device tree")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks!
> ---
> drivers/clk/imx/clk-imx8qxp-lpcg.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/imx/clk-imx8qxp-lpcg.c b/drivers/clk/imx/clk-imx8qxp-lpcg.c
> index b23758083ce5..5e31a6a24b3a 100644
> --- a/drivers/clk/imx/clk-imx8qxp-lpcg.c
> +++ b/drivers/clk/imx/clk-imx8qxp-lpcg.c
> @@ -248,7 +248,7 @@ static int imx_lpcg_parse_clks_from_dt(struct platform_device *pdev,
>
> for (i = 0; i < count; i++) {
> idx = bit_offset[i] / 4;
> - if (idx > IMX_LPCG_MAX_CLKS) {
> + if (idx >= IMX_LPCG_MAX_CLKS) {
> dev_warn(&pdev->dev, "invalid bit offset of clock %d\n",
> i);
> ret = -EINVAL;
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-28 12:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-28 7:50 [PATCH] clk: imx: off by one in imx_lpcg_parse_clks_from_dt() Dan Carpenter
2022-02-28 9:28 ` Abel Vesa
2022-02-28 12:06 ` Abel Vesa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox