* Re: [PATCH] clk: qcom: gcc-sm8250: Fix gcc_sdcc2_apps_clk_src
2023-07-28 19:14 [PATCH] clk: qcom: gcc-sm8250: Fix gcc_sdcc2_apps_clk_src Patrick Whewell
@ 2023-07-28 19:23 ` Konrad Dybcio
2023-08-02 20:47 ` Patrick Whewell
2023-07-29 12:39 ` Bryan O'Donoghue
2023-07-31 16:47 ` William Breathitt Gray
2 siblings, 1 reply; 5+ messages in thread
From: Konrad Dybcio @ 2023-07-28 19:23 UTC (permalink / raw)
To: Patrick Whewell
Cc: Dmitry Baryshkov, William Gray, Andy Gross, Bjorn Andersson,
Michael Turquette, Stephen Boyd, Taniya Das, Bryan O'Donoghue,
Venkata Narendra Kumar Gutta, Vinod Koul, linux-arm-msm,
linux-clk, linux-kernel
On 28.07.2023 21:14, Patrick Whewell wrote:
> Set .flags = CLK_OPS_PARENT_ENABLE to fix "gcc_sdcc2_apps_clk_src: rcg
> didn't update its configuration" error.
>
> Signed-off-by: Patrick Whewell <patrick.whewell@sightlineapplications.com>
> Fixes: 3e5770921a88 ("clk: qcom: gcc: Add global clock controller driver for SM8250")
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
You could also mention that the error is caused by GPLL9 (the one
providing the highest frequency in the freq table) not being on
by default.
And ultra nit: your s-o-b should go last
Konrad
> drivers/clk/qcom/gcc-sm8250.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/qcom/gcc-sm8250.c b/drivers/clk/qcom/gcc-sm8250.c
> index b6cf4bc88d4d..d3c75bb55946 100644
> --- a/drivers/clk/qcom/gcc-sm8250.c
> +++ b/drivers/clk/qcom/gcc-sm8250.c
> @@ -721,6 +721,7 @@ static struct clk_rcg2 gcc_sdcc2_apps_clk_src = {
> .name = "gcc_sdcc2_apps_clk_src",
> .parent_data = gcc_parent_data_4,
> .num_parents = ARRAY_SIZE(gcc_parent_data_4),
> + .flags = CLK_OPS_PARENT_ENABLE,
> .ops = &clk_rcg2_floor_ops,
> },
> };
^ permalink raw reply [flat|nested] 5+ messages in thread* RE: [PATCH] clk: qcom: gcc-sm8250: Fix gcc_sdcc2_apps_clk_src
2023-07-28 19:23 ` Konrad Dybcio
@ 2023-08-02 20:47 ` Patrick Whewell
0 siblings, 0 replies; 5+ messages in thread
From: Patrick Whewell @ 2023-08-02 20:47 UTC (permalink / raw)
To: Konrad Dybcio
Cc: Dmitry Baryshkov, William Gray, Andy Gross, Bjorn Andersson,
Michael Turquette, Stephen Boyd, Taniya Das, Bryan O'Donoghue,
Venkata Narendra Kumar Gutta, Vinod Koul,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
On Friday, July 28, 2023 12:24 PM, Konrad Dybcio wrote:
> On 28.07.2023 21:14, Patrick Whewell wrote:
> > Set .flags = CLK_OPS_PARENT_ENABLE to fix "gcc_sdcc2_apps_clk_src: rcg
> > didn't update its configuration" error.
> >
> > Signed-off-by: Patrick Whewell
> > <patrick.whewell@sightlineapplications.com>
> > Fixes: 3e5770921a88 ("clk: qcom: gcc: Add global clock controller
> > driver for SM8250")
> > ---
> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>
> You could also mention that the error is caused by GPLL9 (the one providing
> the highest frequency in the freq table) not being on by default.
>
> And ultra nit: your s-o-b should go last
I will be sending over v2 shortly with both comments addressed.
>
> Konrad
> > drivers/clk/qcom/gcc-sm8250.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/clk/qcom/gcc-sm8250.c
> > b/drivers/clk/qcom/gcc-sm8250.c index b6cf4bc88d4d..d3c75bb55946
> > 100644
> > --- a/drivers/clk/qcom/gcc-sm8250.c
> > +++ b/drivers/clk/qcom/gcc-sm8250.c
> > @@ -721,6 +721,7 @@ static struct clk_rcg2 gcc_sdcc2_apps_clk_src = {
> > .name = "gcc_sdcc2_apps_clk_src",
> > .parent_data = gcc_parent_data_4,
> > .num_parents = ARRAY_SIZE(gcc_parent_data_4),
> > + .flags = CLK_OPS_PARENT_ENABLE,
> > .ops = &clk_rcg2_floor_ops,
> > },
> > };
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] clk: qcom: gcc-sm8250: Fix gcc_sdcc2_apps_clk_src
2023-07-28 19:14 [PATCH] clk: qcom: gcc-sm8250: Fix gcc_sdcc2_apps_clk_src Patrick Whewell
2023-07-28 19:23 ` Konrad Dybcio
@ 2023-07-29 12:39 ` Bryan O'Donoghue
2023-07-31 16:47 ` William Breathitt Gray
2 siblings, 0 replies; 5+ messages in thread
From: Bryan O'Donoghue @ 2023-07-29 12:39 UTC (permalink / raw)
To: Patrick Whewell
Cc: Dmitry Baryshkov, William Gray, Andy Gross, Bjorn Andersson,
Konrad Dybcio, Michael Turquette, Stephen Boyd, Taniya Das,
Venkata Narendra Kumar Gutta, Vinod Koul, linux-arm-msm,
linux-clk, linux-kernel
On 28/07/2023 20:14, Patrick Whewell wrote:
> Set .flags = CLK_OPS_PARENT_ENABLE to fix "gcc_sdcc2_apps_clk_src: rcg
> didn't update its configuration" error.
>
> Signed-off-by: Patrick Whewell <patrick.whewell@sightlineapplications.com>
> Fixes: 3e5770921a88 ("clk: qcom: gcc: Add global clock controller driver for SM8250")
> ---
> drivers/clk/qcom/gcc-sm8250.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/qcom/gcc-sm8250.c b/drivers/clk/qcom/gcc-sm8250.c
> index b6cf4bc88d4d..d3c75bb55946 100644
> --- a/drivers/clk/qcom/gcc-sm8250.c
> +++ b/drivers/clk/qcom/gcc-sm8250.c
> @@ -721,6 +721,7 @@ static struct clk_rcg2 gcc_sdcc2_apps_clk_src = {
> .name = "gcc_sdcc2_apps_clk_src",
> .parent_data = gcc_parent_data_4,
> .num_parents = ARRAY_SIZE(gcc_parent_data_4),
> + .flags = CLK_OPS_PARENT_ENABLE,
> .ops = &clk_rcg2_floor_ops,
> },
> };
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] clk: qcom: gcc-sm8250: Fix gcc_sdcc2_apps_clk_src
2023-07-28 19:14 [PATCH] clk: qcom: gcc-sm8250: Fix gcc_sdcc2_apps_clk_src Patrick Whewell
2023-07-28 19:23 ` Konrad Dybcio
2023-07-29 12:39 ` Bryan O'Donoghue
@ 2023-07-31 16:47 ` William Breathitt Gray
2 siblings, 0 replies; 5+ messages in thread
From: William Breathitt Gray @ 2023-07-31 16:47 UTC (permalink / raw)
To: Patrick Whewell
Cc: Dmitry Baryshkov, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Michael Turquette, Stephen Boyd, Taniya Das, Bryan O'Donoghue,
Venkata Narendra Kumar Gutta, Vinod Koul, linux-arm-msm,
linux-clk, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1081 bytes --]
On Fri, Jul 28, 2023 at 12:14:23PM -0700, Patrick Whewell wrote:
> Set .flags = CLK_OPS_PARENT_ENABLE to fix "gcc_sdcc2_apps_clk_src: rcg
> didn't update its configuration" error.
>
> Signed-off-by: Patrick Whewell <patrick.whewell@sightlineapplications.com>
> Fixes: 3e5770921a88 ("clk: qcom: gcc: Add global clock controller driver for SM8250")
The error appears resolved when tested on my Open-Q 865 SOM.
Tested-by: William Breathitt Gray <william.gray@linaro.org>
> ---
> drivers/clk/qcom/gcc-sm8250.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/qcom/gcc-sm8250.c b/drivers/clk/qcom/gcc-sm8250.c
> index b6cf4bc88d4d..d3c75bb55946 100644
> --- a/drivers/clk/qcom/gcc-sm8250.c
> +++ b/drivers/clk/qcom/gcc-sm8250.c
> @@ -721,6 +721,7 @@ static struct clk_rcg2 gcc_sdcc2_apps_clk_src = {
> .name = "gcc_sdcc2_apps_clk_src",
> .parent_data = gcc_parent_data_4,
> .num_parents = ARRAY_SIZE(gcc_parent_data_4),
> + .flags = CLK_OPS_PARENT_ENABLE,
> .ops = &clk_rcg2_floor_ops,
> },
> };
> --
> 2.25.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread