* [PATCH] clk: imx: composite-7ulp: Use NULL instead of 0
@ 2024-06-24 2:43 Peng Fan (OSS)
2024-06-24 9:05 ` Abel Vesa
2024-06-24 13:05 ` Abel Vesa
0 siblings, 2 replies; 3+ messages in thread
From: Peng Fan (OSS) @ 2024-06-24 2:43 UTC (permalink / raw)
To: abelvesa, mturquette, sboyd, shawnguo, s.hauer, kernel, festevam
Cc: imx, linux-clk, linux-arm-kernel, linux-kernel, Peng Fan,
kernel test robot
From: Peng Fan <peng.fan@nxp.com>
Address the sparse warnings "
sparse warnings: (new ones prefixed by >>)
>> drivers/clk/imx/clk-composite-7ulp.c:85:24: sparse: sparse:
Using plain integer as NULL pointer
"
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202406220536.JnAncjqz-lkp@intel.com/
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
V1:
Since the orignal patch is still in linux-next tree, so not add fixes tag
drivers/clk/imx/clk-composite-7ulp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/imx/clk-composite-7ulp.c b/drivers/clk/imx/clk-composite-7ulp.c
index db7f40b07d1a..8ed2e0ad2769 100644
--- a/drivers/clk/imx/clk-composite-7ulp.c
+++ b/drivers/clk/imx/clk-composite-7ulp.c
@@ -82,7 +82,7 @@ static struct clk_hw *imx_ulp_clk_hw_composite(const char *name,
val = readl(reg);
if (!(val & PCG_PR_MASK)) {
pr_info("PCC PR is 0 for clk:%s, bypass\n", name);
- return 0;
+ return NULL;
}
if (mux_present) {
--
2.37.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] clk: imx: composite-7ulp: Use NULL instead of 0
2024-06-24 2:43 [PATCH] clk: imx: composite-7ulp: Use NULL instead of 0 Peng Fan (OSS)
@ 2024-06-24 9:05 ` Abel Vesa
2024-06-24 13:05 ` Abel Vesa
1 sibling, 0 replies; 3+ messages in thread
From: Abel Vesa @ 2024-06-24 9:05 UTC (permalink / raw)
To: Peng Fan (OSS)
Cc: abelvesa, mturquette, sboyd, shawnguo, s.hauer, kernel, festevam,
imx, linux-clk, linux-arm-kernel, linux-kernel, Peng Fan,
kernel test robot
On 24-06-24 10:43:51, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> Address the sparse warnings "
> sparse warnings: (new ones prefixed by >>)
> >> drivers/clk/imx/clk-composite-7ulp.c:85:24: sparse: sparse:
> Using plain integer as NULL pointer
> "
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202406220536.JnAncjqz-lkp@intel.com/
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
Reviewed-by: Abel Vesa <abel.vesa@linaro.org>
> ---
>
> V1:
> Since the orignal patch is still in linux-next tree, so not add fixes tag
>
> drivers/clk/imx/clk-composite-7ulp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/imx/clk-composite-7ulp.c b/drivers/clk/imx/clk-composite-7ulp.c
> index db7f40b07d1a..8ed2e0ad2769 100644
> --- a/drivers/clk/imx/clk-composite-7ulp.c
> +++ b/drivers/clk/imx/clk-composite-7ulp.c
> @@ -82,7 +82,7 @@ static struct clk_hw *imx_ulp_clk_hw_composite(const char *name,
> val = readl(reg);
> if (!(val & PCG_PR_MASK)) {
> pr_info("PCC PR is 0 for clk:%s, bypass\n", name);
> - return 0;
> + return NULL;
> }
>
> if (mux_present) {
> --
> 2.37.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] clk: imx: composite-7ulp: Use NULL instead of 0
2024-06-24 2:43 [PATCH] clk: imx: composite-7ulp: Use NULL instead of 0 Peng Fan (OSS)
2024-06-24 9:05 ` Abel Vesa
@ 2024-06-24 13:05 ` Abel Vesa
1 sibling, 0 replies; 3+ messages in thread
From: Abel Vesa @ 2024-06-24 13:05 UTC (permalink / raw)
To: abelvesa, mturquette, sboyd, shawnguo, s.hauer, kernel, festevam,
Peng Fan (OSS)
Cc: imx, linux-clk, linux-arm-kernel, linux-kernel, Peng Fan,
kernel test robot
On Mon, 24 Jun 2024 10:43:51 +0800, Peng Fan (OSS) wrote:
> Address the sparse warnings "
> sparse warnings: (new ones prefixed by >>)
> >> drivers/clk/imx/clk-composite-7ulp.c:85:24: sparse: sparse:
> Using plain integer as NULL pointer
> "
>
>
> [...]
Applied, thanks!
[1/1] clk: imx: composite-7ulp: Use NULL instead of 0
commit: 466da3d2d967ee87d82060df2bc9c6ad4fc4af49
Best regards,
--
Abel Vesa <abel.vesa@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-06-24 13:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-24 2:43 [PATCH] clk: imx: composite-7ulp: Use NULL instead of 0 Peng Fan (OSS)
2024-06-24 9:05 ` Abel Vesa
2024-06-24 13:05 ` Abel Vesa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox