From: Brian Masney <bmasney@redhat.com>
To: Icenowy Zheng <uwu@icenowy.me>
Cc: Drew Fustini <fustini@kernel.org>, Guo Ren <guoren@kernel.org>,
Fu Wei <wefu@redhat.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Michal Wilczynski <m.wilczynski@samsung.com>,
linux-riscv@lists.infradead.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] clk: thead: support changing DPU pixel clock rate
Date: Thu, 21 Aug 2025 14:29:55 -0400 [thread overview]
Message-ID: <aKdlo6R3ER99klYn@x1> (raw)
In-Reply-To: <20250812054258.1968351-3-uwu@icenowy.me>
On Tue, Aug 12, 2025 at 01:42:56PM +0800, Icenowy Zheng wrote:
> The DPU pixel clock rate corresponds to the required dot clock of the
> display mode, so it needs to be tweakable.
>
> Add support to change it, by adding generic divider setting code,
> arming the code to the dpu0/dpu1 clocks, and setting the pixel clock
> connected to the DPU (after a gate) to CLK_SET_RATE_PARENT to propagate
> it to the dividers.
>
> Signed-off-by: Icenowy Zheng <uwu@icenowy.me>
> ---
> drivers/clk/thead/clk-th1520-ap.c | 87 +++++++++++++++++++++++++++++--
> 1 file changed, 82 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/clk/thead/clk-th1520-ap.c b/drivers/clk/thead/clk-th1520-ap.c
> index 2f87c7c2c3baf..3e81f3051cd6c 100644
> --- a/drivers/clk/thead/clk-th1520-ap.c
> +++ b/drivers/clk/thead/clk-th1520-ap.c
> @@ -55,6 +55,7 @@ struct ccu_gate {
>
> struct ccu_div {
> u32 enable;
> + u32 div_en;
> struct ccu_div_internal div;
> struct ccu_internal mux;
> struct ccu_common common;
> @@ -198,6 +199,78 @@ static unsigned long ccu_div_recalc_rate(struct clk_hw *hw,
> return rate;
> }
>
> +static long ccu_div_round_rate(struct clk_hw *hw, unsigned long rate,
> + unsigned long *parent_rate)
> +{
> + struct ccu_div *cd = hw_to_ccu_div(hw);
> + unsigned int val;
> +
> + if (!cd->div_en) {
> + regmap_read(cd->common.map, cd->common.cfg0, &val);
> + val = val >> cd->div.shift;
> + val &= GENMASK(cd->div.width - 1, 0);
> + return divider_ro_round_rate(hw, rate, parent_rate,
> + NULL, cd->div.width, cd->div.flags,
> + val);
> + } else {
> + return divider_round_rate(hw, rate, parent_rate,
> + NULL, cd->div.width, cd->div.flags);
> + }
> +}
The round_rate clk op is deprecated. Please convert this over to use
determine_rate.
Brian
next prev parent reply other threads:[~2025-08-21 18:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-12 5:42 [PATCH 0/4] clk: thead: Misc changes to TH1520 clock driver Icenowy Zheng
2025-08-12 5:42 ` [PATCH 1/4] clk: thead: add support for enabling/disabling PLLs Icenowy Zheng
2025-08-12 5:42 ` [PATCH 2/4] clk: thead: support changing DPU pixel clock rate Icenowy Zheng
2025-08-13 2:04 ` Troy Mitchell
2025-08-13 5:54 ` Icenowy Zheng
2025-08-21 18:29 ` Brian Masney [this message]
2025-08-12 5:42 ` [PATCH 3/4] clk: thead: th1520-ap: set all AXI clocks to CLK_IS_CRITICAL Icenowy Zheng
2025-08-12 5:56 ` Icenowy Zheng
2025-08-12 6:04 ` [PATCH 3/4 FIXED] " Icenowy Zheng
2025-08-12 6:26 ` Drew Fustini
2025-08-12 6:23 ` [PATCH 3/4] " Drew Fustini
2025-08-12 5:42 ` [PATCH 4/4] clk: thead: th1520-ap: fix parent of padctrl0 clock Icenowy Zheng
2025-08-12 6:04 ` [PATCH 4/4 FIXED] " Icenowy Zheng
2025-08-12 9:17 ` Icenowy Zheng
2025-08-12 13:42 ` [PATCH 0/4] clk: thead: Misc changes to TH1520 clock driver Icenowy Zheng
2025-08-12 16:24 ` Drew Fustini
2025-08-12 19:50 ` Icenowy Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aKdlo6R3ER99klYn@x1 \
--to=bmasney@redhat.com \
--cc=fustini@kernel.org \
--cc=guoren@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=m.wilczynski@samsung.com \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=uwu@icenowy.me \
--cc=wefu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox