* Re: [linux-next:master 6189/12740] drivers/clk/microchip/clk-core.c:391:12: error: redefinition of 'roclk_determine_rate'
[not found] <202509280327.jsapR0Ww-lkp@intel.com>
@ 2025-09-28 0:36 ` Brian Masney
0 siblings, 0 replies; only message in thread
From: Brian Masney @ 2025-09-28 0:36 UTC (permalink / raw)
To: kernel test robot; +Cc: oe-kbuild-all, Stephen Boyd, linux-clk
On Sun, Sep 28, 2025 at 03:48:14AM +0800, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: 262858079afde6d367ce3db183c74d8a43a0e83f
> commit: e9f039c08cdc9b38665aee9a88ae21f59c09ba8c [6189/12740] clk: microchip: core: convert from round_rate() to determine_rate()
> config: mips-randconfig-r131-20250927 (https://download.01.org/0day-ci/archive/20250928/202509280327.jsapR0Ww-lkp@intel.com/config)
> compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project cafc064fc7a96b3979a023ddae1da2b499d6c954)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250928/202509280327.jsapR0Ww-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202509280327.jsapR0Ww-lkp@intel.com/
>
> All errors (new ones prefixed by >>):
>
> >> drivers/clk/microchip/clk-core.c:391:12: error: redefinition of 'roclk_determine_rate'
> 391 | static int roclk_determine_rate(struct clk_hw *hw,
> | ^
> drivers/clk/microchip/clk-core.c:377:12: note: previous definition is here
> 377 | static int roclk_determine_rate(struct clk_hw *hw,
> | ^
> >> drivers/clk/microchip/clk-core.c:411:18: error: call to undeclared function 'roclk_round_rate'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
> 411 | nearest_rate = roclk_round_rate(hw, req->rate, &parent_rate);
> | ^
> drivers/clk/microchip/clk-core.c:926:20: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides]
> 926 | .determine_rate = __clk_mux_determine_rate,
> | ^~~~~~~~~~~~~~~~~~~~~~~~
> drivers/clk/microchip/clk-core.c:922:20: note: previous initialization is here
> 922 | .determine_rate = sclk_determine_rate,
> | ^~~~~~~~~~~~~~~~~~~
> 1 warning and 2 errors generated.
I fixed this with:
https://lore.kernel.org/linux-clk/20250927-clk-microchip-core-compile-error-v2-1-3473dbae3625@redhat.com/T/#u
Sorry I had to send out a v2 with the tags.
Stephen: Since the original change hasn't landed in Linus's tree yet,
it's up to you if you want to squash this fix with my original commit.
Brian
^ permalink raw reply [flat|nested] only message in thread