From: Bjorn Andersson <andersson@kernel.org>
To: Sreeshankar K <sreeshankar0910@gmail.com>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
mturquette@baylibre.com, sboyd@kernel.org, rafael@kernel.org,
viresh.kumar@linaro.org, konradybcio@kernel.org,
tglx@kernel.org, ulfh@kernel.org, bmasney@redhat.com,
radu@rendec.net, abel.vesa@oss.qualcomm.com,
lpieralisi@kernel.org, taniya.das@oss.qualcomm.com,
danila@mainlining.org, davidwronek@gmail.com, mani@kernel.org,
robimarko@gmail.com, linux@gurudas.dev,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v6 04/13] clk: qcom: Add Global Clock Controller (GCC) driver for SM7250
Date: Mon, 31 Aug 2026 18:26:32 -0500 [thread overview]
Message-ID: <apYNXZ9TJEC6rVVf@baldur> (raw)
In-Reply-To: <20260824150156.1310-5-sreeshankar0910@gmail.com>
On Mon, Aug 24, 2026 at 03:01:47PM +0000, Sreeshankar K wrote:
> Add support for the global clock controller found on SM7250
> based devices. This should allow most non-multimedia device
> drivers to probe and control their clocks.
"This should"?
>
> Signed-off-by: Sreeshankar K <sreeshankar0910@gmail.com>
[..]
> diff --git a/drivers/clk/qcom/gcc-sm7250.c b/drivers/clk/qcom/gcc-sm7250.c
[..]
> + .clk_regs_configure = gcc_sm7250_clk_regs_configure,
/home/bjorn/sandbox/kernel/workspace/drivers/clk/qcom/gcc-sm7250.c:2228:24: error: incompatible function pointer types initializing 'void (*)(struct device *, struct regmap *)' with an expression of type 'void (struct regmap *)' [-Wincompatible-function-pointer-types]
2228 | .clk_regs_configure = gcc_sm7250_clk_regs_configure,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
Thank you,
Bjorn
> +};
next prev parent reply other threads:[~2026-08-31 23:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-24 15:01 [PATCH v6 00/13] Add initial support for Qualcomm SM7250 SoC Sreeshankar K
2026-08-24 15:01 ` [PATCH v6 01/13] dt-bindings: arm: qcom,ids: Add SoC ID for SM7250 Sreeshankar K
2026-08-24 15:01 ` [PATCH v6 02/13] soc: qcom: socinfo: Add SM7250 SoC ID Sreeshankar K
2026-08-24 15:01 ` [PATCH v6 03/13] dt-bindings: clock: Add SM7250 global clock controller Sreeshankar K
2026-08-24 15:01 ` [PATCH v6 04/13] clk: qcom: Add Global Clock Controller (GCC) driver for SM7250 Sreeshankar K
2026-08-31 23:26 ` Bjorn Andersson [this message]
2026-09-01 6:35 ` Sreeshankar K
2026-08-24 15:01 ` [PATCH v6 05/13] dt-bindings: clock: qcom,rpmhcc: Document RPMHCC compatible " Sreeshankar K
2026-08-24 15:01 ` [PATCH v6 06/13] clk: qcom: rpmh: Add SM7250 rpmh clocks Sreeshankar K
2026-08-24 15:01 ` [PATCH v6 07/13] dt-bindings: power: qcom,rpmhpd: Document RPMh power domain for SM7250 Sreeshankar K
2026-08-28 9:57 ` Krzysztof Kozlowski
2026-08-24 15:01 ` [PATCH v6 08/13] pmdomain: qcom: rpmhpd: Add RPMh power domains " Sreeshankar K
2026-08-24 15:01 ` [PATCH v6 09/13] dt-bindings: arm: cpus: Document Kryo 475 CPUs Sreeshankar K
2026-08-28 9:58 ` Krzysztof Kozlowski
2026-08-24 15:01 ` [PATCH v6 10/13] dt-bindings: firmware: qcom,scm: Document SM7250 SCM Sreeshankar K
2026-08-24 15:01 ` [PATCH v6 11/13] dt-bindings: interrupt-controller: qcom,pdc: Document SM7250 PDC Sreeshankar K
2026-08-28 9:58 ` Krzysztof Kozlowski
2026-08-24 15:01 ` [PATCH v6 12/13] dt-bindings: cpufreq: qcom-hw: Document SM7250 cpufreq hardware Sreeshankar K
2026-08-28 9:58 ` Krzysztof Kozlowski
2026-08-24 15:01 ` [PATCH v6 13/13] arm64: dts: qcom: Add SM7250 devicetree file Sreeshankar K
2026-08-28 9:56 ` [PATCH v6 00/13] Add initial support for Qualcomm SM7250 SoC Krzysztof Kozlowski
2026-08-28 10:14 ` Sreeshankar K
2026-09-01 2:09 ` (subset) " Bjorn Andersson
2026-09-01 6:29 ` Sreeshankar K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=apYNXZ9TJEC6rVVf@baldur \
--to=andersson@kernel.org \
--cc=abel.vesa@oss.qualcomm.com \
--cc=bmasney@redhat.com \
--cc=conor+dt@kernel.org \
--cc=danila@mainlining.org \
--cc=davidwronek@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@gurudas.dev \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=mturquette@baylibre.com \
--cc=radu@rendec.net \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=robimarko@gmail.com \
--cc=sboyd@kernel.org \
--cc=sreeshankar0910@gmail.com \
--cc=taniya.das@oss.qualcomm.com \
--cc=tglx@kernel.org \
--cc=ulfh@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox