From: Andrew Lunn <andrew@lunn.ch>
To: Fedor Pchelkin <pchelkin@ispras.ru>
Cc: Stephen Boyd <sboyd@kernel.org>,
lvc-project@linuxtesting.org,
Michael Turquette <mturquette@baylibre.com>,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
Gregory Clement <gregory.clement@bootlin.com>,
linux-arm-kernel@lists.infradead.org,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [lvc-project] [PATCH v3] clk: mvebu: Prevent division by zero in clk_double_div_recalc_rate()
Date: Wed, 9 Oct 2024 14:23:12 +0200 [thread overview]
Message-ID: <b2489acc-d997-43e7-aeaf-c662b6fd3253@lunn.ch> (raw)
In-Reply-To: <20241009-29749473966747300f3d1d3b-pchelkin@ispras.ru>
> > I would say, let is divide by 0, so there is an obvious kernel stack
> > trace and hopefully a report of the issue. It can then be investigated
> > in a way we can then find out what the hardware actually is doing.
>
> Is it worth adding some kind of WARN assertions? Or actually just leave it
> for now as is?
What actually happens on a / 0 on ARM? I assume it triggers an
exception, which will give a stack trace? If so a WARN adds no value.
Andrew
next prev parent reply other threads:[~2024-10-09 12:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-09 13:38 [PATCH] clk: mvebu: Prevent division by zero in clk_double_div_recalc_rate() Alexandra Diupina
2024-09-09 14:02 ` Andrew Lunn
2024-09-09 14:17 ` Alexandra Diupina
2024-09-09 14:34 ` Andrew Lunn
2024-09-10 17:31 ` [PATCH v2] " Alexandra Diupina
2024-09-10 18:59 ` Andrew Lunn
2024-09-17 13:22 ` [PATCH v3] " Alexandra Diupina
2024-09-19 10:24 ` Stephen Boyd
2024-09-24 13:14 ` Alexandra Diupina
2024-10-07 22:56 ` Stephen Boyd
2024-10-08 21:58 ` Andrew Lunn
2024-10-09 9:01 ` [lvc-project] " Fedor Pchelkin
2024-10-09 12:23 ` Andrew Lunn [this message]
2024-10-09 13:43 ` Fedor Pchelkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2489acc-d997-43e7-aeaf-c662b6fd3253@lunn.ch \
--to=andrew@lunn.ch \
--cc=gregory.clement@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=mturquette@baylibre.com \
--cc=pchelkin@ispras.ru \
--cc=sboyd@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox