From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jacky Huang <ychuang3@nuvoton.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
ychuang570808@gmail.com
Cc: robh+dt@kernel.org, sboyd@kernel.org, krzk+dt@kernel.org,
arnd@arndb.de, olof@lixom.net, will@kernel.org, soc@kernel.org,
cfli0@nuvoton.com
Subject: Re: [PATCH v3 2/5] dt-bindings: clock: Document MA35D1 clock controller bindings
Date: Tue, 19 Apr 2022 12:39:48 +0200 [thread overview]
Message-ID: <b2e32685-73a6-98be-50be-5121c67431ed@linaro.org> (raw)
In-Reply-To: <29b00c24-681a-7f6f-f27d-b7525c5b8485@nuvoton.com>
On 19/04/2022 12:12, Jacky Huang wrote:
>>> +
>>> + assigned-clock-rates:
>>> + minItems: 5
>>> + maxItems: 5
>>> +
>>> + nuvoton,clk-pll-mode:
>>> + A list of PLL operation mode corresponding to DDRPLL, APLL, EPLL,
>>> + and VPLL in sequential.
>> This does not look like a binding which was tested. Read
>> "writing-schema" and test your bindings.
>
> "nuvoton,clk-pll-mode" is a nonstandard property used to describe the
> operation mode of
> corresponding PLLs.
>
> (According to Device tree Specification section "2.2.4 Properties"
> Nonstandard property names should specify a unique string prefix, such
> as a stock ticker symbol, identifying the name of
> the company or organization that defined the property. Examples:
I am not saying about property name. I replied under some description
below which fails to build.
Instead please test your bindings.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-04-19 10:41 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-18 8:27 [PATCH v3 0/5] Add initial support for MA35D1 SoC Jacky Huang
2022-04-18 8:27 ` [PATCH v3 1/5] dt-bindings: clock: add binding for MA35D1 clock controller Jacky Huang
2022-04-18 12:09 ` Krzysztof Kozlowski
2022-04-18 8:27 ` [PATCH v3 2/5] dt-bindings: clock: Document MA35D1 clock controller bindings Jacky Huang
2022-04-18 12:18 ` Krzysztof Kozlowski
2022-04-19 10:12 ` Jacky Huang
2022-04-19 10:39 ` Krzysztof Kozlowski [this message]
2022-04-19 10:49 ` Jacky Huang
2022-04-18 13:35 ` Rob Herring
2022-04-19 8:49 ` Jacky Huang
2022-04-18 8:27 ` [PATCH v3 3/5] arm64: dts: nuvoton: Add initial support for MA35D1 Jacky Huang
2022-04-18 12:20 ` Krzysztof Kozlowski
2022-04-21 6:41 ` Jacky Huang
2022-04-18 8:27 ` [PATCH v3 4/5] arm64: Kconfig: nuvoton: Introduce CONFIG_ARCH_NUVOTON Jacky Huang
2022-04-18 8:27 ` [PATCH v3 5/5] dt-bindings: arm: Add initial bindings for Nuvoton Platform Jacky Huang
2022-04-18 12:11 ` Krzysztof Kozlowski
2022-04-21 6:39 ` Jacky Huang
2022-04-21 6:56 ` Krzysztof Kozlowski
2022-04-21 8:04 ` Jacky Huang
2022-04-21 8:05 ` Krzysztof Kozlowski
2022-04-21 8:13 ` Jacky Huang
2022-04-21 8:33 ` Krzysztof Kozlowski
2022-04-26 0:19 ` Rob Herring
2022-04-26 0:47 ` Jacky Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2e32685-73a6-98be-50be-5121c67431ed@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=arnd@arndb.de \
--cc=cfli0@nuvoton.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=soc@kernel.org \
--cc=will@kernel.org \
--cc=ychuang3@nuvoton.com \
--cc=ychuang570808@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox