From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Kathiravan Thirumoorthy <quic_kathirav@quicinc.com>,
Manikanta Mylavarapu <quic_mmanikan@quicinc.com>,
andersson@kernel.org, linus.walleij@linaro.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, konradybcio@kernel.org,
mturquette@baylibre.com, sboyd@kernel.org,
linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org
Cc: quic_varada@quicinc.com, quic_srichara@quicinc.com
Subject: Re: [PATCH v3 0/6] Add SPI4 support for IPQ5424
Date: Mon, 30 Dec 2024 14:54:47 +0100 [thread overview]
Message-ID: <d4875732-ec24-4e35-9a7b-af05c6ee7d4b@oss.qualcomm.com> (raw)
In-Reply-To: <e673dbdf-9b16-4c64-a3e0-cf5bb31e2b82@quicinc.com>
On 30.12.2024 7:51 AM, Kathiravan Thirumoorthy wrote:
>
>
> On 12/27/2024 12:54 PM, Manikanta Mylavarapu wrote:
>> Add SPI4 node to the IPQ5424 device tree and update the relevant
>> bindings, GPIO pin mappings accordingly.
>>
>> Changes in V3:
>> - Rename SPI0 to SPI4 because SPI protocol runs on serial engine 4
>
> Do we really need to do this? If so, it will not align with the HW documentation and will lead to the confusion down the line. IMHO, we should stick with the convention followed in the HW documentation.
+1, the clocks are called SPI0/SPI1 internally
Konrad
next prev parent reply other threads:[~2024-12-30 13:54 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-27 7:24 [PATCH v3 0/6] Add SPI4 support for IPQ5424 Manikanta Mylavarapu
2024-12-27 7:24 ` [PATCH v3 1/6] dt-bindings: pinctrl: qcom: rename spi0 pins on IPQ5424 Manikanta Mylavarapu
2024-12-27 7:36 ` Krzysztof Kozlowski
2024-12-27 9:18 ` Manikanta Mylavarapu
2024-12-27 9:30 ` Krzysztof Kozlowski
2024-12-30 7:50 ` Manikanta Mylavarapu
2024-12-30 8:16 ` Krzysztof Kozlowski
2024-12-30 10:47 ` Manikanta Mylavarapu
2024-12-27 7:24 ` [PATCH v3 2/6] dt-bindings: clock: qcom: gcc-ipq5424: add spi4 clocks Manikanta Mylavarapu
2024-12-28 10:09 ` Krzysztof Kozlowski
2024-12-27 7:24 ` [PATCH v3 3/6] pinctrl: qcom: ipq5424: rename spi0 pins Manikanta Mylavarapu
2024-12-27 7:24 ` [PATCH v3 4/6] clk: qcom: ipq5424: rename spi0 clocks Manikanta Mylavarapu
2024-12-28 10:10 ` Krzysztof Kozlowski
2024-12-27 7:24 ` [PATCH v3 5/6] arm64: dts: qcom: ipq5424: add spi4 node Manikanta Mylavarapu
2024-12-27 7:24 ` [PATCH v3 6/6] arm64: dts: qcom: ipq5424: configure spi4 node for rdp466 Manikanta Mylavarapu
2024-12-30 6:51 ` [PATCH v3 0/6] Add SPI4 support for IPQ5424 Kathiravan Thirumoorthy
2024-12-30 13:54 ` Konrad Dybcio [this message]
2024-12-30 13:58 ` Konrad Dybcio
2024-12-30 15:34 ` Kathiravan Thirumoorthy
2024-12-30 15:36 ` Konrad Dybcio
2025-01-02 6:00 ` Manikanta Mylavarapu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4875732-ec24-4e35-9a7b-af05c6ee7d4b@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_kathirav@quicinc.com \
--cc=quic_mmanikan@quicinc.com \
--cc=quic_srichara@quicinc.com \
--cc=quic_varada@quicinc.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox