* [PATCH] clk: qcom: dispcc-glymur: Constify 'struct qcom_cc_desc'
@ 2025-09-09 9:47 Imran Shaik
2025-09-09 11:14 ` Dmitry Baryshkov
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Imran Shaik @ 2025-09-09 9:47 UTC (permalink / raw)
To: Bjorn Andersson, Michael Turquette, Stephen Boyd
Cc: Jagadeesh Kona, linux-arm-msm, linux-clk, linux-kernel,
Ajit Pandey, Taniya Das, Imran Shaik, Krzysztof Kozlowski
'struct qcom_cc_desc' is passed to qcom_cc_map() and
qcom_cc_really_probe() only as pointer to const, so make the memory
const for safety.
Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Imran Shaik <imran.shaik@oss.qualcomm.com>
---
This commit is similar to [1].
[1] https://lore.kernel.org/r/20250820124821.149141-2-krzysztof.kozlowski@linaro.org
---
drivers/clk/qcom/dispcc-glymur.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/qcom/dispcc-glymur.c b/drivers/clk/qcom/dispcc-glymur.c
index d755b41cf458a7cb9c22f510a16a414562432dab..5203fa6383f6ac7fb49e888887ee9105101a9b56 100644
--- a/drivers/clk/qcom/dispcc-glymur.c
+++ b/drivers/clk/qcom/dispcc-glymur.c
@@ -1945,7 +1945,7 @@ static struct qcom_cc_driver_data disp_cc_glymur_driver_data = {
.num_clk_cbcrs = ARRAY_SIZE(disp_cc_glymur_critical_cbcrs),
};
-static struct qcom_cc_desc disp_cc_glymur_desc = {
+static const struct qcom_cc_desc disp_cc_glymur_desc = {
.config = &disp_cc_glymur_regmap_config,
.clks = disp_cc_glymur_clocks,
.num_clks = ARRAY_SIZE(disp_cc_glymur_clocks),
---
base-commit: 65dd046ef55861190ecde44c6d9fcde54b9fb77d
change-id: 20250909-constify-dispcc-glymur-desc-fix-a3b615c8e146
Best regards,
--
Imran Shaik <imran.shaik@oss.qualcomm.com>
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] clk: qcom: dispcc-glymur: Constify 'struct qcom_cc_desc'
2025-09-09 9:47 [PATCH] clk: qcom: dispcc-glymur: Constify 'struct qcom_cc_desc' Imran Shaik
@ 2025-09-09 11:14 ` Dmitry Baryshkov
2025-09-09 12:34 ` Krzysztof Kozlowski
2025-09-09 16:56 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2025-09-09 11:14 UTC (permalink / raw)
To: Imran Shaik
Cc: Bjorn Andersson, Michael Turquette, Stephen Boyd, Jagadeesh Kona,
linux-arm-msm, linux-clk, linux-kernel, Ajit Pandey, Taniya Das,
Krzysztof Kozlowski
On Tue, Sep 09, 2025 at 03:17:59PM +0530, Imran Shaik wrote:
> 'struct qcom_cc_desc' is passed to qcom_cc_map() and
> qcom_cc_really_probe() only as pointer to const, so make the memory
> const for safety.
>
> Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Imran Shaik <imran.shaik@oss.qualcomm.com>
> ---
> This commit is similar to [1].
>
> [1] https://lore.kernel.org/r/20250820124821.149141-2-krzysztof.kozlowski@linaro.org
> ---
> drivers/clk/qcom/dispcc-glymur.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] clk: qcom: dispcc-glymur: Constify 'struct qcom_cc_desc'
2025-09-09 9:47 [PATCH] clk: qcom: dispcc-glymur: Constify 'struct qcom_cc_desc' Imran Shaik
2025-09-09 11:14 ` Dmitry Baryshkov
@ 2025-09-09 12:34 ` Krzysztof Kozlowski
2025-09-09 16:56 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2025-09-09 12:34 UTC (permalink / raw)
To: Imran Shaik, Bjorn Andersson, Michael Turquette, Stephen Boyd
Cc: Jagadeesh Kona, linux-arm-msm, linux-clk, linux-kernel,
Ajit Pandey, Taniya Das
On 09/09/2025 11:47, Imran Shaik wrote:
> 'struct qcom_cc_desc' is passed to qcom_cc_map() and
> qcom_cc_really_probe() only as pointer to const, so make the memory
> const for safety.
>
> Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Imran Shaik <imran.shaik@oss.qualcomm.com>
> ---
> This commit is similar to [1].
>
> [1] https://lore.kernel.org/r/20250820124821.149141-2-krzysztof.kozlowski@linaro.org
> ---
> drivers/clk/qcom/dispcc-glymur.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Uh, people need to stop copying downstream drivers.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] clk: qcom: dispcc-glymur: Constify 'struct qcom_cc_desc'
2025-09-09 9:47 [PATCH] clk: qcom: dispcc-glymur: Constify 'struct qcom_cc_desc' Imran Shaik
2025-09-09 11:14 ` Dmitry Baryshkov
2025-09-09 12:34 ` Krzysztof Kozlowski
@ 2025-09-09 16:56 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2025-09-09 16:56 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd, Imran Shaik
Cc: Jagadeesh Kona, linux-arm-msm, linux-clk, linux-kernel,
Ajit Pandey, Taniya Das, Krzysztof Kozlowski
On Tue, 09 Sep 2025 15:17:59 +0530, Imran Shaik wrote:
> 'struct qcom_cc_desc' is passed to qcom_cc_map() and
> qcom_cc_really_probe() only as pointer to const, so make the memory
> const for safety.
>
>
Applied, thanks!
[1/1] clk: qcom: dispcc-glymur: Constify 'struct qcom_cc_desc'
commit: 9ff39b0468c3e04fee05d4e005d2fc03d28b1538
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-09-09 16:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-09 9:47 [PATCH] clk: qcom: dispcc-glymur: Constify 'struct qcom_cc_desc' Imran Shaik
2025-09-09 11:14 ` Dmitry Baryshkov
2025-09-09 12:34 ` Krzysztof Kozlowski
2025-09-09 16:56 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox