From: "Andrew Jeffery" <andrew@aj.id.au>
To: "Ulf Hansson" <ulf.hansson@linaro.org>,
"Eddie James" <eajames@linux.ibm.com>
Cc: linux-clk <linux-clk@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
linux-aspeed <linux-aspeed@lists.ozlabs.org>,
linux-mmc <linux-mmc@vger.kernel.org>,
"Joel Stanley" <joel@jms.id.au>,
"Adrian Hunter" <adrian.hunter@intel.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"Michael Turquette" <mturquette@baylibre.com>
Subject: Re: [PATCH 2/2] mmc: sdhci-of-aspeed: Fix clock divider calculation
Date: Fri, 10 Jul 2020 18:30:11 +0930 [thread overview]
Message-ID: <d8b93dcd-37d8-49c0-9cad-2879e8cb9cc5@beta.fastmail.com> (raw)
In-Reply-To: <CAPDyKFozpWKt=L_hMh4ymhJ1X+TSK0vUQ5E0vy7j9EowTRywxQ@mail.gmail.com>
On Fri, 10 Jul 2020, at 17:09, Ulf Hansson wrote:
> On Thu, 9 Jul 2020 at 21:57, Eddie James <eajames@linux.ibm.com> wrote:
> >
> > When calculating the clock divider, start dividing at 2 instead of 1.
> > The divider is divided by two at the end of the calculation, so starting
> > at 1 may result in a divider of 0, which shouldn't happen.
> >
> > Signed-off-by: Eddie James <eajames@linux.ibm.com>
>
> Looks like I can pick this for fixes, as a standalone fix without patch1? No?
Yes, please do.
Thanks,
Andrew
next prev parent reply other threads:[~2020-07-10 9:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 19:57 [PATCH 0/2] clk: Aspeed: Fix eMMC clock speeds Eddie James
2020-07-09 19:57 ` [PATCH 1/2] clk: AST2600: Add mux for EMMC clock Eddie James
2020-07-10 3:03 ` Joel Stanley
2020-07-11 16:16 ` Stephen Boyd
2020-07-09 19:57 ` [PATCH 2/2] mmc: sdhci-of-aspeed: Fix clock divider calculation Eddie James
2020-07-10 1:13 ` Andrew Jeffery
2020-07-10 3:04 ` Joel Stanley
2020-07-10 6:41 ` Adrian Hunter
2020-07-10 7:39 ` Ulf Hansson
2020-07-10 9:00 ` Andrew Jeffery [this message]
2020-07-10 9:27 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8b93dcd-37d8-49c0-9cad-2879e8cb9cc5@beta.fastmail.com \
--to=andrew@aj.id.au \
--cc=adrian.hunter@intel.com \
--cc=eajames@linux.ibm.com \
--cc=joel@jms.id.au \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox