[PATCH 1/2] clk: qcom: gcc-kaanapali: Fix double array initializer

[PATCH 1/2] clk: qcom: gcc-kaanapali: Fix double array initializer

[Krzysztof Kozlowski]

[GCC_QMIP_VIDEO_VCODEC_AHB_CLK] element in clk_regmap array is already
initialized, as reported by W=1 clang warning:

  gcc-kaanapali.c:3383:36: error: initializer overrides prior initialization of this subobject [-Werror,-Winitializer-overrides]

Fixes: d1919c375f21 ("clk: qcom: Add support for Global clock controller on Kaanapali")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

---

Does anyone even build this code before sending it to upstream?
---
 drivers/clk/qcom/gcc-kaanapali.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/clk/qcom/gcc-kaanapali.c b/drivers/clk/qcom/gcc-kaanapali.c
index 182b152df14c..b9743284927d 100644
--- a/drivers/clk/qcom/gcc-kaanapali.c
+++ b/drivers/clk/qcom/gcc-kaanapali.c
@@ -3380,7 +3380,6 @@ static struct clk_regmap *gcc_kaanapali_clocks[] = {
 	[GCC_QMIP_VIDEO_CV_CPU_AHB_CLK] = &gcc_qmip_video_cv_cpu_ahb_clk.clkr,
 	[GCC_QMIP_VIDEO_CVP_AHB_CLK] = &gcc_qmip_video_cvp_ahb_clk.clkr,
 	[GCC_QMIP_VIDEO_V_CPU_AHB_CLK] = &gcc_qmip_video_v_cpu_ahb_clk.clkr,
-	[GCC_QMIP_VIDEO_VCODEC_AHB_CLK] = &gcc_qmip_video_vcodec_ahb_clk.clkr,
 };
 
 static struct gdsc *gcc_kaanapali_gdscs[] = {
-- 
2.51.0

[PATCH 2/2] clk: qcom: rpmh: Fix double array initializer on Kaanapali

[Krzysztof Kozlowski]

[RPMH_RF_CLK4] and [RPMH_RF_CLK5_A] elements in clk_hw array are already
initialized, as reported by W=1 clang warning:

  clk-rpmh.c:932:20: error: initializer overrides prior initialization of this subobject [-Werror,-Winitializer-overrides]
  clk-rpmh.c:934:21: error: initializer overrides prior initialization of this subobject [-Werror,-Winitializer-overrides]

Fixes: acabfd13859d ("clk: qcom: rpmh: Add support for Kaanapali rpmh clocks")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
 drivers/clk/qcom/clk-rpmh.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c
index 10e84ada48ee..547729b1a8ee 100644
--- a/drivers/clk/qcom/clk-rpmh.c
+++ b/drivers/clk/qcom/clk-rpmh.c
@@ -929,8 +929,8 @@ static struct clk_hw *kaanapali_rpmh_clocks[] = {
 	[RPMH_RF_CLK3]		= &clk_rpmh_clk3_a2_e0.hw,
 	[RPMH_RF_CLK3_A]	= &clk_rpmh_clk3_a2_e0_ao.hw,
 	[RPMH_RF_CLK4]		= &clk_rpmh_clk4_a2_e0.hw,
-	[RPMH_RF_CLK4]		= &clk_rpmh_clk4_a2_e0_ao.hw,
-	[RPMH_RF_CLK5_A]	= &clk_rpmh_clk5_a2_e0.hw,
+	[RPMH_RF_CLK4_A]	= &clk_rpmh_clk4_a2_e0_ao.hw,
+	[RPMH_RF_CLK5]		= &clk_rpmh_clk5_a2_e0.hw,
 	[RPMH_RF_CLK5_A]	= &clk_rpmh_clk5_a2_e0_ao.hw,
 	[RPMH_IPA_CLK]		= &clk_rpmh_ipa.hw,
 };
-- 
2.51.0

Re: [PATCH 2/2] clk: qcom: rpmh: Fix double array initializer on Kaanapali

[Dmitry Baryshkov]

On Wed, Dec 24, 2025 at 12:22:59PM +0100, Krzysztof Kozlowski wrote:
> [RPMH_RF_CLK4] and [RPMH_RF_CLK5_A] elements in clk_hw array are already
> initialized, as reported by W=1 clang warning:
> 
>   clk-rpmh.c:932:20: error: initializer overrides prior initialization of this subobject [-Werror,-Winitializer-overrides]
>   clk-rpmh.c:934:21: error: initializer overrides prior initialization of this subobject [-Werror,-Winitializer-overrides]
> 
> Fixes: acabfd13859d ("clk: qcom: rpmh: Add support for Kaanapali rpmh clocks")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> ---
>  drivers/clk/qcom/clk-rpmh.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>


-- 
With best wishes
Dmitry

Re: [PATCH 2/2] clk: qcom: rpmh: Fix double array initializer on Kaanapali

[Konrad Dybcio]

On 12/24/25 12:22 PM, Krzysztof Kozlowski wrote:
> [RPMH_RF_CLK4] and [RPMH_RF_CLK5_A] elements in clk_hw array are already
> initialized, as reported by W=1 clang warning:
> 
>   clk-rpmh.c:932:20: error: initializer overrides prior initialization of this subobject [-Werror,-Winitializer-overrides]
>   clk-rpmh.c:934:21: error: initializer overrides prior initialization of this subobject [-Werror,-Winitializer-overrides]
> 
> Fixes: acabfd13859d ("clk: qcom: rpmh: Add support for Kaanapali rpmh clocks")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

Re: [PATCH 2/2] clk: qcom: rpmh: Fix double array initializer on Kaanapali

[Abel Vesa]

On 25-12-24 12:22:59, Krzysztof Kozlowski wrote:
> [RPMH_RF_CLK4] and [RPMH_RF_CLK5_A] elements in clk_hw array are already
> initialized, as reported by W=1 clang warning:
> 
>   clk-rpmh.c:932:20: error: initializer overrides prior initialization of this subobject [-Werror,-Winitializer-overrides]
>   clk-rpmh.c:934:21: error: initializer overrides prior initialization of this subobject [-Werror,-Winitializer-overrides]
> 
> Fixes: acabfd13859d ("clk: qcom: rpmh: Add support for Kaanapali rpmh clocks")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>

Re: [PATCH 1/2] clk: qcom: gcc-kaanapali: Fix double array initializer

[Dmitry Baryshkov]

On Wed, Dec 24, 2025 at 12:22:58PM +0100, Krzysztof Kozlowski wrote:
> [GCC_QMIP_VIDEO_VCODEC_AHB_CLK] element in clk_regmap array is already
> initialized, as reported by W=1 clang warning:
> 
>   gcc-kaanapali.c:3383:36: error: initializer overrides prior initialization of this subobject [-Werror,-Winitializer-overrides]
> 
> Fixes: d1919c375f21 ("clk: qcom: Add support for Global clock controller on Kaanapali")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> 
> ---
> 
> Does anyone even build this code before sending it to upstream?
> ---
>  drivers/clk/qcom/gcc-kaanapali.c | 1 -
>  1 file changed, 1 deletion(-)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>


-- 
With best wishes
Dmitry

Re: [PATCH 1/2] clk: qcom: gcc-kaanapali: Fix double array initializer

[Konrad Dybcio]

On 12/24/25 12:22 PM, Krzysztof Kozlowski wrote:
> [GCC_QMIP_VIDEO_VCODEC_AHB_CLK] element in clk_regmap array is already
> initialized, as reported by W=1 clang warning:
> 
>   gcc-kaanapali.c:3383:36: error: initializer overrides prior initialization of this subobject [-Werror,-Winitializer-overrides]
> 
> Fixes: d1919c375f21 ("clk: qcom: Add support for Global clock controller on Kaanapali")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> 
> ---

Too bad this warning isn't enabled by default

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

Re: [PATCH 1/2] clk: qcom: gcc-kaanapali: Fix double array initializer

[Abel Vesa]

On 25-12-24 12:22:58, Krzysztof Kozlowski wrote:
> [GCC_QMIP_VIDEO_VCODEC_AHB_CLK] element in clk_regmap array is already
> initialized, as reported by W=1 clang warning:
> 
>   gcc-kaanapali.c:3383:36: error: initializer overrides prior initialization of this subobject [-Werror,-Winitializer-overrides]
> 
> Fixes: d1919c375f21 ("clk: qcom: Add support for Global clock controller on Kaanapali")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>

Re: [PATCH 1/2] clk: qcom: gcc-kaanapali: Fix double array initializer

[Bjorn Andersson]

On Wed, Dec 24, 2025 at 12:22:58PM +0100, Krzysztof Kozlowski wrote:
> [GCC_QMIP_VIDEO_VCODEC_AHB_CLK] element in clk_regmap array is already
> initialized, as reported by W=1 clang warning:
> 
>   gcc-kaanapali.c:3383:36: error: initializer overrides prior initialization of this subobject [-Werror,-Winitializer-overrides]
> 
> Fixes: d1919c375f21 ("clk: qcom: Add support for Global clock controller on Kaanapali")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> 
> ---
> 
> Does anyone even build this code before sending it to upstream?

It hope the author does...but I of couse sanity check the result through
an allmodconfig build across a few different architectures before
pushing.

But it seems passing '--environment "W=1"' to tuxmake doesn't actually
enable these warnings :(

Thanks for the report, and the fixes.

Regards,
Bjorn

> ---
>  drivers/clk/qcom/gcc-kaanapali.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/clk/qcom/gcc-kaanapali.c b/drivers/clk/qcom/gcc-kaanapali.c
> index 182b152df14c..b9743284927d 100644
> --- a/drivers/clk/qcom/gcc-kaanapali.c
> +++ b/drivers/clk/qcom/gcc-kaanapali.c
> @@ -3380,7 +3380,6 @@ static struct clk_regmap *gcc_kaanapali_clocks[] = {
>  	[GCC_QMIP_VIDEO_CV_CPU_AHB_CLK] = &gcc_qmip_video_cv_cpu_ahb_clk.clkr,
>  	[GCC_QMIP_VIDEO_CVP_AHB_CLK] = &gcc_qmip_video_cvp_ahb_clk.clkr,
>  	[GCC_QMIP_VIDEO_V_CPU_AHB_CLK] = &gcc_qmip_video_v_cpu_ahb_clk.clkr,
> -	[GCC_QMIP_VIDEO_VCODEC_AHB_CLK] = &gcc_qmip_video_vcodec_ahb_clk.clkr,
>  };
>  
>  static struct gdsc *gcc_kaanapali_gdscs[] = {
> -- 
> 2.51.0
> 

Re: [PATCH 1/2] clk: qcom: gcc-kaanapali: Fix double array initializer

[Bjorn Andersson]

On Fri, Jan 02, 2026 at 03:10:10PM -0600, Bjorn Andersson wrote:
> On Wed, Dec 24, 2025 at 12:22:58PM +0100, Krzysztof Kozlowski wrote:
> > [GCC_QMIP_VIDEO_VCODEC_AHB_CLK] element in clk_regmap array is already
> > initialized, as reported by W=1 clang warning:
> > 
> >   gcc-kaanapali.c:3383:36: error: initializer overrides prior initialization of this subobject [-Werror,-Winitializer-overrides]
> > 
> > Fixes: d1919c375f21 ("clk: qcom: Add support for Global clock controller on Kaanapali")
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> > 
> > ---
> > 
> > Does anyone even build this code before sending it to upstream?
> 
> It hope the author does...but I of couse sanity check the result through
> an allmodconfig build across a few different architectures before
> pushing.
> 
> But it seems passing '--environment "W=1"' to tuxmake doesn't actually
> enable these warnings :(
> 

Realized that W=1 should be passed as a build target, not through
environment.

Do you have any sensible post-processing tools/steps that you could
share to make the output usable?

Regards,
Bjorn

> Thanks for the report, and the fixes.
> 
> Regards,
> Bjorn
> 
> > ---
> >  drivers/clk/qcom/gcc-kaanapali.c | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/drivers/clk/qcom/gcc-kaanapali.c b/drivers/clk/qcom/gcc-kaanapali.c
> > index 182b152df14c..b9743284927d 100644
> > --- a/drivers/clk/qcom/gcc-kaanapali.c
> > +++ b/drivers/clk/qcom/gcc-kaanapali.c
> > @@ -3380,7 +3380,6 @@ static struct clk_regmap *gcc_kaanapali_clocks[] = {
> >  	[GCC_QMIP_VIDEO_CV_CPU_AHB_CLK] = &gcc_qmip_video_cv_cpu_ahb_clk.clkr,
> >  	[GCC_QMIP_VIDEO_CVP_AHB_CLK] = &gcc_qmip_video_cvp_ahb_clk.clkr,
> >  	[GCC_QMIP_VIDEO_V_CPU_AHB_CLK] = &gcc_qmip_video_v_cpu_ahb_clk.clkr,
> > -	[GCC_QMIP_VIDEO_VCODEC_AHB_CLK] = &gcc_qmip_video_vcodec_ahb_clk.clkr,
> >  };
> >  
> >  static struct gdsc *gcc_kaanapali_gdscs[] = {
> > -- 
> > 2.51.0
> > 

Re: (subset) [PATCH 1/2] clk: qcom: gcc-kaanapali: Fix double array initializer

[Bjorn Andersson]

On Wed, 24 Dec 2025 12:22:58 +0100, Krzysztof Kozlowski wrote:
> [GCC_QMIP_VIDEO_VCODEC_AHB_CLK] element in clk_regmap array is already
> initialized, as reported by W=1 clang warning:
> 
>   gcc-kaanapali.c:3383:36: error: initializer overrides prior initialization of this subobject [-Werror,-Winitializer-overrides]
> 
> 

Applied, thanks!

[1/2] clk: qcom: gcc-kaanapali: Fix double array initializer
      commit: e77ff7d32b2029851a3567f1ccf7ab9db5cfa137
[2/2] clk: qcom: rpmh: Fix double array initializer on Kaanapali
      commit: bb466f234f2cfeea1c65b2d777ed878ee783b3ba

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>