From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Taniya Das <quic_tdas@quicinc.com>
Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 13/15] arm64: dts: qcom: qcs404: use symbol names for PCIe resets
Date: Sat, 17 Dec 2022 16:16:32 +0100 [thread overview]
Message-ID: <e1f62ee3-eeac-cf69-a990-566b8d0eeae1@linaro.org> (raw)
In-Reply-To: <20221217001730.540502-14-dmitry.baryshkov@linaro.org>
On 17.12.2022 01:17, Dmitry Baryshkov wrote:
> The commit e5bbbff5b7d7 ("clk: gcc-qcs404: Add PCIe resets") added names
> for PCIe resets, but it did not change the existing qcs404.dtsi to use
> these names. Do it now and use symbol names to make it easier to check
> and modify the dtsi in future.
>
> Fixes: e5bbbff5b7d7 ("clk: gcc-qcs404: Add PCIe resets")
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
I feel like I reviewed this already this week..
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/qcs404.dtsi | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qcom/qcs404.dtsi
> index ffffaa7507cf..ffc4b081bb62 100644
> --- a/arch/arm64/boot/dts/qcom/qcs404.dtsi
> +++ b/arch/arm64/boot/dts/qcom/qcs404.dtsi
> @@ -806,7 +806,7 @@ pcie_phy: phy@7786000 {
>
> clocks = <&gcc GCC_PCIE_0_PIPE_CLK>;
> resets = <&gcc GCC_PCIEPHY_0_PHY_BCR>,
> - <&gcc 21>;
> + <&gcc GCC_PCIE_0_PIPE_ARES>;
> reset-names = "phy", "pipe";
>
> clock-output-names = "pcie_0_pipe_clk";
> @@ -1337,12 +1337,12 @@ pcie: pci@10000000 {
> <&gcc GCC_PCIE_0_SLV_AXI_CLK>;
> clock-names = "iface", "aux", "master_bus", "slave_bus";
>
> - resets = <&gcc 18>,
> - <&gcc 17>,
> - <&gcc 15>,
> - <&gcc 19>,
> + resets = <&gcc GCC_PCIE_0_AXI_MASTER_ARES>,
> + <&gcc GCC_PCIE_0_AXI_SLAVE_ARES>,
> + <&gcc GCC_PCIE_0_AXI_MASTER_STICKY_ARES>,
> + <&gcc GCC_PCIE_0_CORE_STICKY_ARES>,
> <&gcc GCC_PCIE_0_BCR>,
> - <&gcc 16>;
> + <&gcc GCC_PCIE_0_AHB_ARES>;
> reset-names = "axi_m",
> "axi_s",
> "axi_m_sticky",
next prev parent reply other threads:[~2022-12-17 15:16 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-17 0:17 [PATCH 00/15] clk: qcom: gcc-qcs404: convert to parent_data Dmitry Baryshkov
2022-12-17 0:17 ` [PATCH 01/15] dt-bindings: clock: qcom: gcc-qcs404: add two GDSC entries Dmitry Baryshkov
2022-12-19 9:13 ` Krzysztof Kozlowski
2022-12-17 0:17 ` [PATCH 02/15] dt-bindings: clock: qcom: gcc-qcs404: switch to gcc.yaml Dmitry Baryshkov
2022-12-19 9:13 ` Krzysztof Kozlowski
2022-12-17 0:17 ` [PATCH 03/15] dt-bindings: clock: qcom: gcc-qcs404: define clocks/clock-names for QCS404 Dmitry Baryshkov
2022-12-19 9:14 ` Krzysztof Kozlowski
2022-12-17 0:17 ` [PATCH 04/15] clk: qcom: gcc-qcs404: use ARRAY_SIZE instead of specifying num_parents Dmitry Baryshkov
2022-12-17 15:07 ` Konrad Dybcio
2022-12-17 0:17 ` [PATCH 05/15] clk: qcom: gcc-qcs404: disable gpll[04]_out_aux parents Dmitry Baryshkov
2022-12-17 15:08 ` Konrad Dybcio
2022-12-17 17:54 ` Dmitry Baryshkov
2022-12-17 0:17 ` [PATCH 06/15] clk: qcom: gcc-qcs404: fix names of the DSI clocks used as parents Dmitry Baryshkov
2022-12-17 15:08 ` Konrad Dybcio
2022-12-17 0:17 ` [PATCH 07/15] clk: qcom: gcc-qcs404: fix the name of the HDMI PLL clock Dmitry Baryshkov
2022-12-17 15:09 ` Konrad Dybcio
2022-12-17 0:17 ` [PATCH 08/15] clk: qcom: gcc-qcs404: get rid of the test clock Dmitry Baryshkov
2022-12-17 15:09 ` Konrad Dybcio
2022-12-17 0:17 ` [PATCH 09/15] clk: qcom: gcc-qcs404: move PLL clocks up Dmitry Baryshkov
2022-12-17 15:10 ` Konrad Dybcio
2022-12-17 0:17 ` [PATCH 10/15] clk: qcom: gcc-qcs404: use parent_hws/_data instead of parent_names Dmitry Baryshkov
2022-12-17 15:13 ` Konrad Dybcio
2022-12-17 15:14 ` Konrad Dybcio
2022-12-17 17:56 ` Dmitry Baryshkov
2022-12-17 0:17 ` [PATCH 11/15] clk: qcom: gcc-qcs404: sort out the cxo clock Dmitry Baryshkov
2022-12-17 15:15 ` Konrad Dybcio
2022-12-17 0:17 ` [PATCH 12/15] clk: qcom: gcc-qcs404: add support for GDSCs Dmitry Baryshkov
2022-12-17 15:15 ` Konrad Dybcio
2022-12-17 0:17 ` [PATCH 13/15] arm64: dts: qcom: qcs404: use symbol names for PCIe resets Dmitry Baryshkov
2022-12-17 15:16 ` Konrad Dybcio [this message]
2022-12-17 0:17 ` [PATCH 14/15] arm64: dts: qcom: qcs404: add power-domains-cells to gcc node Dmitry Baryshkov
2022-12-17 15:16 ` Konrad Dybcio
2022-12-17 0:17 ` [PATCH 15/15] arm64: dts: qcom: qcs404: add clocks to the " Dmitry Baryshkov
2022-12-17 15:17 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1f62ee3-eeac-cf69-a990-566b8d0eeae1@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_tdas@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox