Linux clock framework development
 help / color / mirror / Atom feed
* [PATCH] clk: versaclock3: Switch to use i2c_driver's probe callback
@ 2023-07-21  7:18 Uwe Kleine-König
  2023-07-31  8:18 ` Uwe Kleine-König
  2023-08-01 20:36 ` Stephen Boyd
  0 siblings, 2 replies; 4+ messages in thread
From: Uwe Kleine-König @ 2023-07-21  7:18 UTC (permalink / raw)
  To: Stephen Boyd; +Cc: Michael Turquette, linux-clk, Biju Das, kernel

The previous mass switch of clk drivers done in commit 62279db5a323
("clk: Switch i2c drivers back to use .probe()") was based on v6.4-rc1
Since then this driver was added which needs to be converted back in the
same way before eventually .probe_new() can be dropped from struct
i2c_driver.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
Hello,

this driver appeared in next today. It would be great if this patch
could be added on top to not interfere with the quest to remove
.probe_new directly after v6.6-rc1.

Thanks
Uwe

 drivers/clk/clk-versaclock3.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/clk-versaclock3.c b/drivers/clk/clk-versaclock3.c
index 4ceb7fcf7fcb..7ab2447bd203 100644
--- a/drivers/clk/clk-versaclock3.c
+++ b/drivers/clk/clk-versaclock3.c
@@ -1134,7 +1134,7 @@ static struct i2c_driver vc3_driver = {
 		.name = "vc3",
 		.of_match_table = of_match_ptr(dev_ids),
 	},
-	.probe_new = vc3_probe,
+	.probe = vc3_probe,
 };
 module_i2c_driver(vc3_driver);
 

base-commit: 6e9aff555db7b6816076121ac3feebc3006de9ad
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] clk: versaclock3: Switch to use i2c_driver's probe callback
  2023-07-21  7:18 [PATCH] clk: versaclock3: Switch to use i2c_driver's probe callback Uwe Kleine-König
@ 2023-07-31  8:18 ` Uwe Kleine-König
  2023-08-01 20:38   ` Stephen Boyd
  2023-08-01 20:36 ` Stephen Boyd
  1 sibling, 1 reply; 4+ messages in thread
From: Uwe Kleine-König @ 2023-07-31  8:18 UTC (permalink / raw)
  To: Stephen Boyd; +Cc: Biju Das, Michael Turquette, linux-clk, kernel, Wolfram Sang

[-- Attachment #1: Type: text/plain, Size: 1789 bytes --]

Hello,

[Cc: += Wolfram]

On Fri, Jul 21, 2023 at 09:18:46AM +0200, Uwe Kleine-König wrote:
> The previous mass switch of clk drivers done in commit 62279db5a323
> ("clk: Switch i2c drivers back to use .probe()") was based on v6.4-rc1
> Since then this driver was added which needs to be converted back in the
> same way before eventually .probe_new() can be dropped from struct
> i2c_driver.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Hello,
> 
> this driver appeared in next today. It would be great if this patch
> could be added on top to not interfere with the quest to remove
> .probe_new directly after v6.6-rc1.

my eventual plan is to send the patch removing .probe_new() around
v6.6-rc1 with the intention to get it into next early during the merge
window. So if this patch doesn't make it in before v6.6-rc1, I'd send it
together with the change dropping .probe_new() for Wolfram to apply as
in today's next-20230731 there are only two drivers left making use of
.probe_new (and the maintainer of the other driver already agreed to fix
their driver with a patch going in via i2c, too).

So in my order of preference, the options here are:

 - patch is applied via clk before v6.6-rc1
 - patch is applied via i2c together with change dropping .probe_new()
   with a clk maintainer's Ack.
 - patch is ignored and goes in without an Ack via i2c.

My current WIP branch based on v6.5-rc4 is available at

	https://git.pengutronix.de/git/ukl/linux i2c-probe-new

if you want to take a look. (And even if you don't want, it's there :-)

Thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] clk: versaclock3: Switch to use i2c_driver's probe callback
  2023-07-21  7:18 [PATCH] clk: versaclock3: Switch to use i2c_driver's probe callback Uwe Kleine-König
  2023-07-31  8:18 ` Uwe Kleine-König
@ 2023-08-01 20:36 ` Stephen Boyd
  1 sibling, 0 replies; 4+ messages in thread
From: Stephen Boyd @ 2023-08-01 20:36 UTC (permalink / raw)
  To: Uwe Kleine-König; +Cc: Michael Turquette, linux-clk, Biju Das, kernel

Quoting Uwe Kleine-König (2023-07-21 00:18:46)
> The previous mass switch of clk drivers done in commit 62279db5a323
> ("clk: Switch i2c drivers back to use .probe()") was based on v6.4-rc1
> Since then this driver was added which needs to be converted back in the
> same way before eventually .probe_new() can be dropped from struct
> i2c_driver.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---

Applied to clk-next

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] clk: versaclock3: Switch to use i2c_driver's probe callback
  2023-07-31  8:18 ` Uwe Kleine-König
@ 2023-08-01 20:38   ` Stephen Boyd
  0 siblings, 0 replies; 4+ messages in thread
From: Stephen Boyd @ 2023-08-01 20:38 UTC (permalink / raw)
  To: Uwe Kleine-König
  Cc: Biju Das, Michael Turquette, linux-clk, kernel, Wolfram Sang

Quoting Uwe Kleine-König (2023-07-31 01:18:03)
> > Hello,
> > 
> > this driver appeared in next today. It would be great if this patch
> > could be added on top to not interfere with the quest to remove
> > .probe_new directly after v6.6-rc1.
> 
> my eventual plan is to send the patch removing .probe_new() around
> v6.6-rc1 with the intention to get it into next early during the merge
> window. So if this patch doesn't make it in before v6.6-rc1, I'd send it
> together with the change dropping .probe_new() for Wolfram to apply as
> in today's next-20230731 there are only two drivers left making use of
> .probe_new (and the maintainer of the other driver already agreed to fix
> their driver with a patch going in via i2c, too).
> 
> So in my order of preference, the options here are:
> 
>  - patch is applied via clk before v6.6-rc1

This option is now the plan.

>  - patch is applied via i2c together with change dropping .probe_new()
>    with a clk maintainer's Ack.
>  - patch is ignored and goes in without an Ack via i2c.
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-08-01 20:38 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-21  7:18 [PATCH] clk: versaclock3: Switch to use i2c_driver's probe callback Uwe Kleine-König
2023-07-31  8:18 ` Uwe Kleine-König
2023-08-01 20:38   ` Stephen Boyd
2023-08-01 20:36 ` Stephen Boyd

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox