* [PATCH] clk: hi3620: Fix memory leak in hi3620_mmc_clk_init()
@ 2023-12-10 16:50 Kuan-Wei Chiu
2023-12-17 1:13 ` Stephen Boyd
0 siblings, 1 reply; 2+ messages in thread
From: Kuan-Wei Chiu @ 2023-12-10 16:50 UTC (permalink / raw)
To: mturquette, sboyd
Cc: robh, abel.vesa, dinguyen, linux-clk, linux-kernel, Kuan-Wei Chiu
In cases where kcalloc() fails for the 'clk_data->clks' allocation, the
code path does not handle the failure gracefully, potentially leading
to a memory leak. This fix ensures proper cleanup by freeing the
allocated memory for 'clk_data' before returning.
Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>
---
drivers/clk/hisilicon/clk-hi3620.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/hisilicon/clk-hi3620.c b/drivers/clk/hisilicon/clk-hi3620.c
index 2d7186905abd..5d0226530fdb 100644
--- a/drivers/clk/hisilicon/clk-hi3620.c
+++ b/drivers/clk/hisilicon/clk-hi3620.c
@@ -466,8 +466,10 @@ static void __init hi3620_mmc_clk_init(struct device_node *node)
return;
clk_data->clks = kcalloc(num, sizeof(*clk_data->clks), GFP_KERNEL);
- if (!clk_data->clks)
+ if (!clk_data->clks) {
+ kfree(clk_data);
return;
+ }
for (i = 0; i < num; i++) {
struct hisi_mmc_clock *mmc_clk = &hi3620_mmc_clks[i];
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] clk: hi3620: Fix memory leak in hi3620_mmc_clk_init()
2023-12-10 16:50 [PATCH] clk: hi3620: Fix memory leak in hi3620_mmc_clk_init() Kuan-Wei Chiu
@ 2023-12-17 1:13 ` Stephen Boyd
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Boyd @ 2023-12-17 1:13 UTC (permalink / raw)
To: Kuan-Wei Chiu, mturquette
Cc: robh, abel.vesa, dinguyen, linux-clk, linux-kernel, Kuan-Wei Chiu
Quoting Kuan-Wei Chiu (2023-12-10 08:50:40)
> In cases where kcalloc() fails for the 'clk_data->clks' allocation, the
> code path does not handle the failure gracefully, potentially leading
> to a memory leak. This fix ensures proper cleanup by freeing the
> allocated memory for 'clk_data' before returning.
>
> Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-12-17 1:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-10 16:50 [PATCH] clk: hi3620: Fix memory leak in hi3620_mmc_clk_init() Kuan-Wei Chiu
2023-12-17 1:13 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox