From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: Luca Weiss <luca.weiss@fairphone.com>,
Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Danila Tikhonov <danila@jiaxyga.com>,
Taniya Das <taniya.das@oss.qualcomm.com>,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] clk: qcom: camcc-sm6350: Fix PLL config of PLL2
Date: Wed, 22 Oct 2025 17:19:42 +0200 [thread overview]
Message-ID: <f859d423-32b9-4aa1-8468-c2e9ef006669@oss.qualcomm.com> (raw)
In-Reply-To: <qanawqrk6izypwmmuvezzff37k66ptv2vlbdwxs62dqx7igop4@wzkz76376jli>
On 10/22/25 5:09 PM, Dmitry Baryshkov wrote:
> On Wed, Oct 22, 2025 at 01:19:16PM +0200, Konrad Dybcio wrote:
>> On 10/21/25 8:08 PM, Luca Weiss wrote:
>>> The 'Agera' PLLs (with clk_agera_pll_configure) do not take some of the
>>> parameters that are provided in the vendor driver. Instead the upstream
>>> configuration should provide the final user_ctl value that is written to
>>> the USER_CTL register.
>>
>> This is perhaps wishful thinking due to potential complexity, but maybe
>> we could add some sanity checks to make sure that putting things in
>> unused fields doesn't happen
>
> Should we just drop those fields and always write the register value?
They're used in other_kind_of_alpha_pll_configure.. and we have a lot
of drivers using either of these approaches, so converting that and
not breaking anything sounds a little difficult
Konrad
next prev parent reply other threads:[~2025-10-22 15:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-21 18:08 [PATCH 0/2] Fix Agera PLL config of CAMCC for SM6350 & SM7150 Luca Weiss
2025-10-21 18:08 ` [PATCH 1/2] clk: qcom: camcc-sm6350: Fix PLL config of PLL2 Luca Weiss
2025-10-22 6:37 ` Taniya Das
2025-10-22 9:07 ` Abel Vesa
2025-10-22 11:19 ` Konrad Dybcio
2025-10-22 15:09 ` Dmitry Baryshkov
2025-10-22 15:19 ` Konrad Dybcio [this message]
2025-10-21 18:08 ` [PATCH 2/2] clk: qcom: camcc-sm7150: " Luca Weiss
2025-10-22 6:37 ` Taniya Das
2025-10-22 9:08 ` Abel Vesa
2025-10-27 14:09 ` [PATCH 0/2] Fix Agera PLL config of CAMCC for SM6350 & SM7150 Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f859d423-32b9-4aa1-8468-c2e9ef006669@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=danila@jiaxyga.com \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=mturquette@baylibre.com \
--cc=phone-devel@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=taniya.das@oss.qualcomm.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox