* [PATCH 00/15] accel: Add AMD Versal AI Engine driver (with Versal Gen 2 firmware support)
@ 2026-11-18 23:31 Gregory Williams
2026-11-18 23:32 ` [PATCH 08/15] dt-bindings: clock: versal: add Versal Gen 2 compatible string Gregory Williams
2026-11-18 23:32 ` [PATCH 09/15] clk: zynqmp: Add " Gregory Williams
0 siblings, 2 replies; 4+ messages in thread
From: Gregory Williams @ 2026-11-18 23:31 UTC (permalink / raw)
Cc: Stephen Boyd, Brian Masney, Jerome Brunet, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Michal Simek, Oded Gabbay,
kishore Manne, Izhar Ameer Shaikh, Greg Kroah-Hartman,
Jay Buddhabhatti, Ronak Jain, linux-clk, devicetree, linux-kernel,
linux-arm-kernel, dri-devel
This series adds a driver for the AMD AI Engine (AIE) found on Versal
devices, together with the firmware changes the driver depends on. AI Engine
is a tile array based accelerator used for applications such as beamforming and
machine learning inference. Tiles are organised in columns, and groups of
columns form partitions that an application requests, initialises and releases.
Several registers in the AI Engine array (column and shim resets, memory
zeroisation, tile clock gating, NoC and interrupt routing) are privileged
and can only be written by the trusted firmware. The driver therefore
packs operations into a DMA buffer and hands it to the platform firmware,
which executes them in order.
Firmware patches included
-------------------------
Patches 1-10 are not part of the AI Engine driver itself, but the driver
cannot work without them, so they are included here to keep the series
self-contained and reviewable in one place:
- 1-5: zynqmp firmware driver refactoring and a va_start()/va_end()
fix (patch 2 carries Fixes: tags), preparing for the extended
SMCCC call format.
- 6-7: Versal Gen 2 compatible string and firmware support, where all
EEMI APIs use the extended SMCCC payload.
- 8-9: Versal Gen 2 clock binding and clk driver match entry.
- 10: firmware IOCTL support for the Versal Gen 2 AIE run time
operations, used by the driver.
I am happy to split out or reorder the firmware and clock patches if the
maintainers prefer to take them through their own trees, and would
appreciate guidance on how the series should be merged.
AI Engine driver
----------------
- 11: devicetree binding for the AI Engine.
- 12: driver core: device probe, partition request and release.
- 13: pm ops: building and sending firmware operation packets.
- 14: enabling and disabling tile clocks.
- 15: partition initialize and teardown (reset operations).
Previous submission
-------------------
This driver was posted for review a little over a year ago:
https://lore.kernel.org/dri-devel/20250702155630.1737227-1-gregory.williams@amd.com/
Since then the scope of what is proposed for upstream has changed, this series
is considerably different from that posting, in particular targeting only Versal
Gen 2 support. All comments received on the earlier posting have been addressed
or in this version.
Abhyuday Godhasara (1):
drivers: firmware: xilinx: Add IOCTL support for the AIE run time
operations
Gregory Williams (5):
dt-bindings: soc: xilinx: Add Versal AI Engine DT binding
accel/amd-ai-engine: Add AMD AI Engine device driver
accel/amd-ai-engine: Add pm ops for firmware calls
accel/amd-ai-engine: Add support to enable/disable tile clocks
accel/amd-ai-engine: Add reset operations
Naman Trivedi (1):
dt-bindings: clock: versal: add Versal Gen 2 compatible string
Senthil Nathan Thangaraj (8):
firmware: xilinx: Separate TF-A checking
firmware: xilinx: Call va_start after pm feature check
firmware: xilinx: Add comments about number of arguments
firmware: xilinx: Use match data for ZynqMP/Versal
firmware: xilinx: Rename zynqmp_pm_invoke_fw_fn()
dt-bindings: firmware: xilinx: Add Versal Gen 2 compatible string
firmware: xilinx: Add support for Versal Gen 2
clk: zynqmp: Add Versal Gen 2 compatible string
.../bindings/clock/xlnx,versal-clk.yaml | 5 +-
.../firmware/xilinx/xlnx,zynqmp-firmware.yaml | 3 +
.../bindings/soc/xilinx/xlnx,ai-engine.yaml | 61 +++
MAINTAINERS | 9 +
drivers/accel/Kconfig | 1 +
drivers/accel/Makefile | 3 +-
drivers/accel/amd-ai-engine/Kconfig | 15 +
drivers/accel/amd-ai-engine/Makefile | 14 +
.../accel/amd-ai-engine/ai-engine-aiemlv2.c | 441 ++++++++++++++++
drivers/accel/amd-ai-engine/ai-engine-clock.c | 154 ++++++
drivers/accel/amd-ai-engine/ai-engine-dev.c | 255 ++++++++++
.../accel/amd-ai-engine/ai-engine-internal.h | 377 ++++++++++++++
drivers/accel/amd-ai-engine/ai-engine-part.c | 140 ++++++
drivers/accel/amd-ai-engine/ai-engine-pm.c | 472 ++++++++++++++++++
drivers/accel/amd-ai-engine/ai-engine-res.c | 184 +++++++
drivers/accel/amd-ai-engine/ai-engine-reset.c | 69 +++
drivers/clk/zynqmp/clkc.c | 1 +
drivers/firmware/xilinx/zynqmp.c | 340 +++++++++++--
include/linux/amd-ai-engine.h | 115 +++++
include/linux/firmware/xlnx-zynqmp.h | 65 ++-
20 files changed, 2679 insertions(+), 45 deletions(-)
create mode 100644 Documentation/devicetree/bindings/soc/xilinx/xlnx,ai-engine.yaml
create mode 100644 drivers/accel/amd-ai-engine/Kconfig
create mode 100644 drivers/accel/amd-ai-engine/Makefile
create mode 100644 drivers/accel/amd-ai-engine/ai-engine-aiemlv2.c
create mode 100644 drivers/accel/amd-ai-engine/ai-engine-clock.c
create mode 100644 drivers/accel/amd-ai-engine/ai-engine-dev.c
create mode 100644 drivers/accel/amd-ai-engine/ai-engine-internal.h
create mode 100644 drivers/accel/amd-ai-engine/ai-engine-part.c
create mode 100644 drivers/accel/amd-ai-engine/ai-engine-pm.c
create mode 100644 drivers/accel/amd-ai-engine/ai-engine-res.c
create mode 100644 drivers/accel/amd-ai-engine/ai-engine-reset.c
create mode 100644 include/linux/amd-ai-engine.h
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 08/15] dt-bindings: clock: versal: add Versal Gen 2 compatible string
2026-11-18 23:31 [PATCH 00/15] accel: Add AMD Versal AI Engine driver (with Versal Gen 2 firmware support) Gregory Williams
@ 2026-11-18 23:32 ` Gregory Williams
2026-11-18 23:44 ` sashiko-bot
2026-11-18 23:32 ` [PATCH 09/15] clk: zynqmp: Add " Gregory Williams
1 sibling, 1 reply; 4+ messages in thread
From: Gregory Williams @ 2026-11-18 23:32 UTC (permalink / raw)
To: Stephen Boyd, Brian Masney, Jerome Brunet, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Michal Simek
Cc: Naman Trivedi, Senthil Nathan Thangaraj, linux-clk, devicetree,
linux-kernel
From: Naman Trivedi <naman.trivedimanojbhai@amd.com>
Add compatible string for Versal Gen 2 clock driver and validate
clock-names for xlnx,versal2-clk compatible.
Signed-off-by: Naman Trivedi <naman.trivedimanojbhai@amd.com>
Signed-off-by: Senthil Nathan Thangaraj <senthilnathan.thangaraj@amd.com>
---
Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml b/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml
index 1f36ccc4cde1..e06f1ebc192a 100644
--- a/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml
+++ b/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml
@@ -17,10 +17,13 @@ description: |
properties:
compatible:
oneOf:
- - const: xlnx,versal-clk
+ - enum:
+ - xlnx,versal-clk
+ - xlnx,versal2-clk
- items:
- enum:
- xlnx,versal-net-clk
+ - xlnx,versal2-clk
- const: xlnx,versal-clk
"#clock-cells":
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 09/15] clk: zynqmp: Add Versal Gen 2 compatible string
2026-11-18 23:31 [PATCH 00/15] accel: Add AMD Versal AI Engine driver (with Versal Gen 2 firmware support) Gregory Williams
2026-11-18 23:32 ` [PATCH 08/15] dt-bindings: clock: versal: add Versal Gen 2 compatible string Gregory Williams
@ 2026-11-18 23:32 ` Gregory Williams
1 sibling, 0 replies; 4+ messages in thread
From: Gregory Williams @ 2026-11-18 23:32 UTC (permalink / raw)
To: Stephen Boyd, Brian Masney, Jerome Brunet, Michal Simek
Cc: Senthil Nathan Thangaraj, linux-clk, linux-arm-kernel,
linux-kernel
From: Senthil Nathan Thangaraj <senthilnathan.thangaraj@amd.com>
The Versal Gen 2 PLM exposes its clocks through the same EEMI clock
API that ZynqMP and Versal use, so the existing zynqmp clock driver
already implements everything needed once it accepts the platform's
device-tree node.
Add the "xlnx,versal2-clk" compatible to the zynqmp_clock_of_match
table so the driver binds against Versal Gen 2 device trees in
addition to ZynqMP and Versal. No code changes are required beyond
the match-table entry; clock enumeration, gating and rate control
all reuse the existing implementation.
Signed-off-by: Senthil Nathan Thangaraj <senthilnathan.thangaraj@amd.com>
---
drivers/clk/zynqmp/clkc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/zynqmp/clkc.c b/drivers/clk/zynqmp/clkc.c
index d62f1901d0ab..ba8823e385e3 100644
--- a/drivers/clk/zynqmp/clkc.c
+++ b/drivers/clk/zynqmp/clkc.c
@@ -789,6 +789,7 @@ static int zynqmp_clock_probe(struct platform_device *pdev)
static const struct of_device_id zynqmp_clock_of_match[] = {
{.compatible = "xlnx,zynqmp-clk"},
{.compatible = "xlnx,versal-clk"},
+ {.compatible = "xlnx,versal2-clk"},
{},
};
MODULE_DEVICE_TABLE(of, zynqmp_clock_of_match);
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 08/15] dt-bindings: clock: versal: add Versal Gen 2 compatible string
2026-11-18 23:32 ` [PATCH 08/15] dt-bindings: clock: versal: add Versal Gen 2 compatible string Gregory Williams
@ 2026-11-18 23:44 ` sashiko-bot
0 siblings, 0 replies; 4+ messages in thread
From: sashiko-bot @ 2026-11-18 23:44 UTC (permalink / raw)
To: Gregory Williams; +Cc: linux-clk, devicetree, robh, conor+dt
Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Medium] dt-bindings: clock: versal: duplicate xlnx,versal2-clk in
compatible oneOf
- [Medium] dt-bindings: clock: versal: missing clock-names validation in
allOf block
--
commit fd8a0b655d481ee627fd749c39ad8be1171d696f
Author: Naman Trivedi <naman.trivedimanojbhai@amd.com>
dt-bindings: clock: versal: add Versal Gen 2 compatible string
This commit adds the xlnx,versal2-clk compatible string to the Xilinx
Versal clock controller DT binding schema.
> Add compatible string for Versal Gen 2 clock driver and validate
> clock-names for xlnx,versal2-clk compatible.
[Severity: Medium]
Does this patch actually update the clock-names validation for
xlnx,versal2-clk?
The commit message says it validates clock-names for xlnx,versal2-clk, but
the allOf conditional block in xlnx,versal-clk.yaml only checks for
xlnx,versal-net-clk:
Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml {
...
allOf:
- if:
properties:
compatible:
contains:
enum:
- xlnx,versal-net-clk
then:
properties:
clocks:
minItems: 3
clock-names:
minItems: 3
else:
properties:
clocks:
maxItems: 2
clock-names:
maxItems: 2
...
}
Because xlnx,versal2-clk is not added to that enum, it falls into the else
branch (maxItems: 2), which will fail dtbs_check if Versal Gen 2 specifies
all three input clocks (ref, pl_alt_ref, alt_ref) like Versal NET.
> diff --git a/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml b/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml
> index 1f36ccc4cde1d..e06f1ebc192ab 100644
> --- a/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml
> +++ b/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml
> @@ -17,10 +17,13 @@ description: |
> properties:
> compatible:
> oneOf:
> - - const: xlnx,versal-clk
> + - enum:
> + - xlnx,versal-clk
> + - xlnx,versal2-clk
> - items:
> - enum:
> - xlnx,versal-net-clk
> + - xlnx,versal2-clk
> - const: xlnx,versal-clk
[Severity: Medium]
Should xlnx,versal2-clk be listed in only one branch of compatible.oneOf?
Adding xlnx,versal2-clk to both branches permits it both as a standalone
compatible string without a fallback and with the xlnx,versal-clk
fallback. Also, at this point in the series (prior to commit "clk:
zynqmp: add compatible string for Versal Gen 2"), zynqmp_clock_of_match[]
in drivers/clk/zynqmp/clkc.c only matches xlnx,zynqmp-clk and
xlnx,versal-clk. It looks like the addition under xlnx,versal-net-clk may
have been intended for the allOf block below.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261118233211.4121361-1-gregory.williams@amd.com?part=8
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-11-18 23:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-18 23:31 [PATCH 00/15] accel: Add AMD Versal AI Engine driver (with Versal Gen 2 firmware support) Gregory Williams
2026-11-18 23:32 ` [PATCH 08/15] dt-bindings: clock: versal: add Versal Gen 2 compatible string Gregory Williams
2026-11-18 23:44 ` sashiko-bot
2026-11-18 23:32 ` [PATCH 09/15] clk: zynqmp: Add " Gregory Williams
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox