Linux clock framework development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Krzysztof Kozlowski" <krzysztof.kozlowski@oss.qualcomm.com>
Cc: linux-clk@vger.kernel.org
Subject: Re: [PATCH 2/4] clk: qcom: Consistently enable MSM8939, MDM9615, SAR2130P and SDX65
Date: Sun, 22 Nov 2026 13:20:27 +0000	[thread overview]
Message-ID: <sashiko-outbox-227960@kernel.org> (raw)
In-Reply-To: <20261122-qcom-kconfig-unify-v1-2-6abaa7faf1c9@oss.qualcomm.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] clk: qcom: SAR_GCC_2130P and SAR_GPUCC_2130P enabled by
  default on 32-bit ARM
--

commit 26558b027ddd75e632c3e98cf03a0b97873008a1
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

clk: qcom: Consistently enable MSM8939, MDM9615, SAR2130P and SDX65

This commit enables the MSM8939, MDM9615, SAR2130P, and SDX65 clock
controller drivers by default when ARCH_QCOM is selected.

> diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
> index 125831121696e..9f994042bc0a8 100644
> --- a/drivers/clk/qcom/Kconfig
> +++ b/drivers/clk/qcom/Kconfig

[ ... ]

> @@ -1167,6 +1169,7 @@ config SAR_GCC_2130P
>  	tristate "SAR2130P Global Clock Controller"
>  	select QCOM_GDSC
>  	depends on COMMON_CLK_QCOM
> +	default ARCH_QCOM
>  	help
>  	  Support for the global clock controller on SAR2130P devices.
>  	  Say Y if you want to use peripheral devices such as UART, SPI,
> @@ -1176,6 +1179,7 @@ config SAR_GPUCC_2130P
>  	tristate "SAR2130P Graphics clock controller"
>  	select QCOM_GDSC
>  	select SAR_GCC_2130P
> +	default m if ARCH_QCOM

[Severity: Medium]
Should SAR_GCC_2130P and SAR_GPUCC_2130P only default to enabled on
ARM64?

SAR2130P is an ARM64 platform, and neither entry has a "depends on ARM64
|| COMPILE_TEST" line here, so these defaults enable both drivers on
32-bit ARM builds with CONFIG_ARCH_QCOM=y.  Later in the series, commit
"clk: qcom: Consistently handle MSM8996 and SAR2130P" adds "depends on
ARM64 || COMPILE_TEST" to SAR_GCC_2130P but not to SAR_GPUCC_2130P,
which leaves SAR_GPUCC_2130P=m by default on 32-bit ARM and selects
SAR_GCC_2130P with unmet direct dependencies.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261122-qcom-kconfig-unify-v1-0-6abaa7faf1c9@oss.qualcomm.com?part=2

  reply	other threads:[~2026-11-22 13:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-22 13:09 [PATCH 0/4] clk: qcom: Unify KConfig choices between clk, pinctrl and interconnect Krzysztof Kozlowski
2026-11-22 13:09 ` [PATCH 1/4] clk: qcom: Enable MSM8917 GCC by default Krzysztof Kozlowski
2026-11-22 13:09 ` [PATCH 2/4] clk: qcom: Consistently enable MSM8939, MDM9615, SAR2130P and SDX65 Krzysztof Kozlowski
2026-11-22 13:20   ` sashiko-bot [this message]
2026-11-22 13:09 ` [PATCH 3/4] clk: qcom: Drop redundant ARM and ARM64 dependency on IPQ_GCC_5018 Krzysztof Kozlowski
2026-11-22 13:09 ` [PATCH 4/4] clk: qcom: Consistently handle MSM8996 and SAR2130P Krzysztof Kozlowski
2026-11-22 13:19   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-227960@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=krzysztof.kozlowski@oss.qualcomm.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox