From: sashiko-bot@kernel.org
To: "Krzysztof Kozlowski" <krzysztof.kozlowski@oss.qualcomm.com>
Cc: linux-clk@vger.kernel.org
Subject: Re: [PATCH 4/4] clk: qcom: Consistently handle MSM8996 and SAR2130P
Date: Sun, 22 Nov 2026 13:19:24 +0000 [thread overview]
Message-ID: <sashiko-outbox-227958@kernel.org> (raw)
In-Reply-To: <20261122-qcom-kconfig-unify-v1-4-6abaa7faf1c9@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [High] clk: qcom: unmet QCOM_KRYO_L2_ACCESSORS dependency and !ARM64
build failure
- [Medium] clk: qcom: unmet SAR_GCC_2130P dependency from
SAR_GPUCC_2130P on 32-bit ARM
--
commit f5d53fc7ff487e3f47959841dfdfdc27b70db0e5
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
clk: qcom: Consistently handle MSM8996 and SAR2130P
This commit removes the ARM64 dependency from QCOM_CLK_APCC_MSM8996 and
restricts SAR_GCC_2130P to ARM64 || COMPILE_TEST.
> diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
> index f127a3bf911a6..fc77d2aae3437 100644
> --- a/drivers/clk/qcom/Kconfig
> +++ b/drivers/clk/qcom/Kconfig
> @@ -441,8 +441,7 @@ config QCOM_CLK_APCC_MSM8996
> tristate "MSM8996 CPU Clock Controller"
> select QCOM_KRYO_L2_ACCESSORS
> select INTERCONNECT_CLK if INTERCONNECT
> - depends on ARM64
> - default ARCH_QCOM
> + default ARCH_QCOM if ARM64
> help
> Support for the CPU clock controller on msm8996 devices.
> Say Y if you want to support CPU clock scaling using CPUfreq
[Severity: High]
Can QCOM_CLK_APCC_MSM8996 be enabled when ARM64 is disabled?
QCOM_CLK_APCC_MSM8996 selects QCOM_KRYO_L2_ACCESSORS, which depends on
ARM64 in drivers/soc/qcom/Kconfig. Enabling QCOM_CLK_APCC_MSM8996 on
32-bit ARM or non-ARM64 COMPILE_TEST builds triggers an unmet direct
dependency warning and fails to compile because
drivers/soc/qcom/kryo-l2-accessors.c uses the arm64-only asm/sysreg.h
header and AArch64 system register macros, and
drivers/clk/qcom/clk-cpu-8996.c calls read_cpuid_mpidr().
> @@ -1166,6 +1165,7 @@ config SA_GPUCC_8775P
>
> config SAR_GCC_2130P
> tristate "SAR2130P Global Clock Controller"
> + depends on ARM64 || COMPILE_TEST
> select QCOM_GDSC
> depends on COMMON_CLK_QCOM
> default ARCH_QCOM
[Severity: Medium]
Should SAR_GPUCC_2130P also depend on ARM64 || COMPILE_TEST?
drivers/clk/qcom/Kconfig:
config SAR_GPUCC_2130P
tristate "SAR2130P Graphics clock controller"
select QCOM_GDSC
select SAR_GCC_2130P
default m if ARCH_QCOM
On 32-bit ARM builds with ARCH_QCOM=y and COMPILE_TEST=n,
SAR_GPUCC_2130P defaults to m and selects SAR_GCC_2130P, causing an
unmet direct dependency warning for SAR_GCC_2130P.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261122-qcom-kconfig-unify-v1-0-6abaa7faf1c9@oss.qualcomm.com?part=4
prev parent reply other threads:[~2026-11-22 13:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-22 13:09 [PATCH 0/4] clk: qcom: Unify KConfig choices between clk, pinctrl and interconnect Krzysztof Kozlowski
2026-11-22 13:09 ` [PATCH 1/4] clk: qcom: Enable MSM8917 GCC by default Krzysztof Kozlowski
2026-11-22 13:09 ` [PATCH 2/4] clk: qcom: Consistently enable MSM8939, MDM9615, SAR2130P and SDX65 Krzysztof Kozlowski
2026-11-22 13:20 ` sashiko-bot
2026-11-22 13:09 ` [PATCH 3/4] clk: qcom: Drop redundant ARM and ARM64 dependency on IPQ_GCC_5018 Krzysztof Kozlowski
2026-11-22 13:09 ` [PATCH 4/4] clk: qcom: Consistently handle MSM8996 and SAR2130P Krzysztof Kozlowski
2026-11-22 13:19 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-227958@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=linux-clk@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox