Linux clock framework development
 help / color / mirror / Atom feed
* [PATCH 0/4] clk: qcom: Unify KConfig choices between clk, pinctrl and interconnect
@ 2026-11-22 13:09 Krzysztof Kozlowski
  2026-11-22 13:09 ` [PATCH 1/4] clk: qcom: Enable MSM8917 GCC by default Krzysztof Kozlowski
                   ` (3 more replies)
  0 siblings, 4 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2026-11-22 13:09 UTC (permalink / raw)
  To: Bjorn Andersson, Abel Vesa, Stephen Boyd, Brian Masney,
	Jerome Brunet
  Cc: linux-arm-msm, linux-clk, Krzysztof Kozlowski

Recent commits adding defaults to clock, pinctrl and interconnect
drivers left a options inconsistent between them, e.g. SDX65 clock
driver not enabled by default but its pin controller enabled. This
should be a consistent choice - we want by default all critical drivers
enabled.

There will be separate patches for pinctrl and interconnect.

Best regards,
Krzysztof

---
Krzysztof Kozlowski (4):
      clk: qcom: Enable MSM8917 GCC by default
      clk: qcom: Consistently enable MSM8939, MDM9615, SAR2130P and SDX65
      clk: qcom: Drop redundant ARM and ARM64 dependency on IPQ_GCC_5018
      clk: qcom: Consistently handle MSM8996 and SAR2130P

 drivers/clk/qcom/Kconfig | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)
---
base-commit: ddeca928793056a8ffc0e3e107722c25e1836eac
change-id: 20261121-qcom-kconfig-unify-e3ee55b92792

Best regards,
--  
Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 1/4] clk: qcom: Enable MSM8917 GCC by default
  2026-11-22 13:09 [PATCH 0/4] clk: qcom: Unify KConfig choices between clk, pinctrl and interconnect Krzysztof Kozlowski
@ 2026-11-22 13:09 ` Krzysztof Kozlowski
  2026-11-22 13:09 ` [PATCH 2/4] clk: qcom: Consistently enable MSM8939, MDM9615, SAR2130P and SDX65 Krzysztof Kozlowski
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2026-11-22 13:09 UTC (permalink / raw)
  To: Bjorn Andersson, Abel Vesa, Stephen Boyd, Brian Masney,
	Jerome Brunet
  Cc: linux-arm-msm, linux-clk, Krzysztof Kozlowski

MSM8917 is an in-tree supported SoC, so its critical clock controller
driver should be enabled by default.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
 drivers/clk/qcom/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
index e6c58e8b1849..91e774dada4b 100644
--- a/drivers/clk/qcom/Kconfig
+++ b/drivers/clk/qcom/Kconfig
@@ -797,6 +797,7 @@ config MSM_GCC_8917
 	tristate "MSM89(17/37/40)/QM215/SDM439 Global Clock Controller"
 	depends on ARM64 || COMPILE_TEST
 	select QCOM_GDSC
+	default ARCH_QCOM
 	help
 	  Support for the global clock controller on msm8917, msm8937,
 	  msm8940, qm215 and sdm439 devices.

-- 
2.53.0


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH 2/4] clk: qcom: Consistently enable MSM8939, MDM9615, SAR2130P and SDX65
  2026-11-22 13:09 [PATCH 0/4] clk: qcom: Unify KConfig choices between clk, pinctrl and interconnect Krzysztof Kozlowski
  2026-11-22 13:09 ` [PATCH 1/4] clk: qcom: Enable MSM8917 GCC by default Krzysztof Kozlowski
@ 2026-11-22 13:09 ` Krzysztof Kozlowski
  2026-11-22 13:20   ` sashiko-bot
  2026-11-22 13:09 ` [PATCH 3/4] clk: qcom: Drop redundant ARM and ARM64 dependency on IPQ_GCC_5018 Krzysztof Kozlowski
  2026-11-22 13:09 ` [PATCH 4/4] clk: qcom: Consistently handle MSM8996 and SAR2130P Krzysztof Kozlowski
  3 siblings, 1 reply; 7+ messages in thread
From: Krzysztof Kozlowski @ 2026-11-22 13:09 UTC (permalink / raw)
  To: Bjorn Andersson, Abel Vesa, Stephen Boyd, Brian Masney,
	Jerome Brunet
  Cc: linux-arm-msm, linux-clk, Krzysztof Kozlowski

Critical drivers for MSM8939, MDM9615, SAR2130P and SDX65, like pin
controller and interconnect, are already enabled by default, so should
be the clock controller drivers as well.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
 drivers/clk/qcom/Kconfig | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
index 91e774dada4b..757f52910f94 100644
--- a/drivers/clk/qcom/Kconfig
+++ b/drivers/clk/qcom/Kconfig
@@ -807,6 +807,7 @@ config MSM_GCC_8917
 config MSM_GCC_8939
 	tristate "MSM8939 Global Clock Controller"
 	select QCOM_GDSC
+	default ARCH_QCOM if ARM64
 	help
 	  Support for the global clock controller on msm8939 devices.
 	  Say Y if you want to use devices such as UART, SPI i2c, USB,
@@ -852,6 +853,7 @@ config MDM_GCC_9607
 config MDM_GCC_9615
 	tristate "MDM9615 Global Clock Controller"
 	depends on ARM || COMPILE_TEST
+	default ARCH_QCOM
 	help
 	  Support for the global clock controller on mdm9615 devices.
 	  Say Y if you want to use peripheral devices such as UART, SPI,
@@ -1189,6 +1191,7 @@ config SAR_GCC_2130P
 	tristate "SAR2130P Global Clock Controller"
 	select QCOM_GDSC
 	depends on COMMON_CLK_QCOM
+	default ARCH_QCOM
 	help
 	  Support for the global clock controller on SAR2130P devices.
 	  Say Y if you want to use peripheral devices such as UART, SPI,
@@ -1198,6 +1201,7 @@ config SAR_GPUCC_2130P
 	tristate "SAR2130P Graphics clock controller"
 	select QCOM_GDSC
 	select SAR_GCC_2130P
+	default m if ARCH_QCOM
 	help
 	  Support for the graphics clock controller on SAR2130P devices.
 	  Say Y if you want to support graphics controller devices and
@@ -1480,6 +1484,7 @@ config SDX_GCC_65
 	tristate "SDX65 Global Clock Controller"
 	depends on ARM || COMPILE_TEST
 	select QCOM_GDSC
+	default ARCH_QCOM
 	help
 	  Support for the global clock controller on SDX65 devices.
 	  Say Y if you want to use peripheral devices such as UART,

-- 
2.53.0


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH 3/4] clk: qcom: Drop redundant ARM and ARM64 dependency on IPQ_GCC_5018
  2026-11-22 13:09 [PATCH 0/4] clk: qcom: Unify KConfig choices between clk, pinctrl and interconnect Krzysztof Kozlowski
  2026-11-22 13:09 ` [PATCH 1/4] clk: qcom: Enable MSM8917 GCC by default Krzysztof Kozlowski
  2026-11-22 13:09 ` [PATCH 2/4] clk: qcom: Consistently enable MSM8939, MDM9615, SAR2130P and SDX65 Krzysztof Kozlowski
@ 2026-11-22 13:09 ` Krzysztof Kozlowski
  2026-11-22 13:09 ` [PATCH 4/4] clk: qcom: Consistently handle MSM8996 and SAR2130P Krzysztof Kozlowski
  3 siblings, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2026-11-22 13:09 UTC (permalink / raw)
  To: Bjorn Andersson, Abel Vesa, Stephen Boyd, Brian Masney,
	Jerome Brunet
  Cc: linux-arm-msm, linux-clk, Krzysztof Kozlowski

All Qualcomm clock controller CONFIG entries depend on ARCH_QCOM which
is ARM and ARM64 platform, thus additional depends for IPQ5018 is
redundant.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
 drivers/clk/qcom/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
index 757f52910f94..6ddfa451ad55 100644
--- a/drivers/clk/qcom/Kconfig
+++ b/drivers/clk/qcom/Kconfig
@@ -643,7 +643,6 @@ config IPQ_GCC_4019
 
 config IPQ_GCC_5018
 	tristate "IPQ5018 Global Clock Controller"
-	depends on ARM || ARM64 || COMPILE_TEST
 	default ARCH_QCOM && ARM64
 	help
 	  Support for global clock controller on ipq5018 devices.

-- 
2.53.0


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH 4/4] clk: qcom: Consistently handle MSM8996 and SAR2130P
  2026-11-22 13:09 [PATCH 0/4] clk: qcom: Unify KConfig choices between clk, pinctrl and interconnect Krzysztof Kozlowski
                   ` (2 preceding siblings ...)
  2026-11-22 13:09 ` [PATCH 3/4] clk: qcom: Drop redundant ARM and ARM64 dependency on IPQ_GCC_5018 Krzysztof Kozlowski
@ 2026-11-22 13:09 ` Krzysztof Kozlowski
  2026-11-22 13:19   ` sashiko-bot
  3 siblings, 1 reply; 7+ messages in thread
From: Krzysztof Kozlowski @ 2026-11-22 13:09 UTC (permalink / raw)
  To: Bjorn Andersson, Abel Vesa, Stephen Boyd, Brian Masney,
	Jerome Brunet
  Cc: linux-arm-msm, linux-clk, Krzysztof Kozlowski

Restrict Qualcomm SoC clock controller drivers to ARM or ARM64 in a
consistent way with other critical drivers (pin controllers,
interconnects):

1. SAR2130P SoC has only ARM64 DTS user and other drivers are
   already restricted to ARM64 only.

2. Other drivers for MSM8996 are allowed for ARM 32-bit builds.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
 drivers/clk/qcom/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
index 6ddfa451ad55..a05a3a853871 100644
--- a/drivers/clk/qcom/Kconfig
+++ b/drivers/clk/qcom/Kconfig
@@ -463,8 +463,7 @@ config QCOM_CLK_APCC_MSM8996
 	tristate "MSM8996 CPU Clock Controller"
 	select QCOM_KRYO_L2_ACCESSORS
 	select INTERCONNECT_CLK if INTERCONNECT
-	depends on ARM64
-	default ARCH_QCOM
+	default ARCH_QCOM if ARM64
 	help
 	  Support for the CPU clock controller on msm8996 devices.
 	  Say Y if you want to support CPU clock scaling using CPUfreq
@@ -1188,6 +1187,7 @@ config SA_GPUCC_8775P
 
 config SAR_GCC_2130P
 	tristate "SAR2130P Global Clock Controller"
+	depends on ARM64 || COMPILE_TEST
 	select QCOM_GDSC
 	depends on COMMON_CLK_QCOM
 	default ARCH_QCOM

-- 
2.53.0


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH 4/4] clk: qcom: Consistently handle MSM8996 and SAR2130P
  2026-11-22 13:09 ` [PATCH 4/4] clk: qcom: Consistently handle MSM8996 and SAR2130P Krzysztof Kozlowski
@ 2026-11-22 13:19   ` sashiko-bot
  0 siblings, 0 replies; 7+ messages in thread
From: sashiko-bot @ 2026-11-22 13:19 UTC (permalink / raw)
  To: Krzysztof Kozlowski; +Cc: linux-clk

Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [High] clk: qcom: unmet QCOM_KRYO_L2_ACCESSORS dependency and !ARM64
  build failure
- [Medium] clk: qcom: unmet SAR_GCC_2130P dependency from
  SAR_GPUCC_2130P on 32-bit ARM
--

commit f5d53fc7ff487e3f47959841dfdfdc27b70db0e5
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

clk: qcom: Consistently handle MSM8996 and SAR2130P

This commit removes the ARM64 dependency from QCOM_CLK_APCC_MSM8996 and
restricts SAR_GCC_2130P to ARM64 || COMPILE_TEST.

> diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
> index f127a3bf911a6..fc77d2aae3437 100644
> --- a/drivers/clk/qcom/Kconfig
> +++ b/drivers/clk/qcom/Kconfig
> @@ -441,8 +441,7 @@ config QCOM_CLK_APCC_MSM8996
>  	tristate "MSM8996 CPU Clock Controller"
>  	select QCOM_KRYO_L2_ACCESSORS
>  	select INTERCONNECT_CLK if INTERCONNECT
> -	depends on ARM64
> -	default ARCH_QCOM
> +	default ARCH_QCOM if ARM64
>  	help
>  	  Support for the CPU clock controller on msm8996 devices.
>  	  Say Y if you want to support CPU clock scaling using CPUfreq

[Severity: High]
Can QCOM_CLK_APCC_MSM8996 be enabled when ARM64 is disabled?

QCOM_CLK_APCC_MSM8996 selects QCOM_KRYO_L2_ACCESSORS, which depends on
ARM64 in drivers/soc/qcom/Kconfig.  Enabling QCOM_CLK_APCC_MSM8996 on
32-bit ARM or non-ARM64 COMPILE_TEST builds triggers an unmet direct
dependency warning and fails to compile because
drivers/soc/qcom/kryo-l2-accessors.c uses the arm64-only asm/sysreg.h
header and AArch64 system register macros, and
drivers/clk/qcom/clk-cpu-8996.c calls read_cpuid_mpidr().

> @@ -1166,6 +1165,7 @@ config SA_GPUCC_8775P
>  
>  config SAR_GCC_2130P
>  	tristate "SAR2130P Global Clock Controller"
> +	depends on ARM64 || COMPILE_TEST
>  	select QCOM_GDSC
>  	depends on COMMON_CLK_QCOM
>  	default ARCH_QCOM

[Severity: Medium]
Should SAR_GPUCC_2130P also depend on ARM64 || COMPILE_TEST?

drivers/clk/qcom/Kconfig:
config SAR_GPUCC_2130P
	tristate "SAR2130P Graphics clock controller"
	select QCOM_GDSC
	select SAR_GCC_2130P
	default m if ARCH_QCOM

On 32-bit ARM builds with ARCH_QCOM=y and COMPILE_TEST=n,
SAR_GPUCC_2130P defaults to m and selects SAR_GCC_2130P, causing an
unmet direct dependency warning for SAR_GCC_2130P.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261122-qcom-kconfig-unify-v1-0-6abaa7faf1c9@oss.qualcomm.com?part=4

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 2/4] clk: qcom: Consistently enable MSM8939, MDM9615, SAR2130P and SDX65
  2026-11-22 13:09 ` [PATCH 2/4] clk: qcom: Consistently enable MSM8939, MDM9615, SAR2130P and SDX65 Krzysztof Kozlowski
@ 2026-11-22 13:20   ` sashiko-bot
  0 siblings, 0 replies; 7+ messages in thread
From: sashiko-bot @ 2026-11-22 13:20 UTC (permalink / raw)
  To: Krzysztof Kozlowski; +Cc: linux-clk

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] clk: qcom: SAR_GCC_2130P and SAR_GPUCC_2130P enabled by
  default on 32-bit ARM
--

commit 26558b027ddd75e632c3e98cf03a0b97873008a1
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

clk: qcom: Consistently enable MSM8939, MDM9615, SAR2130P and SDX65

This commit enables the MSM8939, MDM9615, SAR2130P, and SDX65 clock
controller drivers by default when ARCH_QCOM is selected.

> diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
> index 125831121696e..9f994042bc0a8 100644
> --- a/drivers/clk/qcom/Kconfig
> +++ b/drivers/clk/qcom/Kconfig

[ ... ]

> @@ -1167,6 +1169,7 @@ config SAR_GCC_2130P
>  	tristate "SAR2130P Global Clock Controller"
>  	select QCOM_GDSC
>  	depends on COMMON_CLK_QCOM
> +	default ARCH_QCOM
>  	help
>  	  Support for the global clock controller on SAR2130P devices.
>  	  Say Y if you want to use peripheral devices such as UART, SPI,
> @@ -1176,6 +1179,7 @@ config SAR_GPUCC_2130P
>  	tristate "SAR2130P Graphics clock controller"
>  	select QCOM_GDSC
>  	select SAR_GCC_2130P
> +	default m if ARCH_QCOM

[Severity: Medium]
Should SAR_GCC_2130P and SAR_GPUCC_2130P only default to enabled on
ARM64?

SAR2130P is an ARM64 platform, and neither entry has a "depends on ARM64
|| COMPILE_TEST" line here, so these defaults enable both drivers on
32-bit ARM builds with CONFIG_ARCH_QCOM=y.  Later in the series, commit
"clk: qcom: Consistently handle MSM8996 and SAR2130P" adds "depends on
ARM64 || COMPILE_TEST" to SAR_GCC_2130P but not to SAR_GPUCC_2130P,
which leaves SAR_GPUCC_2130P=m by default on 32-bit ARM and selects
SAR_GCC_2130P with unmet direct dependencies.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261122-qcom-kconfig-unify-v1-0-6abaa7faf1c9@oss.qualcomm.com?part=2

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2026-11-22 13:20 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-22 13:09 [PATCH 0/4] clk: qcom: Unify KConfig choices between clk, pinctrl and interconnect Krzysztof Kozlowski
2026-11-22 13:09 ` [PATCH 1/4] clk: qcom: Enable MSM8917 GCC by default Krzysztof Kozlowski
2026-11-22 13:09 ` [PATCH 2/4] clk: qcom: Consistently enable MSM8939, MDM9615, SAR2130P and SDX65 Krzysztof Kozlowski
2026-11-22 13:20   ` sashiko-bot
2026-11-22 13:09 ` [PATCH 3/4] clk: qcom: Drop redundant ARM and ARM64 dependency on IPQ_GCC_5018 Krzysztof Kozlowski
2026-11-22 13:09 ` [PATCH 4/4] clk: qcom: Consistently handle MSM8996 and SAR2130P Krzysztof Kozlowski
2026-11-22 13:19   ` sashiko-bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox