From: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
To: "Li, Xiaoyao" <xiaoyao.li@intel.com>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"seanjc@google.com" <seanjc@google.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-coco@lists.linux.dev" <linux-coco@lists.linux.dev>,
"kas@kernel.org" <kas@kernel.org>,
"nik.borisov@suse.com" <nik.borisov@suse.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/3] KVM: TDX: Fix the exit reason handling
Date: Tue, 11 Aug 2026 15:20:40 +0000 [thread overview]
Message-ID: <0a458dd822e5469068d5dea6aea3dd935b69e963.camel@intel.com> (raw)
In-Reply-To: <6bb1328d-e995-4ad7-9744-3ab01d2ae591@intel.com>
On Tue, 2026-08-11 at 09:32 +0800, Xiaoyao Li wrote:
> > We could make this return instead be a goto err; that returns this. Bonus is
> > the
> > comment on the other one can cover them both. What do you think?
>
> Given 1) this patch is here mainly to avoid the false-positive on
> bus_lock_detected after the next patch,
Hmm. Before this patch these are just one line returns. So a "goto err" would be
unneeded. After this single line is expanded to be something more elaborate, and
a comment is added around one of these more elaborate returns, but not the
other. So I consider it a bit of a style regression. Which makes it appropriate
to adjust it in the patch IMO.
> 2) the whole series is targeted
> for stable kernels, and 3) this part will change as suggested by [1]
This is true.
>
> I think we can just leave it as-is to make the change as simple as possible.
>
> [1] https://lore.kernel.org/all/anXxBzO41_5eaaOI@google.com/
next prev parent reply other threads:[~2026-08-11 15:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-10 11:21 [PATCH v2 0/3] KVM: TDX: Enable VM-DoS Prevention Features for TDX Xiaoyao Li
2026-08-10 11:21 ` [PATCH v2 1/3] KVM: TDX: Enable Notify VM exit Xiaoyao Li
2026-08-11 0:37 ` Edgecombe, Rick P
2026-08-10 11:21 ` [PATCH v2 2/3] KVM: TDX: Fix the exit reason handling Xiaoyao Li
2026-08-11 0:03 ` Sean Christopherson
2026-08-11 3:17 ` Xiaoyao Li
2026-08-11 17:36 ` Sean Christopherson
2026-08-11 0:38 ` Edgecombe, Rick P
2026-08-11 1:32 ` Xiaoyao Li
2026-08-11 15:20 ` Edgecombe, Rick P [this message]
2026-08-10 11:22 ` [PATCH v2 3/3] KVM: TDX: Enable Bus Lock VM exit Xiaoyao Li
2026-08-11 1:18 ` Edgecombe, Rick P
2026-08-11 1:44 ` Xiaoyao Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a458dd822e5469068d5dea6aea3dd935b69e963.camel@intel.com \
--to=rick.p.edgecombe@intel.com \
--cc=kas@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=nik.borisov@suse.com \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=xiaoyao.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox