From: Binbin Wu <binbin.wu@linux.intel.com>
To: Lisa Wang <wyihan@google.com>
Cc: Andrew Jones <ajones@ventanamicro.com>,
Ackerley Tng <ackerleytng@google.com>,
Chao Gao <chao.gao@intel.com>,
Chenyi Qiang <chenyi.qiang@intel.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Erdem Aktas <erdemaktas@google.com>,
Ira Weiny <ira.weiny@intel.com>,
Isaku Yamahata <isaku.yamahata@intel.com>,
Kiryl Shutsemau <kas@kernel.org>,
linux-kselftest@vger.kernel.org,
Paolo Bonzini <pbonzini@redhat.com>,
"Pratik R. Sampat" <pratikrajesh.sampat@amd.com>,
Reinette Chatre <reinette.chatre@intel.com>,
Rick Edgecombe <rick.p.edgecombe@intel.com>,
Roger Wang <runanwang@google.com>,
Ryan Afranji <afranji@google.com>, Sagi Shahar <sagis@google.com>,
Sean Christopherson <seanjc@google.com>,
Shuah Khan <shuah@kernel.org>, Oliver Upton <oupton@kernel.org>,
Jeremiah McReynolds <jmcrey@google.com>,
kvm@vger.kernel.org, linux-coco@lists.linux.dev,
linux-kernel@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH v13 12/22] KVM: selftests: Back the first memory region with guest_memfd for TDX
Date: Mon, 8 Jun 2026 15:31:10 +0800 [thread overview]
Message-ID: <14385c18-a236-44fd-8728-598d6b6cc8a5@linux.intel.com> (raw)
In-Reply-To: <20260521-tdx-selftests-v13-v13-12-6983ae4c3a4d@google.com>
On 5/22/2026 7:16 AM, Lisa Wang wrote:
> Force GUEST_MEMFD for the primary memory region of TDX VMs.
>
> TDX must use guest_memfd for private pages as there is no alternative
> mechanism supported by the TDX architecture.
This sounds a bit confusing to me.
It's the kernel/KVM only support guest_memfd for private pages.
The restriction is not from the "TDX architecture".
Also, the short log is also a bit confusing.
Why describe the "first memory region" here?
>
> Signed-off-by: Lisa Wang <wyihan@google.com>
> ---
> tools/testing/selftests/kvm/lib/kvm_util.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/kvm/lib/kvm_util.c b/tools/testing/selftests/kvm/lib/kvm_util.c
> index d1befa3f4b30..9a29540fff40 100644
> --- a/tools/testing/selftests/kvm/lib/kvm_util.c
> +++ b/tools/testing/selftests/kvm/lib/kvm_util.c
> @@ -472,7 +472,7 @@ void kvm_set_files_rlimit(u32 nr_vcpus)
> static bool is_guest_memfd_required(struct vm_shape shape)
> {
> #ifdef __x86_64__
> - return shape.type == KVM_X86_SNP_VM;
> + return (shape.type == KVM_X86_SNP_VM || shape.type == KVM_X86_TDX_VM);
> #else
> return false;
> #endif
>
next prev parent reply other threads:[~2026-06-08 7:31 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-21 23:16 [PATCH v13 00/22] TDX KVM selftests Lisa Wang
2026-05-21 23:16 ` [PATCH v13 01/22] KVM: selftests: Add macros to simplify creating VM shapes for non-default types Lisa Wang
2026-05-21 23:16 ` [PATCH v13 02/22] KVM: selftests: Update kvm_init_vm_address_properties() for TDX Lisa Wang
2026-05-21 23:16 ` [PATCH v13 03/22] KVM: selftests: Initialize the TDX VM Lisa Wang
2026-06-08 5:57 ` Binbin Wu
2026-05-21 23:16 ` [PATCH v13 04/22] KVM: selftests: TDX: Use KVM_TDX_CAPABILITIES to validate TDs' attribute configuration Lisa Wang
2026-05-21 23:16 ` [PATCH v13 05/22] KVM: selftests: Expose segment definitions to assembly files Lisa Wang
2026-05-21 23:16 ` [PATCH v13 06/22] tools: include: Add kbuild.h for assembly structure offsets Lisa Wang
2026-06-08 6:12 ` Binbin Wu
2026-05-21 23:16 ` [PATCH v13 07/22] KVM: selftests: Introduce structures for TDX guest boot parameters Lisa Wang
2026-05-22 17:43 ` Yosry Ahmed
2026-05-22 23:05 ` Sean Christopherson
[not found] ` <CAO9r8zMaiGL8v=f72EAwWbwofoUHOkH8r6Se22k2TVxnUCQLOQ@mail.gmail.com>
2026-05-28 19:25 ` Yosry Ahmed
2026-05-21 23:16 ` [PATCH v13 08/22] KVM: selftests: Add TDX boot code Lisa Wang
2026-05-21 23:16 ` [PATCH v13 09/22] KVM: selftests: Expose functions to get default sregs values Lisa Wang
2026-06-08 6:39 ` Binbin Wu
2026-05-21 23:16 ` [PATCH v13 10/22] KVM: selftests: Set up TDX boot code region Lisa Wang
2026-05-21 23:16 ` [PATCH v13 11/22] KVM: selftests: Set up TDX boot parameters region Lisa Wang
2026-06-08 7:23 ` Binbin Wu
2026-05-21 23:16 ` [PATCH v13 12/22] KVM: selftests: Back the first memory region with guest_memfd for TDX Lisa Wang
2026-06-08 7:31 ` Binbin Wu [this message]
2026-05-21 23:16 ` [PATCH v13 13/22] KVM: selftests: Set first memory region as shared if guest_memfd Lisa Wang
2026-06-08 8:03 ` Binbin Wu
2026-05-21 23:16 ` [PATCH v13 14/22] KVM: selftests: Expose function to allocate vCPU stack Lisa Wang
2026-05-21 23:16 ` [PATCH v13 15/22] KVM: selftests: Call KVM_TDX_INIT_VCPU when creating a new TDX vcpu Lisa Wang
2026-06-08 8:34 ` Binbin Wu
2026-05-21 23:16 ` [PATCH v13 16/22] KVM: selftests: Load per-vCPU guest stack in TDX boot parameters Lisa Wang
2026-05-21 23:16 ` [PATCH v13 17/22] KVM: selftests: Set entry point for TDX guest code Lisa Wang
2026-05-21 23:16 ` [PATCH v13 18/22] KVM: selftests: Add helpers to init TDX memory and finalize VM Lisa Wang
2026-05-21 23:17 ` [PATCH v13 19/22] KVM: selftests: Finalize TD memory as part of kvm_arch_vm_finalize_vcpus Lisa Wang
2026-06-05 13:58 ` Ackerley Tng
2026-06-05 17:58 ` Sean Christopherson
2026-06-05 18:27 ` Ackerley Tng
2026-06-05 20:48 ` Sean Christopherson
2026-05-21 23:17 ` [PATCH v13 20/22] KVM: selftests: Implement MMIO WRITE for the TDX VM Lisa Wang
2026-05-21 23:17 ` [PATCH v13 21/22] KVM: selftests: Add ucall support for TDX Lisa Wang
2026-05-21 23:17 ` [PATCH v13 22/22] KVM: selftests: Add TDX lifecycle test Lisa Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14385c18-a236-44fd-8728-598d6b6cc8a5@linux.intel.com \
--to=binbin.wu@linux.intel.com \
--cc=ackerleytng@google.com \
--cc=afranji@google.com \
--cc=ajones@ventanamicro.com \
--cc=chao.gao@intel.com \
--cc=chenyi.qiang@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=erdemaktas@google.com \
--cc=ira.weiny@intel.com \
--cc=isaku.yamahata@intel.com \
--cc=jmcrey@google.com \
--cc=kas@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=oupton@kernel.org \
--cc=pbonzini@redhat.com \
--cc=pratikrajesh.sampat@amd.com \
--cc=reinette.chatre@intel.com \
--cc=rick.p.edgecombe@intel.com \
--cc=runanwang@google.com \
--cc=sagis@google.com \
--cc=seanjc@google.com \
--cc=shuah@kernel.org \
--cc=wyihan@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox